From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40C43C47E49 for ; Mon, 21 Oct 2019 22:21:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1672720873 for ; Mon, 21 Oct 2019 22:21:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="036YnA8M" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730289AbfJUWVs (ORCPT ); Mon, 21 Oct 2019 18:21:48 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:32994 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727264AbfJUWVs (ORCPT ); Mon, 21 Oct 2019 18:21:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6uc83vVbAQNL+hWSYNLKkGKf3OFD2g2M4EAFEdxCp8k=; b=036YnA8M35zh7oaZP5i2lrsye EB0cDqf3F8uePuPil4Bamdbm8KtNRvsBdq07e1aHHJgDobEYpDojY9mOeX8YPPd1J2sC+mh+6VDxc /V9CA6YUSYv9pEQ1D6eRYBtf0ymOBj8sxubqz1HIJtD2vM6dH1pOOQwIR9tY0McREESQviSLk1hDT 9Aad+EJGZHzyyUWVCsvOL2mAZKl5VCw9Vi52BbeATUdSZaXmXoUrg26XhJ0lkzlnbH06WL0VYhCfN UvtH8sR/oeNe0DxU2hwkxapIuU4gWA+ug0hzwvSwDebQsKNrfX++HAyF36QsP7DTwur0NBbrWwgBa pjPKOdWUg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:57354) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iMg3O-0003H1-0z; Mon, 21 Oct 2019 23:21:30 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1iMg3G-0003uw-Oy; Mon, 21 Oct 2019 23:21:22 +0100 Date: Mon, 21 Oct 2019 23:21:22 +0100 From: Russell King - ARM Linux admin To: Oleksij Rempel Cc: Andrew Lunn , Chris Snook , Florian Fainelli , James Hogan , Jay Cliburn , Mark Rutland , Paul Burton , Ralf Baechle , Rob Herring , Vivien Didelot , Pengutronix Kernel Team , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: [PATCH v3 1/5] net: ag71xx: port to phylink Message-ID: <20191021222122.GM25745@shell.armlinux.org.uk> References: <20191021053811.19818-1-o.rempel@pengutronix.de> <20191021053811.19818-2-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191021053811.19818-2-o.rempel@pengutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Oct 21, 2019 at 07:38:07AM +0200, Oleksij Rempel wrote: > +static void ag71xx_mac_validate(struct phylink_config *config, > + unsigned long *supported, > + struct phylink_link_state *state) > { > - struct ag71xx *ag = netdev_priv(ndev); > + __ETHTOOL_DECLARE_LINK_MODE_MASK(mask) = { 0, }; > + > + if (state->interface != PHY_INTERFACE_MODE_NA && > + state->interface != PHY_INTERFACE_MODE_GMII && > + state->interface != PHY_INTERFACE_MODE_MII) { > + bitmap_zero(supported, __ETHTOOL_LINK_MODE_MASK_NBITS); > + return; > + } > + > + phylink_set(mask, MII); > + > + /* flow control is not supported */ > + > + phylink_set(mask, 10baseT_Half); > + phylink_set(mask, 10baseT_Full); > + phylink_set(mask, 100baseT_Half); > + phylink_set(mask, 100baseT_Full); > > - ag71xx_link_adjust(ag, true); > + if (state->interface == PHY_INTERFACE_MODE_NA && > + state->interface == PHY_INTERFACE_MODE_GMII) { This is always false. Apart from that, from just reading the patch I have no further concerns. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up