* [PATCH] dt-bindings: mma8452: Re-word 'interrupt-names' description
@ 2019-10-22 3:56 Andrey Smirnov
2019-10-22 8:43 ` Martin Kepplinger
0 siblings, 1 reply; 4+ messages in thread
From: Andrey Smirnov @ 2019-10-22 3:56 UTC (permalink / raw)
To: linux-iio
Cc: Andrey Smirnov, Chris Healy, Jonathan Cameron, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler, devicetree,
linux-kernel
Current wording in the binding documentation doesn't make it 100%
clear that only one of "INT1" and "INT2" will ever be used by the
driver and that specifying both has no advantages. Re-word it to make
this aspect a bit more explicit.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Chris Healy <cphealy@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
Documentation/devicetree/bindings/iio/accel/mma8452.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
index e132394375a1..b27b6bee9eb6 100644
--- a/Documentation/devicetree/bindings/iio/accel/mma8452.txt
+++ b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
@@ -17,7 +17,7 @@ Optional properties:
- interrupts: interrupt mapping for GPIO IRQ
- - interrupt-names: should contain "INT1" and/or "INT2", the accelerometer's
+ - interrupt-names: should contain "INT1" or "INT2", the accelerometer's
interrupt line in use.
- vdd-supply: phandle to the regulator that provides vdd power to the accelerometer.
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: mma8452: Re-word 'interrupt-names' description
2019-10-22 3:56 [PATCH] dt-bindings: mma8452: Re-word 'interrupt-names' description Andrey Smirnov
@ 2019-10-22 8:43 ` Martin Kepplinger
2019-10-22 10:50 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Martin Kepplinger @ 2019-10-22 8:43 UTC (permalink / raw)
To: Andrey Smirnov, linux-iio
Cc: Chris Healy, Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, devicetree, linux-kernel
On 22.10.19 05:56, Andrey Smirnov wrote:
> Current wording in the binding documentation doesn't make it 100%
> clear that only one of "INT1" and "INT2" will ever be used by the
> driver and that specifying both has no advantages. Re-word it to make
> this aspect a bit more explicit.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Cc: Chris Healy <cphealy@gmail.com>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Hartmut Knaack <knaack.h@gmx.de>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
> Cc: linux-iio@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> Documentation/devicetree/bindings/iio/accel/mma8452.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> index e132394375a1..b27b6bee9eb6 100644
> --- a/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> +++ b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> @@ -17,7 +17,7 @@ Optional properties:
>
> - interrupts: interrupt mapping for GPIO IRQ
>
> - - interrupt-names: should contain "INT1" and/or "INT2", the accelerometer's
> + - interrupt-names: should contain "INT1" or "INT2", the accelerometer's
> interrupt line in use.
>
> - vdd-supply: phandle to the regulator that provides vdd power to the accelerometer.
>
Acked-by: Martin Kepplinger <martink@posteo.de>
thanks,
martin
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: mma8452: Re-word 'interrupt-names' description
2019-10-22 8:43 ` Martin Kepplinger
@ 2019-10-22 10:50 ` Jonathan Cameron
2019-10-22 13:08 ` Martin Kepplinger
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Cameron @ 2019-10-22 10:50 UTC (permalink / raw)
To: Martin Kepplinger
Cc: Andrey Smirnov, linux-iio, Chris Healy, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler, devicetree,
linux-kernel
On Tue, 22 Oct 2019 10:43:09 +0200
Martin Kepplinger <martink@posteo.de> wrote:
> On 22.10.19 05:56, Andrey Smirnov wrote:
> > Current wording in the binding documentation doesn't make it 100%
> > clear that only one of "INT1" and "INT2" will ever be used by the
> > driver and that specifying both has no advantages. Re-word it to make
> > this aspect a bit more explicit.
From a quick glance at the datasheet, it appears that the hardware
is capable of routing different interrupts to different pins, even
if the driver does not do so.
CTRL_REG5 has 6 different bits to set whether particular blocks have
their interrupt routed to INT1 or INT2, so it appears to be possible
to send some each way.
A binding is for the hardware not the driver, so if I'm right about this
the current text is correct and should be left alone.
Thanks,
Jonathan
> >
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> > Cc: Chris Healy <cphealy@gmail.com>
> > Cc: Jonathan Cameron <jic23@kernel.org>
> > Cc: Hartmut Knaack <knaack.h@gmx.de>
> > Cc: Lars-Peter Clausen <lars@metafoo.de>
> > Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
> > Cc: linux-iio@vger.kernel.org
> > Cc: devicetree@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > ---
> > Documentation/devicetree/bindings/iio/accel/mma8452.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> > index e132394375a1..b27b6bee9eb6 100644
> > --- a/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> > +++ b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> > @@ -17,7 +17,7 @@ Optional properties:
> >
> > - interrupts: interrupt mapping for GPIO IRQ
> >
> > - - interrupt-names: should contain "INT1" and/or "INT2", the accelerometer's
> > + - interrupt-names: should contain "INT1" or "INT2", the accelerometer's
> > interrupt line in use.
> >
> > - vdd-supply: phandle to the regulator that provides vdd power to the accelerometer.
> >
>
> Acked-by: Martin Kepplinger <martink@posteo.de>
>
> thanks,
>
> martin
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: mma8452: Re-word 'interrupt-names' description
2019-10-22 10:50 ` Jonathan Cameron
@ 2019-10-22 13:08 ` Martin Kepplinger
0 siblings, 0 replies; 4+ messages in thread
From: Martin Kepplinger @ 2019-10-22 13:08 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Andrey Smirnov, linux-iio, Chris Healy, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler, devicetree,
linux-kernel
On 22.10.19 12:50, Jonathan Cameron wrote:
> On Tue, 22 Oct 2019 10:43:09 +0200
> Martin Kepplinger <martink@posteo.de> wrote:
>
>> On 22.10.19 05:56, Andrey Smirnov wrote:
>>> Current wording in the binding documentation doesn't make it 100%
>>> clear that only one of "INT1" and "INT2" will ever be used by the
>>> driver and that specifying both has no advantages. Re-word it to make
>>> this aspect a bit more explicit.
>
> From a quick glance at the datasheet, it appears that the hardware
> is capable of routing different interrupts to different pins, even
> if the driver does not do so.
>
> CTRL_REG5 has 6 different bits to set whether particular blocks have
> their interrupt routed to INT1 or INT2, so it appears to be possible
> to send some each way.
>
> A binding is for the hardware not the driver, so if I'm right about this
> the current text is correct and should be left alone.
right, please ignore my "acked-by". Thanks a lot for taking a look.
martin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-22 13:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-22 3:56 [PATCH] dt-bindings: mma8452: Re-word 'interrupt-names' description Andrey Smirnov
2019-10-22 8:43 ` Martin Kepplinger
2019-10-22 10:50 ` Jonathan Cameron
2019-10-22 13:08 ` Martin Kepplinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).