From: Mark Brown <broonie@kernel.org>
To: Tomasz Figa <tfiga@chromium.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Bibby Hsieh <bibby.hsieh@mediatek.com>,
linux-i2c <linux-i2c@vger.kernel.org>,
Nicolas Boichat <drinkcat@chromium.org>,
srv_heupstream <srv_heupstream@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-devicetree <devicetree@vger.kernel.org>
Subject: Re: [PATCH v4] misc: eeprom: at24: support pm_runtime control
Date: Tue, 22 Oct 2019 12:19:08 +0100 [thread overview]
Message-ID: <20191022111908.GC5554@sirena.co.uk> (raw)
In-Reply-To: <CAAFQd5D=T+x7j+Lst8AQt0epLckPJv_bXtNGs3Dk=kbdbfw53Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1066 bytes --]
On Tue, Oct 22, 2019 at 07:33:54PM +0900, Tomasz Figa wrote:
> On Tue, Oct 22, 2019 at 6:00 PM Bartosz Golaszewski
> > > I can see that the core returns the dummy regulator if
> > > have_full_constraints() [1]. That is always true for DT systems, but
> > > for others it's false by default, unless someone explicitly calls
> > > regulator_has_full_constraints() [2].
ACPI systems are also always marked as having full constraints, only
systems with board files will see this.
> > Not tested yet, but from the code it looks like it will then keep
> > returning EPROBE_DEFER which doesn't sound right really, especially
> > since we're printing an error message too. Shouldn't it be -ENODEV?
> That's an interesting finding. Liam, Mark, what's the proper way to
> bulk get optional regulators?
The ambiguously named regulator_get_optional(). This should *only* be
used for regulators that may be physically absent in the system, other
regulators should use normal regulator_get(). It is vanishingly
unlikely that all the supplies for a device will be optional.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-10-22 11:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 8:25 [PATCH v4] misc: eeprom: at24: support pm_runtime control Bibby Hsieh
2019-10-18 8:25 ` [PATCH v2] dt-binding: eeprom: at24: add supply properties Bibby Hsieh
2019-10-18 10:07 ` Bartosz Golaszewski
2019-10-24 6:22 ` Bartosz Golaszewski
2019-10-24 7:01 ` Tomasz Figa
2019-10-24 8:40 ` Bartosz Golaszewski
2019-10-24 9:32 ` Tomasz Figa
2019-10-25 21:10 ` Rob Herring
2019-10-26 12:05 ` Bartosz Golaszewski
2019-10-28 2:36 ` Bibby Hsieh
2019-11-07 14:32 ` Tomasz Figa
2019-10-24 6:48 ` Peter Rosin
2019-10-18 9:24 ` [PATCH v4] misc: eeprom: at24: support pm_runtime control Tomasz Figa
2019-10-18 10:11 ` Bartosz Golaszewski
2019-10-22 2:25 ` Bibby Hsieh
2019-10-21 16:53 ` Bartosz Golaszewski
2019-10-22 2:23 ` Bibby Hsieh
2019-10-22 7:26 ` Tomasz Figa
2019-10-22 9:00 ` Bartosz Golaszewski
2019-10-22 10:33 ` Tomasz Figa
2019-10-22 11:19 ` Mark Brown [this message]
2019-10-22 12:13 ` Bartosz Golaszewski
2019-10-22 15:03 ` Mark Brown
2019-10-22 15:42 ` Bartosz Golaszewski
2019-10-22 16:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022111908.GC5554@sirena.co.uk \
--to=broonie@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=bibby.hsieh@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).