Re: [PATCH v4] misc: eeprom: at24: support pm_runtime control

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]

On Tue, Oct 22, 2019 at 02:13:29PM +0200, Bartosz Golaszewski wrote:
> wt., 22 paź 2019 o 13:19 Mark Brown <broonie@kernel.org> napisał(a):

> > The ambiguously named regulator_get_optional().  This should *only* be
> > used for regulators that may be physically absent in the system, other
> > regulators should use normal regulator_get().  It is vanishingly
> > unlikely that all the supplies for a device will be optional.

> I take it that this driver should also use regular regulator_bulk_get() then?

It's really up to whoever maintains the driver but I'd recommend it
since it tends to be easier.

> I think the question about the return value of
> regulator_resolve_supply() still stands though: is it normal that it
> returns EPROBE_DEFER if it can't resolve the supply on systems without
> full_constraints? This will cause the driver to loop on probe
> deferral, right?

Yes, that's right.  The idea is that anything using regulators will call
that once it's finished setting up constraints, if you're not using
regulators at all you should compile out the API entirely.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]