* Re: [PATCH v2] i2c: i2c-stm32f7: remove warning when compiling with W=1
[not found] <1571145118-3522-1-git-send-email-alain.volmat@st.com>
@ 2019-10-22 13:41 ` Pierre Yves MORDRET
2019-10-24 18:44 ` Wolfram Sang
1 sibling, 0 replies; 2+ messages in thread
From: Pierre Yves MORDRET @ 2019-10-22 13:41 UTC (permalink / raw)
To: Alain Volmat, wsa, robh+dt
Cc: mark.rutland, mcoquelin.stm32, alexandre.torgue, linux-i2c,
devicetree, linux-stm32, linux-arm-kernel, linux-kernel,
fabrice.gasnier
Hello
Looks good
Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
Thx
Regards
On 10/15/19 3:11 PM, Alain Volmat wrote:
> Remove the following warning:
>
> drivers/i2c/busses/i2c-stm32f7.c:315:
> warning: cannot understand function prototype:
> 'struct stm32f7_i2c_spec i2c_specs[] =
>
> Replace a comment starting with /** by simply /* to avoid having
> it interpreted as a kernel-doc comment.
>
> Fixes: aeb068c57214 ("i2c: i2c-stm32f7: add driver")
> Signed-off-by: Alain Volmat <alain.volmat@st.com>
> ---
> Changes in v2: update commit description
> ---
> drivers/i2c/busses/i2c-stm32f7.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index d36cf08461f7..7aa4a47792a7 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -305,7 +305,7 @@ struct stm32f7_i2c_dev {
> struct regmap *regmap;
> };
>
> -/**
> +/*
> * All these values are coming from I2C Specification, Version 6.0, 4th of
> * April 2014.
> *
>
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2] i2c: i2c-stm32f7: remove warning when compiling with W=1
[not found] <1571145118-3522-1-git-send-email-alain.volmat@st.com>
2019-10-22 13:41 ` [PATCH v2] i2c: i2c-stm32f7: remove warning when compiling with W=1 Pierre Yves MORDRET
@ 2019-10-24 18:44 ` Wolfram Sang
1 sibling, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2019-10-24 18:44 UTC (permalink / raw)
To: Alain Volmat
Cc: robh+dt, mark.rutland, pierre-yves.mordret, mcoquelin.stm32,
alexandre.torgue, linux-i2c, devicetree, linux-stm32,
linux-arm-kernel, linux-kernel, fabrice.gasnier
[-- Attachment #1: Type: text/plain, Size: 498 bytes --]
On Tue, Oct 15, 2019 at 03:11:58PM +0200, Alain Volmat wrote:
> Remove the following warning:
>
> drivers/i2c/busses/i2c-stm32f7.c:315:
> warning: cannot understand function prototype:
> 'struct stm32f7_i2c_spec i2c_specs[] =
>
> Replace a comment starting with /** by simply /* to avoid having
> it interpreted as a kernel-doc comment.
>
> Fixes: aeb068c57214 ("i2c: i2c-stm32f7: add driver")
> Signed-off-by: Alain Volmat <alain.volmat@st.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread