From: Mark Brown <broonie@kernel.org>
To: Alvaro Gamez Machado <alvaro.gamez@hazent.com>
Cc: Michal Simek <michal.simek@xilinx.com>,
Shubhrajyoti Datta <shubhraj@xilinx.com>,
linux-spi@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] spi: set bits_per_word based on controller's bits_per_word_mask
Date: Fri, 25 Oct 2019 12:56:55 +0100 [thread overview]
Message-ID: <20191025115655.GA4568@sirena.org.uk> (raw)
In-Reply-To: <20191025063947.GA19665@salem.gmr.ssr.upm.es>
[-- Attachment #1: Type: text/plain, Size: 805 bytes --]
On Fri, Oct 25, 2019 at 08:39:48AM +0200, Alvaro Gamez Machado wrote:
> to claim the specific SPI slave. It may be spidev as in my use case, or it
> may really be any other driver. But its probe() function is never going to
> be called because the error is not raised inside the driver, but immediately
> after forcibly setting the default value to 8 in spi.c
Then you need to extend the validation the core is doing here to
skip this parameter when registering the device and only enforce
it after a driver is bound, we don't have a driver at the time we
initially register the device so we can't enforce this.
> I can't modify spidev because spidev doesn't even know this is happening.
You are, at some point, going to need to set your spidev to 32
bits per word (spidev does already support this).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-10-25 11:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 11:07 [PATCH] Allowing Xilinx's AXI Quad widths different than 8 bits on userspace Alvaro Gamez Machado
2019-10-24 11:07 ` [PATCH] spi: xilinx: add description of new property xlnx,num-transfer-bits Alvaro Gamez Machado
2019-10-24 11:57 ` Mark Brown
2019-10-24 11:57 ` Applied "spi: xilinx: add description of new property xlnx,num-transfer-bits" to the spi tree Mark Brown
2019-10-24 11:07 ` [PATCH] spi: xilinx: Add DT support for selecting transfer word width Alvaro Gamez Machado
2019-10-24 11:57 ` Applied "spi: xilinx: Add DT support for selecting transfer word width" to the spi tree Mark Brown
2019-10-24 11:07 ` [PATCH] spi: set bits_per_word based on controller's bits_per_word_mask Alvaro Gamez Machado
2019-10-24 11:13 ` Mark Brown
2019-10-24 12:54 ` Alvaro Gamez Machado
2019-10-24 13:11 ` Mark Brown
2019-10-24 13:18 ` Alvaro Gamez Machado
2019-10-24 13:41 ` Mark Brown
2019-10-24 14:07 ` Alvaro Gamez Machado
2019-10-24 17:40 ` Mark Brown
2019-10-25 6:39 ` Alvaro Gamez Machado
2019-10-25 11:56 ` Mark Brown [this message]
2019-10-28 9:43 ` Alvaro Gamez Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025115655.GA4568@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alvaro.gamez@hazent.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=shubhraj@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).