From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A48B8CA9EA0 for ; Fri, 25 Oct 2019 19:25:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 75ECF20679 for ; Fri, 25 Oct 2019 19:25:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572031521; bh=kFib9T2PK156kfVp/4TCM1yskmlWYfv8k/VQi57Yy/I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=hvuRYPeTT7sEcP2BhWOuzVQL5vOCHbtKD8ALAzkmLFObaltn/OGXhuSPKmJWp9K6Y 4v4tk8U2L9vlXxiGvajTWJWDTZxl5hO5VoU2XZss4qlZfaSgh6iHjZKkOOyoBtEu1S zds1IDzxg128LMSZEA9yCgzgFeW+30W8eAQjW4UE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725954AbfJYTZU (ORCPT ); Fri, 25 Oct 2019 15:25:20 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:39822 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725783AbfJYTZU (ORCPT ); Fri, 25 Oct 2019 15:25:20 -0400 Received: by mail-ot1-f68.google.com with SMTP id s22so2810498otr.6 for ; Fri, 25 Oct 2019 12:25:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Hvp+6pcbAuhWD78ad7Hbl9tESo5LnkRCFZND+kn0p/8=; b=XA9mMVf12G7ScqgtoPLh1RN95hTDCOUIjr+FNRHM42K0iy7GeKfyV5C0xTbE7mxAkY GTVb5UrfSVnmRitd4mYyarf/qaQ7BRG5r/BAzdDlHer6Q0/7IUSOqzdxIPl0eGy5HpeK mR8NmeapiX1xLEyAz6Bz9gTuwNfN8UlNped+3ipov9GPryM5Wbp+nD/ouwbIpitYEGaX x4YbwciGeIehOI0mcVhleeJXDNkP5beFtcwEzWxnoCHrS8pwqN0KRu79KpYa1GrWhN4U cfzjnOMdI22abSpSl2hVbDJJrNvxlep+j04wEKWzPJl3ic6idstcTOWuWMblvmPH4L+g SOKg== X-Gm-Message-State: APjAAAWpSwP3fpHW4ny7a8iFa4Fhz6/bGudbvi94q9TQPrpFoRgQy8eB 6FV/dA8yiqM/jHuRfBIXbSrA7LE= X-Google-Smtp-Source: APXvYqzMIR897eobjV14Fci7YCLpLBY9FpCOUumYwNM3rjseujxVArRe9sgOjUxouSEjyyC+cwGpAA== X-Received: by 2002:a05:6830:2055:: with SMTP id f21mr3963388otp.26.1572031519782; Fri, 25 Oct 2019 12:25:19 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id s3sm1010825otk.64.2019.10.25.12.25.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Oct 2019 12:25:19 -0700 (PDT) Date: Fri, 25 Oct 2019 14:25:18 -0500 From: Rob Herring To: Linus Walleij Cc: Thierry Reding , Sam Ravnborg , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/3 v4] drm/panel: Add DT bindings for Sony ACX424AKP Message-ID: <20191025192518.GA19549@bogus> References: <20191024114305.15581-1-linus.walleij@linaro.org> <20191024114305.15581-2-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191024114305.15581-2-linus.walleij@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Oct 24, 2019 at 01:43:04PM +0200, Linus Walleij wrote: > This adds device tree bindings for the Sony ACX424AKP panel. > Let's use YAML. Also broken. Run 'make dt_binding_check'. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Linus Walleij > --- > ChangeLog v3->v4: > - Adjust to adjusted DSI bindings. > ChangeLog v2->v3: > - Put the example inside a dsi-controller so we have a complete > example that verifies to the DSI panel generic binding. > ChangeLog v1->v2: > - Suggest a stand-alone YAML bindings file for DSI panels in > a separate patch, and use that to reference the > boolean "enforce-video-mode" attribute for DSI panels > --- > .../display/panel/sony,acx424akp.yaml | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/sony,acx424akp.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/sony,acx424akp.yaml b/Documentation/devicetree/bindings/display/panel/sony,acx424akp.yaml > new file mode 100644 > index 000000000000..a2f49b9a5958 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/sony,acx424akp.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/sony,acx424akp.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sony ACX424AKP 4" 480x864 AMOLED panel > + > +maintainers: > + - Linus Walleij > + > +allOf: > + - $ref: panel-common.yaml# > + - $ref: ../dsi-controller.yaml# This is wrong now because it applies to the controller node, not the panel node. IOW, DSI controllers need to include it. > + > +properties: > + compatible: > + const: sony,acx424akp > + reg: true > + port: true > + reset-gpios: true > + vddi-supply: > + description: regulator that supplies the vddi voltage > + enforce-video-mode: true > + > +required: > + - compatible > + - reg > + - port > + - reset-gpios > + - power-supply > + > +additionalProperties: false > + > +examples: > + - | > + dsi-controller@0 { unit-address without 'reg'... > + compatible = "foo"; > + #address-cells = <1>; > + #size-cells = <0>; > + panel@0 { > + compatible = "sony,acx424akp"; > + reg = <0>; > + vddi-supply = <&foo>; > + reset-gpios = <&foo_gpio 0 GPIO_ACTIVE_LOW>; > + }; > + }; > + > +... > \ No newline at end of file Should fix this... > -- > 2.21.0 >