From: Rob Herring <robh@kernel.org>
To: vincent.cheng.xh@renesas.com
Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, andrew@lunn.ch,
mark.rutland@arm.com, richardcochran@gmail.com
Subject: Re: [PATCH v3 1/2] dt-bindings: ptp: Add bindings doc for IDT ClockMatrix based PTP clock
Date: Fri, 25 Oct 2019 14:32:28 -0500 [thread overview]
Message-ID: <20191025193228.GA31398@bogus> (raw)
In-Reply-To: <1571687868-22834-1-git-send-email-vincent.cheng.xh@renesas.com>
On Mon, Oct 21, 2019 at 03:57:47PM -0400, vincent.cheng.xh@renesas.com wrote:
> From: Vincent Cheng <vincent.cheng.xh@renesas.com>
>
> Add device tree binding doc for the IDT ClockMatrix PTP clock.
>
> Co-developed-by: Richard Cochran <richardcochran@gmail.com>
> Signed-off-by: Richard Cochran <richardcochran@gmail.com>
> Signed-off-by: Vincent Cheng <vincent.cheng.xh@renesas.com>
> ---
>
> Changes since v2:
> - As suggested by Rob Herring:
> 1. Replace with DT schema
> 2. Remove '-ptp' from compatible string
> 3. Replace wildcard 'x' with the part numbers.
>
> Changes since v1:
> - No changes
> ---
> .../devicetree/bindings/ptp/ptp-idtcm.yaml | 63 ++++++++++++++++++++++
> 1 file changed, 63 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
>
> diff --git a/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml b/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
> new file mode 100644
> index 0000000..d3771e0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/ptp/ptp-idtcm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: IDT ClockMatrix (TM) PTP Clock Device Tree Bindings
> +
> +maintainers:
> + - Vincent Cheng <vincent.cheng.xh@renesas.com>
> +
> +properties:
> + compatible:
> + enum:
> + # For System Synchronizer
> + - idt,8a34000
> + - idt,8a34001
> + - idt,8a34002
> + - idt,8a34003
> + - idt,8a34004
> + - idt,8a34005
> + - idt,8a34006
> + - idt,8a34007
> + - idt,8a34008
> + - idt,8a34009
> + # For Port Synchronizer
> + - idt,8a34010
> + - idt,8a34011
> + - idt,8a34012
> + - idt,8a34013
> + - idt,8a34014
> + - idt,8a34015
> + - idt,8a34016
> + - idt,8a34017
> + - idt,8a34018
> + - idt,8a34019
> + # For Universal Frequency Translator (UFT)
> + - idt,8a34040
> + - idt,8a34041
> + - idt,8a34042
> + - idt,8a34043
> + - idt,8a34044
> + - idt,8a34045
> + - idt,8a34046
> + - idt,8a34047
> + - idt,8a34048
> + - idt,8a34049
> +
> + reg:
> + maxItems: 1
> + description:
> + I2C slave address of the device.
> +
> +required:
> + - compatible
> + - reg
> +
> +examples:
> + - |
> + phc@5b {
ptp@5b
Examples are built now and this fails:
Documentation/devicetree/bindings/ptp/ptp-idtcm.example.dts:19.15-28:
Warning (reg_format): /example-0/phc@5b:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
The problem is i2c devices need to be shown under an i2c bus node.
> + compatible = "idt,8a34000";
> + reg = <0x5b>;
> + };
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-10-25 19:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 19:57 [PATCH v3 1/2] dt-bindings: ptp: Add bindings doc for IDT ClockMatrix based PTP clock vincent.cheng.xh
2019-10-21 19:57 ` [PATCH v3 2/2] ptp: Add a ptp clock driver for IDT ClockMatrix vincent.cheng.xh
2019-10-25 19:32 ` Rob Herring [this message]
2019-10-29 15:00 ` [PATCH v3 1/2] dt-bindings: ptp: Add bindings doc for IDT ClockMatrix based PTP clock Vincent Cheng
2019-10-29 21:20 ` Rob Herring
2019-10-30 2:45 ` Vincent Cheng
2019-10-30 2:54 ` Vincent Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025193228.GA31398@bogus \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=vincent.cheng.xh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).