From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B3A7CA9EA0 for ; Fri, 25 Oct 2019 21:10:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3991321D7B for ; Fri, 25 Oct 2019 21:10:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572037804; bh=ma5lEWgZsb9cpEZxkWd+ZbEa30xCM1OojMepMAP0oAs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=WfGYezEF5EW0mplaD4u5L1zwLoxzW3Ainp72tOJqWzFXnqQo6n40NDQPXCgCPAlzi 6cQ1ME6u48wVhEgYZi663nyOobYmK+fJ/XJmF4a0Lag1TOCDHwSTNn7vd9PgGoHkzE F5lYix/HlmNu6SHCiavLjgtqSjd63DNSOYf5NfUo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725881AbfJYVKD (ORCPT ); Fri, 25 Oct 2019 17:10:03 -0400 Received: from mail-oi1-f196.google.com ([209.85.167.196]:34100 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725283AbfJYVKD (ORCPT ); Fri, 25 Oct 2019 17:10:03 -0400 Received: by mail-oi1-f196.google.com with SMTP id 83so2539115oii.1; Fri, 25 Oct 2019 14:10:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=d7m38wEP3cWWPKZavVh4QqPT2NxfQZN9J+ih9n10QDc=; b=Bgj0Hb5kkq7sw5xcNCEvNYyFvw18S7PrMLu3rewoGpPByjM2NazFD0XL6g424LJSML aIgI38S5G94S+DUdAA4Xgd0Pu1ftCB3ZmpHKOS1PdY5PWXUIuOCpRbyRmYA+0PGOcC+f Fhw4l7augwpNJd7XIxsR1e41XbHfZvbQVg508pwkNOx56CHriEO2i+jNFMzdRzkqMgL8 wtO05cSTFQkyBpqK3YZAu2RwaYgQhDA1GlgP9+C2B2KZ5mNDjq3Y9UABfgIMrGPXZLsC Q294uao7YxDKVW2RImTsAtutPUDAmCGNprI2Zqx9f+3XIY/K8/eAPjlsgSRKhya6ZG6c zfSg== X-Gm-Message-State: APjAAAXlQbZr9Zcoc4G55tHIgumMS4sgaQF6+m52pwTEwST32jIbAcEh f4jRn/IrE688MbKKxT8Te0l8W6g= X-Google-Smtp-Source: APXvYqwMdDzj7VpTwlpKBzbm1vx4GRa3h4b/Ol8HbT8QPQu0jiUwRDiRAWIWfNdFfGcGA55gSFCUgQ== X-Received: by 2002:aca:7595:: with SMTP id q143mr4820191oic.103.1572037802036; Fri, 25 Oct 2019 14:10:02 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id b12sm1095339otp.72.2019.10.25.14.10.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Oct 2019 14:10:01 -0700 (PDT) Date: Fri, 25 Oct 2019 16:10:00 -0500 From: Rob Herring To: Tomasz Figa Cc: Bartosz Golaszewski , Wolfram Sang , Bibby Hsieh , linux-i2c , Nicolas Boichat , srv_heupstream , Mark Rutland , linux-devicetree Subject: Re: [PATCH v2] dt-binding: eeprom: at24: add supply properties Message-ID: <20191025211000.GA8235@bogus> References: <20191018082557.3696-1-bibby.hsieh@mediatek.com> <20191018082557.3696-2-bibby.hsieh@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Oct 24, 2019 at 06:32:38PM +0900, Tomasz Figa wrote: > On Thu, Oct 24, 2019 at 5:40 PM Bartosz Golaszewski > wrote: > > > > czw., 24 paź 2019 o 09:02 Tomasz Figa napisał(a): > > > > > > On Thu, Oct 24, 2019 at 3:22 PM Bartosz Golaszewski > > > wrote: > > > > > > > > pt., 18 paź 2019 o 10:26 Bibby Hsieh napisał(a): > > > > > > > > > > In some platforms, they disable the power-supply of eeprom and i2c due > > > > > to power consumption reduction. > > > > > > > > > > This patch add two supply properties: vcc-supply, i2c-supply. > > > > > > > > > > Changes since v1: > > > > > - change supply name > > > > > - rebase to next > > > > > > > > > > Signed-off-by: Bibby Hsieh > > > > > --- > > > > > Documentation/devicetree/bindings/eeprom/at24.yaml | 8 ++++++++ > > > > > 1 file changed, 8 insertions(+) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml > > > > > index e8778560d966..578487a5d9b7 100644 > > > > > --- a/Documentation/devicetree/bindings/eeprom/at24.yaml > > > > > +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml > > > > > @@ -167,6 +167,14 @@ properties: > > > > > minimum: 1 > > > > > maximum: 8 > > > > > > > > > > + vcc-supply: > > > > > + description: > > > > > + phandle of the regulator that provides the supply voltage. > > > > > + > > > > > + i2c-sypply: > > > > > + description: > > > > > + phandle to the regulator that provides power to i2c. > > > > > + > > > > > > > > Something was bothering me about this patch so I came back to take a > > > > look. Can you explain what i2c actually stands for in this doc? I hope > > > > I'm misinterpreting something and it isn't that the driver disables > > > > the regulator powering the i2c bus controller? > > > > > > In our case it's the regulator that the I2C bus is pulled up to. > > > > > > > Then it has nothing to do with a generic EEPROM driver IMO. I think > > you need to add the control for this regulator to your i2c controller > > driver and create a power domain where the EEPROM would be lower in > > hierarchy. > > While I agree that the generic EEPROM driver may not be the best place > to do it, neither is a driver for a specific SoC i2c controller. The > hardware design is not specific to any particular i2c controller. > > Perhaps we need the generic i2c core to take into account an > i2c-supply? Wolfram, any thoughts on this? Sounds good to me. Maybe 'bus-supply' instead to indicate it's supposed to be for the bus and not other things. It should reside in the I2C controller's node (or mux ports) though. Rob