* Re: [PATCH 1/1] ARM: dts: imx6ul-14x14-evk.dtsi: configure USBOTG1 ID pinctrl
[not found] <1571214665-26402-1-git-send-email-peter.chen@nxp.com>
@ 2019-10-26 12:05 ` Shawn Guo
0 siblings, 0 replies; only message in thread
From: Shawn Guo @ 2019-10-26 12:05 UTC (permalink / raw)
To: Peter Chen; +Cc: linux-arm-kernel, kernel, devicetree, robh+dt, linux-imx
On Wed, Oct 16, 2019 at 04:31:05PM +0800, Peter Chen wrote:
> Without configuring this pinctrl, the ID value can't be got correctly,
> then, the dual-role switch can't work well.
>
> Reviewed-by: Jun Li <jun.li@nxp.com>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
Reviewed-by should generally go after Signed-off-by, as you create patch
first and then people review it.
I flipped the order and applied the patch.
Shawn
> ---
> arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> index c2a9dd57e56a..ed3d993c25f7 100644
> --- a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> +++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> @@ -266,6 +266,8 @@
>
> &usbotg1 {
> dr_mode = "otg";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usb_otg1>;
> status = "okay";
> };
>
> @@ -499,6 +501,12 @@
> >;
> };
>
> + pinctrl_usb_otg1: usbotg1grp {
> + fsl,pins = <
> + MX6UL_PAD_GPIO1_IO00__ANATOP_OTG1_ID 0x17059
> + >;
> + };
> +
> pinctrl_usdhc1: usdhc1grp {
> fsl,pins = <
> MX6UL_PAD_SD1_CMD__USDHC1_CMD 0x17059
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] only message in thread