From: David Miller <davem@davemloft.net>
To: christophe.roullier@st.com
Cc: robh@kernel.org, joabreu@synopsys.com, mark.rutland@arm.com,
mcoquelin.stm32@gmail.com, alexandre.torgue@st.com,
peppe.cavallaro@st.com, linux-stm32@st-md-mailman.stormreply.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
andrew@lunn.ch
Subject: Re: [PATCH 0/5] net: ethernet: stmmac: some fixes and optimizations
Date: Tue, 29 Oct 2019 18:09:06 -0700 (PDT) [thread overview]
Message-ID: <20191029.180906.71140804338490537.davem@davemloft.net> (raw)
In-Reply-To: <20191029101441.17290-1-christophe.roullier@st.com>
From: Christophe Roullier <christophe.roullier@st.com>
Date: Tue, 29 Oct 2019 11:14:36 +0100
> Some improvements (manage syscfg as optional clock, update slew rate of
> ETH_MDIO pin, Enable gating of the MAC TX clock during TX low-power mode)
> Fix warning build message when W=1
Please fix up several issues with this submission:
1) Bug fixes should target the 'net' GIT tree. Anything else, and this
means cleanups, new features, and optimizations, should all target
the 'net-next' GIT tree.
2) Your subject lines are too much, for example:
[net: ethernet: stmmac: some fixes and optimizations 1/5] net: ethernet: stmmac: Add support for syscfg clock
The "net: ethernet: stmmac: some fixes and optimizations" part
should be completely removed. 'net' should be separate to indicate
the target GIT tree (or 'net-next' as could be the case) and then
we're left with, for example:
[PATCH net-next 1/5] net: ethernet: stmmac: Add support for syscfg clock
3) There should be a seprate series with the bug fixes targetting 'net',
then you should wait for those fixes to propagate into 'net-next', at which
time you can submit a second patch series targetting 'net-next' with all
the cleanups, feature additions, and optimizations.
Thank you.
prev parent reply other threads:[~2019-10-30 1:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 10:14 [PATCH 0/5] net: ethernet: stmmac: some fixes and optimizations Christophe Roullier
2019-10-29 10:14 ` [net: ethernet: stmmac: some fixes and optimizations 1/5] net: ethernet: stmmac: Add support for syscfg clock Christophe Roullier
2019-10-29 10:14 ` [net: ethernet: stmmac: some fixes and optimizations 2/5] net: ethernet: stmmac: fix warning when w=1 option is used during build Christophe Roullier
2019-10-29 10:14 ` [net: ethernet: stmmac: some fixes and optimizations 3/5] ARM: dts: stm32: remove syscfg clock on stm32mp157c ethernet Christophe Roullier
2019-10-29 10:14 ` [net: ethernet: stmmac: some fixes and optimizations 4/5] ARM: dts: stm32: adjust slew rate for Ethernet Christophe Roullier
2019-10-29 10:14 ` [net: ethernet: stmmac: some fixes and optimizations 5/5] ARM: dts: stm32: Enable gating of the MAC TX clock during TX low-power mode on stm32mp157c Christophe Roullier
2019-10-30 1:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029.180906.71140804338490537.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=christophe.roullier@st.com \
--cc=devicetree@vger.kernel.org \
--cc=joabreu@synopsys.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).