From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Jay Cliburn <jcliburn@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Chris Snook <chris.snook@gmail.com>,
linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
"David S. Miller" <davem@davemloft.net>,
Paul Burton <paul.burton@mips.com>,
Rob Herring <robh+dt@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
James Hogan <jhogan@kernel.org>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, linux-mips@vger.kernel.org,
Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [PATCH v4 5/5] net: dsa: add support for Atheros AR9331 build-in switch
Date: Tue, 29 Oct 2019 13:38:54 +0100 [thread overview]
Message-ID: <20191029123854.GN15259@lunn.ch> (raw)
In-Reply-To: <20191029071404.pl34q4rmadusc2u5@pengutronix.de>
Hi Oleksij
> > > +static void ar9331_sw_port_disable(struct dsa_switch *ds, int port)
> > > +{
> > > + struct ar9331_sw_priv *priv = (struct ar9331_sw_priv *)ds->priv;
> > > + struct regmap *regmap = priv->regmap;
> > > + int ret;
> > > +
> > > + ret = regmap_write(regmap, AR9331_SW_REG_PORT_STATUS(port), 0);
> > > + if (ret)
> > > + dev_err_ratelimited(priv->dev, "%s: %i\n", __func__, ret);
> > > +}
> >
> > I've asked this before, but i don't remember the answer. Why are
> > port_enable and port_disable the same?
>
> I have only MAC TX/RX enable bit. This bit is set by phylink_mac_link_up and
> removed by phylink_mac_link_down.
> The port enable I use only to set predictable state of the port
> register: all bits cleared. May be i should just drop port enable
> function? What do you think?
At minimum, it needs a comment about why enable and disable are the
same. If i keep asking, others will as well.
If there is nothing useful to do, then drop it.
Andrew
prev parent reply other threads:[~2019-10-29 12:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 5:57 [PATCH v4 0/5] add dsa switch support for ar9331 Oleksij Rempel
2019-10-22 5:57 ` [PATCH v4 1/5] net: ag71xx: port to phylink Oleksij Rempel
2019-10-22 5:57 ` [PATCH v4 2/5] dt-bindings: net: dsa: qca,ar9331 switch documentation Oleksij Rempel
2019-10-23 0:35 ` Andrew Lunn
2019-10-29 7:34 ` Oleksij Rempel
2019-12-15 14:57 ` Oleksij Rempel
2019-12-17 8:44 ` Andrew Lunn
2019-10-22 5:57 ` [PATCH v4 3/5] MIPS: ath79: ar9331: add ar9331-switch node Oleksij Rempel
2019-10-22 5:57 ` [PATCH v4 4/5] net: dsa: add support for Atheros AR9331 TAG format Oleksij Rempel
2019-10-22 6:10 ` Randy Dunlap
2019-10-23 0:37 ` Andrew Lunn
2019-10-22 5:57 ` [PATCH v4 5/5] net: dsa: add support for Atheros AR9331 build-in switch Oleksij Rempel
2019-10-22 6:10 ` Randy Dunlap
2019-10-23 0:58 ` Andrew Lunn
2019-10-29 7:14 ` Oleksij Rempel
2019-10-29 12:38 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029123854.GN15259@lunn.ch \
--to=andrew@lunn.ch \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jcliburn@gmail.com \
--cc=jhogan@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).