From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F400CA9EAE for ; Tue, 29 Oct 2019 13:22:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D635C20578 for ; Tue, 29 Oct 2019 13:22:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572355320; bh=9DPgkLEkBOHW6zeW/2bHQtGIc5Bfkrw+8fTROnA4jG0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Q3NNk6olTXJOMfVFpx1Pi11m93mFWzQ8b0dR++//MBeNytkb6vCLglDs9O8BS/RKU bfDKOaXBPji2u8yZYxsvhrTG5bGc0fRTr+i12yKZqWTcqEnOXOGE7urWepmYJbsoXN K0gc0niGCiJArNrsJr+SwiYP44t70nWzZnPFcPfg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388119AbfJ2NWA (ORCPT ); Tue, 29 Oct 2019 09:22:00 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:40030 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732534AbfJ2NWA (ORCPT ); Tue, 29 Oct 2019 09:22:00 -0400 Received: by mail-ot1-f65.google.com with SMTP id d8so9701800otc.7; Tue, 29 Oct 2019 06:21:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Qm6YKg+tpScIEXrceozPkWxGdk+JQIAQFB6SK8BhUfo=; b=ckxDPvWBqqgAkpZ4i+mMDypA9t065qiYQhjNb02MnEWuzyQiZfa4SK8gFti2XTwIqJ HbIlI0NCwtUGCenwN4Xr/vtr4zPMqtSRJLtbl+7zN6Du+5JKyDqJUUjxG08ql06zd/v9 CIpjqNQ+wsRBnwwoOyhPnqTSqrxJylHE6wvRLSM+xe0Ae6QLmJIMj8TMt0EQ9hxJFTZw NJ96MGCJoADw7aF/j68NioKnTATvh1jTtAaDAQatALYhuTo9ybK5owxX3xeZF8ZjTMkT NSF88R3fNeiPLOCTEI3bCI0QK5y0kZJpt3hiPtkb62OQAtwenMPzdRl8u+jXzN5tHdz0 dpjg== X-Gm-Message-State: APjAAAXxt3hpoKcMr6zrgf6m0cGlF0oSR0MR2wJaxiRU53REeW0Ni0On zutEhgaOTZ7r8qSGST0T1w== X-Google-Smtp-Source: APXvYqwERtm1vBKo153rKw19EJkDo3JTPsearfO7CzEj+WTKjFxIcVlacg9tF6oYAAIvPjtZLNbbkQ== X-Received: by 2002:a9d:7f8d:: with SMTP id t13mr17183455otp.27.1572355318795; Tue, 29 Oct 2019 06:21:58 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id l7sm1668737otf.39.2019.10.29.06.21.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2019 06:21:58 -0700 (PDT) Date: Tue, 29 Oct 2019 08:21:57 -0500 From: Rob Herring To: Benoit Parrot Cc: Hans Verkuil , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch 02/19] dt-bindings: media: cal: update binding example Message-ID: <20191029132157.GA27757@bogus> References: <20191018153437.20614-1-bparrot@ti.com> <20191018153437.20614-3-bparrot@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191018153437.20614-3-bparrot@ti.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Oct 18, 2019 at 10:34:20AM -0500, Benoit Parrot wrote: > Update binding example to show proper endpoint properties and linkage. > > Signed-off-by: Benoit Parrot > --- > .../devicetree/bindings/media/ti-cal.txt | 32 ++++++++++--------- > 1 file changed, 17 insertions(+), 15 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/ti-cal.txt b/Documentation/devicetree/bindings/media/ti-cal.txt > index 782f801b12a9..6b56fddcfc4a 100644 > --- a/Documentation/devicetree/bindings/media/ti-cal.txt > +++ b/Documentation/devicetree/bindings/media/ti-cal.txt > @@ -27,7 +27,6 @@ Documentation/devicetree/bindings/media/video-interfaces.txt. > Example: > cal: cal@4845b000 { > compatible = "ti,dra72-cal"; > - ti,hwmods = "cal"; > reg = <0x4845B000 0x400>, > <0x4845B800 0x40>, > <0x4845B900 0x40>; > @@ -45,9 +44,10 @@ Example: > > csi2_0: port@0 { > reg = <0>; > - endpoint { > - slave-mode; > - remote-endpoint = <&ar0330_1>; > + csi2_phy0: endpoint@0 { Unit address without 'reg' is not correct. > + remote-endpoint = <&csi2_cam0>; > + clock-lanes = <0>; > + data-lanes = <1 2>; > }; > }; > csi2_1: port@1 { > @@ -57,19 +57,21 @@ Example: > }; > > i2c5: i2c@4807c000 { > - ar0330@10 { > - compatible = "ti,ar0330"; > - reg = <0x10>; > + status = "okay"; Don't show status in examples. > + clock-frequency = <400000>; > > - port { > - #address-cells = <1>; > - #size-cells = <0>; > + ov5640@3c { camera-sensor@3c > + compatible = "ovti,ov5640"; > + reg = <0x3c>; > + > + clocks = <&clk_ov5640_fixed>; > + clock-names = "xclk"; > > - ar0330_1: endpoint { > - reg = <0>; > - clock-lanes = <1>; > - data-lanes = <0 2 3 4>; > - remote-endpoint = <&csi2_0>; > + port { > + csi2_cam0: endpoint { > + remote-endpoint = <&csi2_phy0>; > + clock-lanes = <0>; > + data-lanes = <1 2>; > }; > }; > }; > -- > 2.17.1 >