From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA9CDCA9EC5 for ; Wed, 30 Oct 2019 15:55:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB786217F9 for ; Wed, 30 Oct 2019 15:55:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572450936; bh=yhwW3OSD4OMkVwZMox1fzcqQYREfFWwiXMt1NWhoEQA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Yb2NFWsIhTbpJv84JzxoLA7OU/1d+8ZSkGLMeWCWCj16CbfLeFNIwSvy473g5aDYX rtSbrqdxSI1ZMnzOqiyY1vopGUgbxDB/up32hngVBvnmg44k2Tf12XsMAnr6V2W/x0 90oVAEBgigEsmAOGNjQIAcqD8q/ioq16J8Ho3Wuc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728600AbfJ3Pz3 (ORCPT ); Wed, 30 Oct 2019 11:55:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:57070 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728594AbfJ3Pz3 (ORCPT ); Wed, 30 Oct 2019 11:55:29 -0400 Received: from sasha-vm.mshome.net (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D5C5F217F9; Wed, 30 Oct 2019 15:55:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572450928; bh=yhwW3OSD4OMkVwZMox1fzcqQYREfFWwiXMt1NWhoEQA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mh/V0NRfb6Nh5dDPdwJJsBnHIlSToFjD+//sjmsyvZ0drTdxul8OQijswPf2w+6D6 0tclY2eHR2i8l0Y/P5yZg9nk9aHsgGdKCA5g2ngj6/6+AokZ/aULzzRDHCvVOS2Sbr n7TJoDDZvIbDk0+JtAEP3tDNkCbtHw8nh8zuE1wk= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Navid Emamdoost , Frank Rowand , Rob Herring , Sasha Levin , devicetree@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 29/38] of: unittest: fix memory leak in unittest_data_add Date: Wed, 30 Oct 2019 11:53:57 -0400 Message-Id: <20191030155406.10109-29-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191030155406.10109-1-sashal@kernel.org> References: <20191030155406.10109-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org From: Navid Emamdoost [ Upstream commit e13de8fe0d6a51341671bbe384826d527afe8d44 ] In unittest_data_add, a copy buffer is created via kmemdup. This buffer is leaked if of_fdt_unflatten_tree fails. The release for the unittest_data buffer is added. Fixes: b951f9dc7f25 ("Enabling OF selftest to run without machine's devicetree") Signed-off-by: Navid Emamdoost Reviewed-by: Frank Rowand Signed-off-by: Rob Herring Signed-off-by: Sasha Levin --- drivers/of/unittest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 7f42314da6ae3..bac4b4bbc33de 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -1159,6 +1159,7 @@ static int __init unittest_data_add(void) of_fdt_unflatten_tree(unittest_data, NULL, &unittest_data_node); if (!unittest_data_node) { pr_warn("%s: No tree to attach; not running tests\n", __func__); + kfree(unittest_data); return -ENODATA; } -- 2.20.1