devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: "Kamel Bouhara" <kamel.bouhara@bootlin.com>,
	"Nicolas Ferre" <nicolas.ferre@microchip.com>,
	"Ludovic Desroches" <ludovic.desroches@microchip.com>,
	linux-arm-kernel@lists.infradead.org,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Kévin RAYMOND" <k.raymond@overkiz.com>,
	"Mickael GARDET" <m.gardet@overkiz.com>
Subject: Re: [PATCH 2/2] ARM: dts: at91: add a common kizboxmini dtsi file
Date: Thu, 31 Oct 2019 12:08:11 +0100	[thread overview]
Message-ID: <20191031110811.GC2967@piout.net> (raw)
In-Reply-To: <20191029123426.GB8412@bogus>

On 29/10/2019 07:34:26-0500, Rob Herring wrote:
> On Fri, Oct 18, 2019 at 04:03:04PM +0200, Kamel Bouhara wrote:
> > Split the Kizbox Mini boards into two board configuration, the
> > Kizboxmini Mother board and the Kizboxmini RailDIN board.
> > 
> > Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com>
> > Signed-off-by: Kévin RAYMOND <k.raymond@overkiz.com>
> > Signed-off-by: Mickael GARDET <m.gardet@overkiz.com>
> > ---
> >  arch/arm/boot/dts/Makefile                    |   2 +
> >  arch/arm/boot/dts/at91-kizboxmini-mb.dts      |  38 ++++
> >  arch/arm/boot/dts/at91-kizboxmini-rd.dts      |  54 ++++++
> >  arch/arm/boot/dts/at91-kizboxmini_common.dtsi | 166 ++++++++++++++++++
> >  4 files changed, 260 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/at91-kizboxmini-mb.dts
> >  create mode 100644 arch/arm/boot/dts/at91-kizboxmini-rd.dts
> >  create mode 100644 arch/arm/boot/dts/at91-kizboxmini_common.dtsi
> > 
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index c976b72a4c94..6b3a65f3f6f8 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -38,6 +38,8 @@ dtb-$(CONFIG_SOC_AT91SAM9) += \
> >  	at91-ariettag25.dtb \
> >  	at91-cosino_mega2560.dtb \
> >  	at91-kizboxmini.dtb \
> > +	at91-kizboxmini-mb.dtb \
> > +	at91-kizboxmini-rd.dtb \
> >  	at91-wb45n.dtb \
> >  	at91sam9g15ek.dtb \
> >  	at91sam9g25ek.dtb \
> > diff --git a/arch/arm/boot/dts/at91-kizboxmini-mb.dts b/arch/arm/boot/dts/at91-kizboxmini-mb.dts
> > new file mode 100644
> > index 000000000000..52921f547dd6
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/at91-kizboxmini-mb.dts
> > @@ -0,0 +1,38 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (C) 2015-2018 Overkiz SAS
> > + *   Author: Mickael Gardet <m.gardet@overkiz.com>
> > + *           Kévin Raymond <k.raymond@overkiz.com>
> > + */
> > +/dts-v1/;
> > +#include "at91-kizboxmini_common.dtsi"
> > +
> > +/ {
> > +	model = "Overkiz Kizbox Mini Mother Board";
> > +	compatible = "overkiz,kizboxmini-mb", "atmel,at91sam9g25",
> > +		     "atmel,at91sam9x5", "atmel,at91sam9";
> > +
> > +	clocks {
> > +		slow_xtal {
> 
> Don't use '_' in node names.
> 

We are stuck with that one until we change the dtsi.


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2019-10-31 11:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-18 14:03 [PATCH RESEND 0/2] Add Kizboxmini boards support Kamel Bouhara
2019-10-18 14:03 ` [PATCH 1/2] dt-bindings: arm: at91: Document Kizboxmini boards binding Kamel Bouhara
2019-10-29 12:29   ` Rob Herring
2019-11-06  8:36     ` Kamel Bouhara
2019-10-18 14:03 ` [PATCH 2/2] ARM: dts: at91: add a common kizboxmini dtsi file Kamel Bouhara
2019-10-18 14:23   ` Alexandre Belloni
2019-10-29 12:34   ` Rob Herring
2019-10-31 11:08     ` Alexandre Belloni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191031110811.GC2967@piout.net \
    --to=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=k.raymond@overkiz.com \
    --cc=kamel.bouhara@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=m.gardet@overkiz.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=robh@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).