* [PATCH] dt-bindings: sound: adau7118: Fix example warning
@ 2019-10-31 13:47 Maxime Ripard
2019-11-04 10:24 ` [alsa-devel] " Lars-Peter Clausen
0 siblings, 1 reply; 2+ messages in thread
From: Maxime Ripard @ 2019-10-31 13:47 UTC (permalink / raw)
To: Mark Rutland, Rob Herring, Frank Rowand, broonie, lgirdwood
Cc: alsa-devel, devicetree, Maxime Ripard, Nuno Sá
The ADAU7118 has an example where the codec has an i2c address of 14, and
the unit address set to 14 as well.
However, while the address is expressed in decimal, the unit-address is
supposed to be in hexadecimal, which ends up with two different addresses
that trigger a DTC warning. Fix this by setting the unit address to (0x)e.
Cc: Nuno Sá <nuno.sa@analog.com>
Fixes: 969d49b2cdc8 ("dt-bindings: asoc: Add ADAU7118 documentation")
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
Documentation/devicetree/bindings/sound/adi,adau7118.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
index c3f10afbdd6f..65f6844a0c6d 100644
--- a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
+++ b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
@@ -65,7 +65,7 @@ examples:
/* example with i2c support */
#address-cells = <1>;
#size-cells = <0>;
- adau7118_codec: audio-codec@14 {
+ adau7118_codec: audio-codec@e {
compatible = "adi,adau7118";
reg = <14>;
#sound-dai-cells = <0>;
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [alsa-devel] [PATCH] dt-bindings: sound: adau7118: Fix example warning
2019-10-31 13:47 [PATCH] dt-bindings: sound: adau7118: Fix example warning Maxime Ripard
@ 2019-11-04 10:24 ` Lars-Peter Clausen
0 siblings, 0 replies; 2+ messages in thread
From: Lars-Peter Clausen @ 2019-11-04 10:24 UTC (permalink / raw)
To: Maxime Ripard, Mark Rutland, Rob Herring, Frank Rowand, broonie,
lgirdwood
Cc: devicetree, alsa-devel, Nuno Sá
On 10/31/19 2:47 PM, Maxime Ripard wrote:
> The ADAU7118 has an example where the codec has an i2c address of 14, and
> the unit address set to 14 as well>
> However, while the address is expressed in decimal, the unit-address is
> supposed to be in hexadecimal, which ends up with two different addresses
> that trigger a DTC warning. Fix this by setting the unit address to (0x)e.
>
The mistake is in the I2C address, should be 0x14.
> Cc: Nuno Sá <nuno.sa@analog.com>
> Fixes: 969d49b2cdc8 ("dt-bindings: asoc: Add ADAU7118 documentation")
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
> Documentation/devicetree/bindings/sound/adi,adau7118.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
> index c3f10afbdd6f..65f6844a0c6d 100644
> --- a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
> +++ b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
> @@ -65,7 +65,7 @@ examples:
> /* example with i2c support */
> #address-cells = <1>;
> #size-cells = <0>;
> - adau7118_codec: audio-codec@14 {
> + adau7118_codec: audio-codec@e {
> compatible = "adi,adau7118";
> reg = <14>;
> #sound-dai-cells = <0>;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-04 10:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-31 13:47 [PATCH] dt-bindings: sound: adau7118: Fix example warning Maxime Ripard
2019-11-04 10:24 ` [alsa-devel] " Lars-Peter Clausen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).