From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A1D3CA9ECF for ; Mon, 4 Nov 2019 09:23:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1551F22468 for ; Mon, 4 Nov 2019 09:23:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572859380; bh=fDwWHQXokQ6+yeSBLlhubET0rNESSzXyJpE1F6jX8DI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=GU0YTZ+2WUYZDFUpYvAwDetyuw1dh+lS15xO1F9vCG/SQ5ksy7Vf6vI19mc03MWgI FqXJGnU0wmQ/1L6QA4a7kOVtd+DJXsoDgdf7k+dmASvSocO2n5798ebtVPcO1/kcxT 5vUmQK9tr2UDVaPYb39Ao59IKjd54jbuuHspadtA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728344AbfKDJW7 (ORCPT ); Mon, 4 Nov 2019 04:22:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:37720 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728332AbfKDJW7 (ORCPT ); Mon, 4 Nov 2019 04:22:59 -0500 Received: from localhost (unknown [106.201.55.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2E30420842; Mon, 4 Nov 2019 09:22:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572859379; bh=fDwWHQXokQ6+yeSBLlhubET0rNESSzXyJpE1F6jX8DI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sQoqsNrRtMsmT8OLj51A7PYWqpJmqtK9RUp22OzFl6h1iWU9cMvCVKSiefUAzTtgB P1vOVAsdRkqQAjtVOpMnz1tHXJ3SvVSP7yE4UlTHqMYpHtXwPp4QG6pW02UoPZIdyp 6/TRC/U+/wQbIJMtPixaB8Lx2EOAyLoRW87UVbK8= Date: Mon, 4 Nov 2019 14:52:52 +0530 From: Vinod Koul To: Bjorn Andersson Cc: Kishon Vijay Abraham I , Rob Herring , Mark Rutland , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 5/5] phy: qcom: qmp: Add SDM845 QHP PCIe PHY Message-ID: <20191104092252.GS2695@vkoul-mobl.Dlink> References: <20191102001628.4090861-1-bjorn.andersson@linaro.org> <20191102001628.4090861-6-bjorn.andersson@linaro.org> <20191103082147.GO2695@vkoul-mobl.Dlink> <20191104044703.GQ1929@tuxbook-pro> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191104044703.GQ1929@tuxbook-pro> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03-11-19, 20:47, Bjorn Andersson wrote: > On Sun 03 Nov 01:21 PDT 2019, Vinod Koul wrote: > > On 01-11-19, 17:16, Bjorn Andersson wrote: > [..] > > > +/* PCIE GEN3 COM registers */ > > > +#define PCIE_GEN3_QHP_COM_SYSCLK_EN_SEL 0xdc > > > > No QPHY_ tag with these? > > These are the actual register names from the hardware specification, do > you foresee any issues with naming them like this? It would make them consistent, rest of the registers do have that. > > > > +#define PCIE_GEN3_QHP_COM_SSC_EN_CENTER 0x14 > > > > Can we sort these please! > > > > Yes, that sounds reasonable. I'll respin with these sorted by address. Great, thanks -- ~Vinod