From: Stephen Boyd <sboyd@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Tero Kristo <t-kristo@ti.com>, Tony Lindgren <tony@atomide.com>
Cc: devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-omap@vger.kernel.org, Keerthy <j-keerthy@ti.com>
Subject: Re: [PATCH] clk: ti: clkctrl: Fix failed to enable error with double udelay timeout
Date: Mon, 04 Nov 2019 09:57:23 -0800 [thread overview]
Message-ID: <20191104175724.95B78214E0@mail.kernel.org> (raw)
In-Reply-To: <20190930154001.46581-1-tony@atomide.com>
Quoting Tony Lindgren (2019-09-30 08:40:01)
> Commit 3d8598fb9c5a ("clk: ti: clkctrl: use fallback udelay approach if
> timekeeping is suspended") added handling for cases when timekeeping is
> suspended. But looks like we can still get occasional "failed to enable"
> errors on the PM runtime resume path with udelay() returning faster than
> expected.
>
> With ti-sysc interconnect target module driver this leads into device
> failure with PM runtime failing with "failed to enable" clkctrl error.
>
> Let's fix the issue with a delay of two times the desired delay as in
> often done for udelay() to account for the inaccuracy.
>
> Fixes: 3d8598fb9c5a ("clk: ti: clkctrl: use fallback udelay approach if timekeeping is suspended")
> Cc: Keerthy <j-keerthy@ti.com>
> Cc: Tero Kristo <t-kristo@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
Applied to clk-fixes
prev parent reply other threads:[~2019-11-04 17:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190930154001.46581-1-tony@atomide.com>
[not found] ` <93a6448d-cece-a903-5c7e-ade793d62063@ti.com>
[not found] ` <20191010140519.GV5610@atomide.com>
2019-10-24 8:00 ` [PATCH] clk: ti: clkctrl: Fix failed to enable error with double udelay timeout Tero Kristo
2019-11-04 17:57 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104175724.95B78214E0@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).