From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ED78C010A3 for ; Tue, 5 Nov 2019 10:43:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 58C4320869 for ; Tue, 5 Nov 2019 10:43:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572950627; bh=PSQEEnZ0laTDZiGYUA/GbDjYoEzSM/8mbSzwF/BKSyw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=mNopGtN+72lKAsP8lfGOUNkO8tGV5UUFYqCRonp45Hn3Cni2hisV03h5MPVKPeIoz F+9qbz3CCy4dR3VSF3fV+gXPfgDTT35RKpandBTfX4mDSPy5OwMt80Dikv9bRpkTiU +OCMQLU6DrFqD5QJCBpQpIemFpFr95lMnv0+kxAw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388645AbfKEKnq (ORCPT ); Tue, 5 Nov 2019 05:43:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:55626 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388203AbfKEKnq (ORCPT ); Tue, 5 Nov 2019 05:43:46 -0500 Received: from localhost (lfbn-1-10718-76.w90-89.abo.wanadoo.fr [90.89.68.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6C7CB206BA; Tue, 5 Nov 2019 10:43:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572950624; bh=PSQEEnZ0laTDZiGYUA/GbDjYoEzSM/8mbSzwF/BKSyw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PJkpTS1MgUmm8+9CqOP+yjuzMwiYk0PVtRfX5d7YaOUBySwDZ9cM6PgMR3Cggx8Uq s/m93j31qYZSdoH7bqpcy6kTd9X/IXdOTOrhEHCjBFRVcbjOe/BQN0TsNli8mNcnw0 Dc9MpcOaQ87R/WxVfPrh8mXBTe9k5st6ALK08InI= Date: Tue, 5 Nov 2019 11:43:42 +0100 From: Maxime Ripard To: Torsten Duwe Cc: Chen-Yu Tsai , Rob Herring , Mark Rutland , Thierry Reding , David Airlie , Daniel Vetter , Andrzej Hajda , Laurent Pinchart , Icenowy Zheng , Sean Paul , Vasily Khoruzhick , Harald Geyer , Greg Kroah-Hartman , Thomas Gleixner , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 6/7] dt-bindings: Add ANX6345 DP/eDP transmitter binding Message-ID: <20191105104342.GD3876@gilmour.lan> References: <20191104110400.F319F68BE1@verein.lst.de> <20191104110613.C3BA468C4E@verein.lst.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="s9fJI615cBHmzTOP" Content-Disposition: inline In-Reply-To: <20191104110613.C3BA468C4E@verein.lst.de> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --s9fJI615cBHmzTOP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 29, 2019 at 01:16:57PM +0100, Torsten Duwe wrote: > The anx6345 is an ultra-low power DisplayPort/eDP transmitter designed > for portable devices. > > Add a binding document for it. > > Signed-off-by: Icenowy Zheng > Signed-off-by: Vasily Khoruzhick > Reviewed-by: Rob Herring > Signed-off-by: Torsten Duwe > Reviewed-by: Laurent Pinchart Applied, thanks (still, there's one comment below that can be addressed in a subsequent patch). > --- > .../bindings/display/bridge/anx6345.yaml | 102 ++++++++++++++++++++++ > 1 file changed, 102 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/anx6345.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/anx6345.yaml b/Documentation/devicetree/bindings/display/bridge/anx6345.yaml > new file mode 100644 > index 000000000000..094e8e8a5faa > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/anx6345.yaml > @@ -0,0 +1,102 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/anx6345.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analogix ANX6345 eDP Transmitter Device Tree Bindings > + > +maintainers: > + - Torsten Duwe > + > +description: | > + The ANX6345 is an ultra-low power Full-HD eDP transmitter designed for > + portable devices. > + > +properties: > + compatible: > + const: analogix,anx6345 > + > + reg: > + maxItems: 1 > + description: base I2C address of the device > + > + reset-gpios: > + maxItems: 1 > + description: GPIO connected to active low reset > + > + dvdd12-supply: > + maxItems: 1 > + description: Regulator for 1.2V digital core power. > + > + dvdd25-supply: > + maxItems: 1 > + description: Regulator for 2.5V digital core power. > + > + ports: > + type: object > + > + properties: > + port@0: > + type: object > + description: | > + Video port for LVTTL input > + > + port@1: > + type: object > + description: | > + Video port for eDP output (panel or connector). > + May be omitted if EDID works reliably. > + > + required: > + - port@0 You should have something like: ports: type: object additionalProperties: false as well... > + > +required: > + - compatible > + - reg > + - reset-gpios > + - dvdd12-supply > + - dvdd25-supply > + - ports > + > +additionalProperties: false This prevents additional properties only on the top-level node, not its children. Maxime --s9fJI615cBHmzTOP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXcFSXgAKCRDj7w1vZxhR xWDyAQC/sTEqgIPTcOOELk+/c6UietuE9I6ZSjYK0vSixbY85QEA3YGf1cUesRov KKmSnjZjgmC0YlV/4YVCj4ZQF1Dkkw0= =1muA -----END PGP SIGNATURE----- --s9fJI615cBHmzTOP--