* [PATCH v2] dt-bindings: sound: adau7118: Fix example warning
@ 2019-11-05 10:56 Maxime Ripard
2019-11-05 15:44 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Maxime Ripard @ 2019-11-05 10:56 UTC (permalink / raw)
To: lgirdwood, broonie
Cc: Mark Rutland, Rob Herring, Frank Rowand, alsa-devel, devicetree,
Maxime Ripard, Nuno Sá, Lars-Peter Clausen
The ADAU7118 has an example where the codec has an i2c address of 14, and
the unit address set to 14 as well.
However, while the address is expressed in decimal, the unit-address is
supposed to be in hexadecimal, which ends up with two different addresses
that trigger a DTC warning. Fix this by setting the address to 0x14.
Cc: Nuno Sá <nuno.sa@analog.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Fixes: 969d49b2cdc8 ("dt-bindings: asoc: Add ADAU7118 documentation")
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
Changes from v1:
- Fix the address instead of the unit-address.
---
Documentation/devicetree/bindings/sound/adi,adau7118.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
index c3f10afbdd6f..75e0cbe6be70 100644
--- a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
+++ b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
@@ -67,7 +67,7 @@ examples:
#size-cells = <0>;
adau7118_codec: audio-codec@14 {
compatible = "adi,adau7118";
- reg = <14>;
+ reg = <0x14>;
#sound-dai-cells = <0>;
iovdd-supply = <&supply>;
dvdd-supply = <&supply>;
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] dt-bindings: sound: adau7118: Fix example warning
2019-11-05 10:56 [PATCH v2] dt-bindings: sound: adau7118: Fix example warning Maxime Ripard
@ 2019-11-05 15:44 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2019-11-05 15:44 UTC (permalink / raw)
To: Maxime Ripard
Cc: Liam Girdwood, Mark Brown, Mark Rutland, Frank Rowand, Linux-ALSA,
devicetree, Nuno Sá, Lars-Peter Clausen
On Tue, Nov 5, 2019 at 5:06 AM Maxime Ripard <maxime@cerno.tech> wrote:
>
> The ADAU7118 has an example where the codec has an i2c address of 14, and
> the unit address set to 14 as well.
>
> However, while the address is expressed in decimal, the unit-address is
> supposed to be in hexadecimal, which ends up with two different addresses
> that trigger a DTC warning. Fix this by setting the address to 0x14.
>
> Cc: Nuno Sá <nuno.sa@analog.com>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Fixes: 969d49b2cdc8 ("dt-bindings: asoc: Add ADAU7118 documentation")
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
>
> ---
>
> Changes from v1:
> - Fix the address instead of the unit-address.
> ---
> Documentation/devicetree/bindings/sound/adi,adau7118.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-05 15:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-05 10:56 [PATCH v2] dt-bindings: sound: adau7118: Fix example warning Maxime Ripard
2019-11-05 15:44 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).