From: Catalin Marinas <catalin.marinas@arm.com>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
devicetree@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Eric Anholt <eric@anholt.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: bcm2711: force CMA into first GB of memory
Date: Tue, 5 Nov 2019 14:51:50 +0000 [thread overview]
Message-ID: <20191105145150.GB22987@arrakis.emea.arm.com> (raw)
In-Reply-To: <588d05b4-e66c-4aa0-436e-12d244a6efd8@gmx.net>
On Mon, Nov 04, 2019 at 06:09:39PM +0100, Stefan Wahren wrote:
> Hi Nicolas,
>
> Am 04.11.19 um 14:54 schrieb Nicolas Saenz Julienne:
> > arm64 places the CMA in ZONE_DMA32, which is not good enough for the
> > Raspberry Pi 4 since it contains peripherals that can only address the
> > first GB of memory. Explicitly place the CMA into that area.
> >
> > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
>
> do you want this in Linux 5.5 via devicetree/fixes? In this case please
> add an fixes tag.
That's not really a fix since AFAICT CMA never worked properly on RPi4
with mainline. For 5.5, I queued the arm64 for-next/zone-dma patches
which would allow RPi4 to get a CMA in the correct physical address
range. However, since these patches cause a regression on other
platforms that don't need a small ZOEN_DMA, my suggestion was to leave
the CMA handling for RPi4 as per the current mainline (i.e. broken) and
allow CMA from the full ZONE_DMA32 range (second patch in this series).
IIUC, this dts patch can be merged independently of the ZONE_DMA patches
for arm64 and it may be beneficial for current mainline (even without
the arm64/for-next/zone-dma patches).
[1] git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux for-next/zone-dma
> Otherwise this will be queued for Linux 5.6.
I'm happy to queue them together with your ack for 5.5, otherwise I'll
only pick the second patch in this series.
Thanks.
--
Catalin
next prev parent reply other threads:[~2019-11-05 14:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 13:54 [PATCH 0/2] arm64: Fix CMA/crashkernel reservation Nicolas Saenz Julienne
2019-11-04 13:54 ` [PATCH 1/2] ARM: dts: bcm2711: force CMA into first GB of memory Nicolas Saenz Julienne
2019-11-04 17:09 ` Stefan Wahren
2019-11-04 17:19 ` Nicolas Saenz Julienne
2019-11-04 17:51 ` Florian Fainelli
2019-11-04 18:48 ` Florian Fainelli
2019-11-04 18:53 ` Nicolas Saenz Julienne
2019-11-05 14:51 ` Catalin Marinas [this message]
2019-11-05 22:04 ` Stefan Wahren
2019-11-04 13:54 ` [PATCH 2/2] arm64: mm: reserve CMA and crashkernel in ZONE_DMA32 Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105145150.GB22987@arrakis.emea.arm.com \
--to=catalin.marinas@arm.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=nsaenzjulienne@suse.de \
--cc=robh+dt@kernel.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).