From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A86AC5DF62 for ; Tue, 5 Nov 2019 19:31:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C51321928 for ; Tue, 5 Nov 2019 19:31:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572982264; bh=DANwge0pl0jxO6NsvwyOA5Ucz9xwOOV6M82LPSfakpM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=tG8x4BGxZJF8xYIjyklweuCCRZv1yN0dv4PGk0C0v8+yoeLWkXT14f22OrGFhRy3j xKKfvkC7qSB43DgJgOv+ecznOM2EZhAM9wsOvMkXCcFEGCZeWABxFPvvKPK6Jczx7Z 4HLX+xlWuEscihsIaz2eFfYbGCOZ6Sq/keqsQS+4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390314AbfKETbD (ORCPT ); Tue, 5 Nov 2019 14:31:03 -0500 Received: from mail-ot1-f65.google.com ([209.85.210.65]:33997 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389691AbfKETbD (ORCPT ); Tue, 5 Nov 2019 14:31:03 -0500 Received: by mail-ot1-f65.google.com with SMTP id t4so7190903otr.1; Tue, 05 Nov 2019 11:31:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=eXCrqaM2ReNAR8xM9spgb2Ee5zhCWir3DnZ51DYqUs0=; b=YWsfZJwEFvAcw0YM7AT9gmKK9ZA6rxygwrCRQX1GOiZ+W4ujfnLD6T6Lyiw9/0zJwE TG4+R2ZQVqdO8Cm5nVBlIS/45Rz2X1Lm7wxo82nB7yuhba42V66f6HhF38SudfU8rFDb iSKgt83IvsYeMYCAWPNVCFcNHZP6KVV44QI5kAJ/8i8fsBQbflAfRazFwVM7s9MFuyHO ZXm3UYbEbbEDyCtHXyWFl1aeKUclFtnW6QK+g4MfIfRZ4s1uH6nAh22GSC1KaAHj1v1X Gv0P3zSncTCq4y1zXLwGz6FTmnXgtJAFGZ6BUeng2ZDBl0MjrA275Zswks65KEgA27LN R53A== X-Gm-Message-State: APjAAAVdATyFE3gOW1tBgI8affRsWa0F1B9QbZx9QROeJJEqdRjMDyzV SMoaOC0TmQ0Pw41kM8wu4A== X-Google-Smtp-Source: APXvYqzre2W/9ZqnBFFrz/aj+RCDtEBQysbqFeG7AzSN3ieOnpHrDpu7BFOp+KDwAVrQMDlaLseVCw== X-Received: by 2002:a05:6830:46:: with SMTP id d6mr13605649otp.7.1572982261489; Tue, 05 Nov 2019 11:31:01 -0800 (PST) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id y7sm6891792ote.81.2019.11.05.11.31.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 11:31:00 -0800 (PST) Date: Tue, 5 Nov 2019 13:31:00 -0600 From: Rob Herring To: Srinivas Kandagatla Cc: broonie@kernel.org, lee.jones@linaro.org, linus.walleij@linaro.org, vinod.koul@linaro.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, spapothi@codeaurora.org, bgoswami@codeaurora.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v3 01/11] ASoC: dt-bindings: add dt bindings for WCD9340/WCD9341 audio codec Message-ID: <20191105193100.GB4709@bogus> References: <20191029112700.14548-1-srinivas.kandagatla@linaro.org> <20191029112700.14548-2-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191029112700.14548-2-srinivas.kandagatla@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Oct 29, 2019 at 11:26:50AM +0000, Srinivas Kandagatla wrote: > This patch adds bindings for wcd9340/wcd9341 audio codec which can > support both SLIMbus and I2S/I2C interface. > > Signed-off-by: Srinivas Kandagatla > --- > .../bindings/sound/qcom,wcd934x.yaml | 162 ++++++++++++++++++ > 1 file changed, 162 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml > > diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml > new file mode 100644 > index 000000000000..d6cfde6597db > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml > @@ -0,0 +1,162 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/qcom,wcd934x.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Bindings for Qualcomm WCD9340/WCD9341 Audio Codec > + > +maintainers: > + - Srinivas Kandagatla > + > +description: | > + Qualcomm WCD9340/WCD9341 Codec is a standalone Hi-Fi audio codec IC. > + It has in-built Soundwire controller, pin controller, interrupt mux and > + supports both I2S/I2C and SLIMbus audio interfaces. > + > +properties: > + compatible: > + const: slim217,250 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + reset-gpios: > + description: GPIO spec for reset line to use > + maxItems: 1 > + > + slim-ifc-dev: > + description: SLIMBus Interface device phandle > + $ref: '/schemas/types.yaml#/definitions/phandle' > + maxItems: 1 Replied on previous version. > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: extclk > + > + vdd-buck-supply: > + description: A reference to the 1.8V buck supply > + > + vdd-buck-sido-supply: > + description: A reference to the 1.8V SIDO buck supply > + > + vdd-rx-supply: > + description: A reference to the 1.8V rx supply > + > + vdd-tx-supply: > + description: A reference to the 1.8V tx supply > + > + vdd-vbat-supply: > + description: A reference to the vbat supply > + > + vdd-io-supply: > + description: A reference to the 1.8V I/O supply > + > + vdd-micbias-supply: > + description: A reference to the micbias supply > + > + qcom,micbias1-microvolts: The standard unit is 'microvolt', not 'microvolts'. > + description: micbias1 voltage between 1800000 - 2850000 microvolts > + > + qcom,micbias2-microvolts: > + description: micbias2 voltage between 1800000 - 2850000 microvolts > + > + qcom,micbias3-microvolts: > + description: micbias3 voltage between 1800000 - 2850000 microvolts > + > + qcom,micbias4-microvolts: > + description: micbias4 voltage between 1800000 - 2850000 microvolts > + > + clock-output-names: > + const: mclk > + > + clock-frequency: > + description: Clock frequency of output clk in Hz > + > + interrupt-controller: true > + > + '#interrupt-cells': > + const: 1 > + > + '#clock-cells': > + const: 0 > + > + '#sound-dai-cells': > + const: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 1 > + > +patternProperties: > + "^.*@[0-9a-f]+$": > + type: object > + description: | > + WCD934x subnode for each slave devices. Bindings of each subnodes > + depends on the specific driver providing the functionality and > + documented in their respective bindings. > + > + properties: > + reg: > + maxItems: 1 > + > + required: > + - reg > + > +required: > + - compatible > + - reg > + - reset-gpios > + - slim-ifc-dev > + - interrupts > + - interrupt-controller > + - clock-frequency > + - clock-output-names > + - qcom,micbias1-microvolts > + - qcom,micbias2-microvolts > + - qcom,micbias3-microvolts > + - qcom,micbias4-microvolts > + - "#interrupt-cells" > + - "#clock-cells" > + - "#sound-dai-cells" > + - "#address-cells" > + - "#size-cells" > + > +examples: > + - | > + codec@1,0{ > + compatible = "slim217,250"; > + reg = <1 0>; > + reset-gpios = <&tlmm 64 0>; > + slim-ifc-dev = <&wcd9340_ifd>; > + #sound-dai-cells = <1>; > + interrupt-parent = <&tlmm>; > + interrupts = <54 4>; > + interrupt-controller; > + #interrupt-cells = <1>; > + #clock-cells = <0>; > + clock-frequency = <9600000>; > + clock-output-names = "mclk"; > + qcom,micbias1-microvolts = <1800000>; > + qcom,micbias2-microvolts = <1800000>; > + qcom,micbias3-microvolts = <1800000>; > + qcom,micbias4-microvolts = <1800000>; > + clock-names = "extclk"; > + clocks = <&rpmhcc 2>; > + > + #address-cells = <1>; > + #size-cells = <1>; > + > + pinctrl@42 { > + reg = <0x42 0x2>; > + }; > + }; > + > +... > -- > 2.21.0 >