From: Rob Herring <robh@kernel.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Maxime Ripard <mripard@kernel.org>,
Hugo Grostabussiat <bonstra@bonstra.fr.eu.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
devicetree@vger.kernel.org, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: net: bluetooth: add DT binding for Realtek controllers
Date: Tue, 5 Nov 2019 16:28:31 -0600 [thread overview]
Message-ID: <20191105222831.GB15425@bogus> (raw)
In-Reply-To: <6C5CE71F-37F2-4C8A-9D94-1BC75937B478@holtmann.org>
On Mon, Nov 04, 2019 at 03:20:59PM +0100, Marcel Holtmann wrote:
> Hi Hugo,
>
> >> The rtl_bt driver already supports some Realtek controllers on ACPI
> >> platforms.
> >> This commit adds bindings for DT-only platforms.
> >>
> >> Signed-off-by: Hugo Grostabussiat <bonstra@bonstra.fr.eu.org>
> >> ---
> >> .../bindings/net/realtek-bluetooth.txt | 25 +++++++++++++++++++
> >> 1 file changed, 25 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/net/realtek-bluetooth.txt
> >
> > You should write that binding using a YAML description. Free-form
> > device tree bindings are more or less deprecated now.
>
> unless we change all the Bluetooth descriptions, I prefer we keep it the “old” way.
Who's going to do that? Me? You? Randomly select some poor soul to do
them all to get their device added? I only have 3500 to do. An all at
once approach doesn't really work nor is it necessary.
I'd suggest new ones in schema and if you want to encourage conversions
require any changes on existing ones to first be converted. Still up to
you because it goes thru your tree.
> > IIRC, that has been discussed before and the standard "model" property
> > was to be preferred.
>
> This one should really get an ACK from Rob.
Humm, maybe, but I don't see 'model' used in this context.
Rob
next prev parent reply other threads:[~2019-11-05 22:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 22:43 [PATCH v2 0/3] Add Bluetooth support to Teres A64 I Hugo Grostabussiat
2019-10-30 22:43 ` [PATCH v2 1/3] dt-bindings: net: bluetooth: add DT binding for Realtek controllers Hugo Grostabussiat
2019-11-01 8:02 ` Maxime Ripard
2019-11-04 14:20 ` Marcel Holtmann
2019-11-05 10:13 ` Maxime Ripard
2019-11-05 22:28 ` Rob Herring [this message]
2019-11-05 22:17 ` Rob Herring
2019-11-05 23:17 ` Hugo "Bonstra" Grostabussiat
2019-10-30 22:43 ` [PATCH v2 2/3] Bluetooth: hci_h5: Add DT support for rtl8723bs Hugo Grostabussiat
2019-10-31 6:20 ` Marcel Holtmann
2019-10-30 22:43 ` [PATCH v2 3/3] arm64: dts: allwinner: a64: Enable Bluetooth on Teres-I Hugo Grostabussiat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105222831.GB15425@bogus \
--to=robh@kernel.org \
--cc=bonstra@bonstra.fr.eu.org \
--cc=devicetree@vger.kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).