From: Stephan Gerhold <stephan@gerhold.net>
To: Jean-Baptiste Maneyrol <JManeyrol@invensense.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Brian Masney <masneyb@onstation.org>,
Jonathan Marek <jonathan@marek.ca>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] iio: imu: mpu6050: Add support for vdd-supply regulator
Date: Wed, 6 Nov 2019 22:36:16 +0100 [thread overview]
Message-ID: <20191106213359.GA130672@gerhold.net> (raw)
In-Reply-To: <MN2PR12MB3373CA676226F02BE0C804A8C4790@MN2PR12MB3373.namprd12.prod.outlook.com>
Hi JB,
On Wed, Nov 06, 2019 at 07:55:20PM +0000, Jean-Baptiste Maneyrol wrote:
> Hello Stephan,
>
> nice patch but I have an important concern.
>
> We are calling the core_enable/disable_regulator functions when going into suspend and resume.
> With your changes, we are going to power down the chip when going into suspend and then power it up again.
> This way we will loose all already set configuration, like FSR, sampling rate, init values, ...
> The chip will not be able to work correctly anymore after a suspend-resume cycle.
>
> You need to change the resume/suspend handlers to only disable/enable the vddio regulator, not the vdd one.
That is a good point, thanks!
I guess we are not able to use the regulator bulk API in this case...
I will send a v2 soon.
Stephan
next prev parent reply other threads:[~2019-11-06 21:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 18:35 [PATCH 1/2] dt-bindings: iio: imo: mpu6050: add vdd-supply Stephan Gerhold
2019-11-06 18:35 ` [PATCH 2/2] iio: imu: mpu6050: Add support for vdd-supply regulator Stephan Gerhold
2019-11-06 19:55 ` Jean-Baptiste Maneyrol
2019-11-06 21:36 ` Stephan Gerhold [this message]
2019-11-07 13:29 ` Jean-Baptiste Maneyrol
2019-11-07 18:12 ` Stephan Gerhold
2019-11-07 15:06 ` [PATCH 1/2] dt-bindings: iio: imo: mpu6050: add vdd-supply Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106213359.GA130672@gerhold.net \
--to=stephan@gerhold.net \
--cc=JManeyrol@invensense.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=jonathan@marek.ca \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masneyb@onstation.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).