From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marian Mihailescu <mihailescu2m@gmail.com>
Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, kgene@kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: gpu: mali-midgard: add samsung exynos 5420 compatible
Date: Thu, 7 Nov 2019 10:16:57 +0100 [thread overview]
Message-ID: <20191107091657.GA1828@pi3> (raw)
In-Reply-To: <20191106225527.9121-1-mihailescu2m@gmail.com>
On Thu, Nov 07, 2019 at 09:25:26AM +1030, Marian Mihailescu wrote:
> Add "samsung,exynos5420-mali" binding
>
> Signed-off-by: Marian Mihailescu <mihailescu2m@gmail.com>
> ---
> Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
> index 47bc1ac36426..41b928bce4ea 100644
> --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
> @@ -38,9 +38,12 @@ properties:
> - enum:
> - samsung,exynos5433-mali
> - const: arm,mali-t760
> + - items:
> + - enum:
> + - samsung,exynos5420-mali
> + - const: arm,mali-t628
I would prefer to order it logically/alphabetically, so after 5250 and
before 5433. With that change:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2019-11-07 9:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 22:55 [PATCH v4 1/2] dt-bindings: gpu: mali-midgard: add samsung exynos 5420 compatible Marian Mihailescu
2019-11-06 22:55 ` [PATCH v4 2/2] ARM: dts: exynos5420: add mali dt node and enable mali on Odroid XU3/4 Marian Mihailescu
2019-11-07 9:48 ` Krzysztof Kozlowski
2019-11-12 15:19 ` Krzysztof Kozlowski
2019-11-14 0:06 ` Marian Mihailescu
2019-11-07 9:16 ` Krzysztof Kozlowski [this message]
2019-11-14 0:02 ` [PATCH v4 1/2] dt-bindings: gpu: mali-midgard: add samsung exynos 5420 compatible Rob Herring
2019-11-14 0:11 ` Marian Mihailescu
2019-11-13 3:21 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107091657.GA1828@pi3 \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mihailescu2m@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).