* Re: [PATCH v2] dt-bindings: clk: Make example a bit clearer [not found] <20190823100315.2148-1-ada@thorsis.com> @ 2019-09-11 16:06 ` Stephen Boyd 2019-09-11 17:49 ` Uwe Kleine-König 0 siblings, 1 reply; 3+ messages in thread From: Stephen Boyd @ 2019-09-11 16:06 UTC (permalink / raw) To: Alexander Dahl, Michael Turquette, Rob Herring Cc: u.kleine-koenig, kernel, linux-clk, devicetree Quoting Alexander Dahl (2019-08-23 03:03:15) > Signed-off-by: Alexander Dahl <ada@thorsis.com> > --- You need to Cc Rob and devicetree list on binding changes. > > Notes: > v2: > Add additional explaining text to following paragraph and strip mail > headers from commit message. > > .../devicetree/bindings/clock/clock-bindings.txt | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/clock-bindings.txt b/Documentation/devicetree/bindings/clock/clock-bindings.txt > index b646bbcf7f92..1d4942380918 100644 > --- a/Documentation/devicetree/bindings/clock/clock-bindings.txt > +++ b/Documentation/devicetree/bindings/clock/clock-bindings.txt > @@ -150,16 +150,18 @@ set to 0, or can be omitted if it is not followed by any non-zero entry. > compatible = "fsl,imx-uart"; > reg = <0xa000 0x1000>; > ... > - clocks = <&osc 0>, <&pll 1>; > - clock-names = "baud", "register"; > + clocks = ... > + clock-names = ... I don't see the need for this change. > > assigned-clocks = <&clkcon 0>, <&pll 2>; > - assigned-clock-parents = <&pll 2>; > + assigned-clock-parents = <&pll 1>; > assigned-clock-rates = <0>, <460800>; > }; > > -In this example the <&pll 2> clock is set as parent of clock <&clkcon 0> and > -the <&pll 2> clock is assigned a frequency value of 460800 Hz. > +In this example the <&pll 1> clock is set as parent of clock <&clkcon 0> and > +the <&pll 2> clock is assigned a frequency value of 460800 Hz. A parent > +setting for <&pll 2> is omitted (end of list) and rate setting for <&clkcon 0> > +is skipped because set to <0>. Maybe you can comment that the "clocks" and "clock-names" properties don't matter for assigned clk rates and parents. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: clk: Make example a bit clearer 2019-09-11 16:06 ` [PATCH v2] dt-bindings: clk: Make example a bit clearer Stephen Boyd @ 2019-09-11 17:49 ` Uwe Kleine-König [not found] ` <20190916201316.ED7EB20665@mail.kernel.org> 0 siblings, 1 reply; 3+ messages in thread From: Uwe Kleine-König @ 2019-09-11 17:49 UTC (permalink / raw) To: Stephen Boyd Cc: Alexander Dahl, Michael Turquette, Rob Herring, devicetree, linux-clk, kernel Hello, On Wed, Sep 11, 2019 at 09:06:47AM -0700, Stephen Boyd wrote: > > diff --git a/Documentation/devicetree/bindings/clock/clock-bindings.txt b/Documentation/devicetree/bindings/clock/clock-bindings.txt > > index b646bbcf7f92..1d4942380918 100644 > > --- a/Documentation/devicetree/bindings/clock/clock-bindings.txt > > +++ b/Documentation/devicetree/bindings/clock/clock-bindings.txt > > @@ -150,16 +150,18 @@ set to 0, or can be omitted if it is not followed by any non-zero entry. > > compatible = "fsl,imx-uart"; > > reg = <0xa000 0x1000>; > > ... > > - clocks = <&osc 0>, <&pll 1>; > > - clock-names = "baud", "register"; > > + clocks = ... > > + clock-names = ... > > I don't see the need for this change. <&pll 1> is mentioned below. But it is not this instance that is relevant. So I suggested to get rid of it to not be a source of confusion. (But I guess you understood that.) > > assigned-clocks = <&clkcon 0>, <&pll 2>; > > - assigned-clock-parents = <&pll 2>; > > + assigned-clock-parents = <&pll 1>; > > assigned-clock-rates = <0>, <460800>; > > }; > > > > -In this example the <&pll 2> clock is set as parent of clock <&clkcon 0> and > > -the <&pll 2> clock is assigned a frequency value of 460800 Hz. > > +In this example the <&pll 1> clock is set as parent of clock <&clkcon 0> and > > +the <&pll 2> clock is assigned a frequency value of 460800 Hz. A parent > > +setting for <&pll 2> is omitted (end of list) and rate setting for <&clkcon 0> > > +is skipped because set to <0>. > > Maybe you can comment that the "clocks" and "clock-names" properties > don't matter for assigned clk rates and parents. Sure, a long text can explain this, but a maximal simple example is very beneficial, too. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K�nig | Industrial Linux Solutions | http://www.pengutronix.de/ | ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <20190916201316.ED7EB20665@mail.kernel.org>]
[parent not found: <2819678.zAmqMVPImI@ada>]
* Re: [PATCH v2] dt-bindings: clk: Make example a bit clearer [not found] ` <2819678.zAmqMVPImI@ada> @ 2019-11-08 22:18 ` Stephen Boyd 0 siblings, 0 replies; 3+ messages in thread From: Stephen Boyd @ 2019-11-08 22:18 UTC (permalink / raw) To: Alexander Dahl, linux-clk Cc: u.kleine-koenig, Michael Turquette, Rob Herring, devicetree, kernel Quoting Alexander Dahl (2019-10-10 07:16:00) > > > If anything, I would clarify the description of > > the example by indicating what parts of the example we're talking about > > when explaining, i.e. > > > > In this example the <&pll 2> clock is set as parent of the > > <&clkcon 0> clock because the first clock specifier in the > > assigned-clocks property is <&clkcon 0> and that matches the > > first clock specifier in the assigned-clock-parents property. > > Similarly the <&pll 2> clock is assigned a frequency value of > > 460800 Hz because the second frequency in the > > assigned-clock-rates property is 460800 Hz and that matches the > > second clock specifier in the assigned-clocks property <&pll 2>. > > I could go with that and send a v3 with the obfuscation from above (I'd like > to keep that) and this paragraph of yours? > Sure. Please resend. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-08 22:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190823100315.2148-1-ada@thorsis.com>
2019-09-11 16:06 ` [PATCH v2] dt-bindings: clk: Make example a bit clearer Stephen Boyd
2019-09-11 17:49 ` Uwe Kleine-König
[not found] ` <20190916201316.ED7EB20665@mail.kernel.org>
[not found] ` <2819678.zAmqMVPImI@ada>
2019-11-08 22:18 ` Stephen Boyd
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).