* [PATCH v21 0/4] Add support for mt8183 SCP.
@ 2019-11-12 11:03 Pi-Hsun Shih
2019-11-12 11:03 ` [PATCH v21 1/4] dt-bindings: Add a binding for Mediatek SCP Pi-Hsun Shih
2019-11-12 11:03 ` [PATCH v21 4/4] arm64: dts: mt8183: add scp node Pi-Hsun Shih
0 siblings, 2 replies; 10+ messages in thread
From: Pi-Hsun Shih @ 2019-11-12 11:03 UTC (permalink / raw)
Cc: Pi-Hsun Shih,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Mediatek SoC support, open list,
moderated list:ARM/Mediatek SoC support,
open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM
Add support for controlling and communicating with mt8183's system
control processor (SCP), using the remoteproc & rpmsg framework.
And also add a cros_ec driver for CrOS EC host command over rpmsg.
The overall structure of the series is:
* remoteproc/mtk_scp.c: Control the start / stop of SCP (Patch 2).
* remoteproc/mtk_scp_ipi.c: Communicates to SCP using inter-processor
interrupt (IPI) and shared memory (Patch 2).
* rpmsg/mtk_rpmsg.c: Wrapper to wrap the IPI communication into a rpmsg
device. Supports name service for SCP firmware to
announce channels (Patch 3).
* add scp dts node to mt8183 platform (Patch 4).
Changes from v20:
- Change all public API usage of (struct platform_device *) to (struct
mtk_scp *).
- Rename some variables and functions to be more specific.
- Move docs to implementation, and improve docs.
- Address review comments.
Changes from v19:
- Fix an incorrect include in mtk_rpmsg.h (linux/device.h ->
linux/platform_device.h)
Changes from v18:
- Change the way shared memory is handled, and drop patch 3.
Changes from v17:
- Fix mixture use of __iomem found by sparse.
- Change the ipi handler to take a u32 instead of enum scp_ipi_id.
- Mark mtk_rpmsg_{prepare,unprepare,stop} as static.
Changes from v16:
- Change the desc_lock mutex to be a per-id lock.
- Put the execution of handler inside the per-id lock, to prevent race
between scp_ipi_unregister and handler being run.
- Move the initialization of mutex to before scp_ipi_register.
Changes from v15:
- Fix a bug on incorrect usage of wait_event_timeout return value.
Changes from v14:
- Fix a typo on variable in DEBUG section.
Changes from v13:
- Move include/linux/platform_data/mtk_scp.h to
include/linux/remoteproc/mtk_scp.h.
- Rename scp_get_reserve_* to scp_get_reserved_*.
- Add lock for access of scp->ipi_desc.
- Lock the whole ipi_send function.
- Move more setting of cache size from SCP firmware to kernel driver,
to prevent problem while loading firmware onto DRAM.
- Minor fixes addressing comment.
Changes from v12:
- Initialize cache before firmware load, to avoid problem while loading
large firmware.
- Disable watchdog before stopping SCP, to avoid extra warning message.
- Fix new warnings by checkpatch.
Changes from v11:
- Fixed a bug that mtk_rpmsg_endpoint is not properly cleaned up if
rproc_boot fails.
- Add missing documentation in comment.
Changes from v10:
- Drop applied cros_ec_rpmsg patches.
- Add clock reset before loading SCP firmware.
- Fix some type mismatch warnings when printing debug messages.
Changes from v9:
- Remove reserve-memory-vpu_share node.
- Remove change to cros_ec_commands.h (That is already in
https://lore.kernel.org/lkml/20190518063949.GY4319@dell/T/)
Changes from v8:
- Rebased onto https://patchwork.kernel.org/cover/10962385/.
- Drop merged cros_ec_rpmsg patch, and add scp dts node patch.
- Add more reserved memory region.
Changes from v7:
- Rebase onto https://lore.kernel.org/patchwork/patch/1059196/.
- Fix clock enable/disable timing for SCP driver.
- Add more SCP IPI ID.
Changes from v6:
- Decouple mtk_rpmsg from mtk_scp.
- Change data of EC response to be aligned to 4 bytes.
Changes from v5:
- Add device tree binding document for cros_ec_rpmsg.
- Better document in comments for cros_ec_rpmsg.
- Remove dependency on CONFIG_ in binding tree document.
Changes from v4:
- Merge patch 6 (Load ELF firmware) into patch 2, so the driver loads
ELF firmware by default, and no longer accept plain binary.
- rpmsg_device listed in device tree (as a child of the SCP node) would
have it's device tree node mapped to the rpmsg_device, so the rpmsg
driver can use the properties on device tree.
Changes from v3:
- Make writing to SCP SRAM aligned.
- Add a new patch (Patch 6) to load ELF instead of bin firmware.
- Add host event support for EC driver.
- Fix some bugs found in testing (missing spin_lock_init,
rproc_subdev_unprepare to rproc_subdev_stop).
- Fix some coding style issue found by checkpatch.pl.
Changes from v2:
- Fold patch 3 into patch 2 in v2.
- Move IPI id around to support cross-testing for old and new firmware.
- Finish more TODO items.
Changes from v1:
- Extract functions and rename variables in mtk_scp.c.
- Do cleanup properly in mtk_rpmsg.c, which also removes the problem of
short-lived work items.
- Code format fix based on feedback for cros_ec_rpmsg.c.
- Extract feature detection for SCP into separate patch (Patch 6).
Eddie Huang (1):
arm64: dts: mt8183: add scp node
Erin Lo (2):
dt-bindings: Add a binding for Mediatek SCP
remoteproc/mediatek: add SCP support for mt8183
Pi-Hsun Shih (1):
rpmsg: add rpmsg support for mt8183 SCP.
.../bindings/remoteproc/mtk,scp.txt | 36 +
arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 11 +
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 12 +
drivers/remoteproc/Kconfig | 10 +
drivers/remoteproc/Makefile | 1 +
drivers/remoteproc/mtk_common.h | 94 +++
drivers/remoteproc/mtk_scp.c | 663 ++++++++++++++++++
drivers/remoteproc/mtk_scp_ipi.c | 219 ++++++
drivers/rpmsg/Kconfig | 9 +
drivers/rpmsg/Makefile | 1 +
drivers/rpmsg/mtk_rpmsg.c | 414 +++++++++++
include/linux/remoteproc/mtk_scp.h | 66 ++
include/linux/rpmsg/mtk_rpmsg.h | 38 +
13 files changed, 1574 insertions(+)
create mode 100644 Documentation/devicetree/bindings/remoteproc/mtk,scp.txt
create mode 100644 drivers/remoteproc/mtk_common.h
create mode 100644 drivers/remoteproc/mtk_scp.c
create mode 100644 drivers/remoteproc/mtk_scp_ipi.c
create mode 100644 drivers/rpmsg/mtk_rpmsg.c
create mode 100644 include/linux/remoteproc/mtk_scp.h
create mode 100644 include/linux/rpmsg/mtk_rpmsg.h
base-commit: fc6d6db1df2cb11bbecc542d67885742e75b4b07
--
2.24.0.rc1.363.gb1bccd3e3d-goog
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v21 1/4] dt-bindings: Add a binding for Mediatek SCP
2019-11-12 11:03 [PATCH v21 0/4] Add support for mt8183 SCP Pi-Hsun Shih
@ 2019-11-12 11:03 ` Pi-Hsun Shih
2019-11-12 11:03 ` [PATCH v21 4/4] arm64: dts: mt8183: add scp node Pi-Hsun Shih
1 sibling, 0 replies; 10+ messages in thread
From: Pi-Hsun Shih @ 2019-11-12 11:03 UTC (permalink / raw)
Cc: Pi-Hsun Shih, Erin Lo, Rob Herring, Ohad Ben-Cohen,
Bjorn Andersson, Rob Herring, Mark Rutland, Matthias Brugger,
open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support, open list
From: Erin Lo <erin.lo@mediatek.com>
Add a DT binding documentation of SCP for the
MT8183 SoC from Mediatek.
Signed-off-by: Erin Lo <erin.lo@mediatek.com>
Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Rob Herring <robh@kernel.org>
---
Changes from v20 ... v6:
- No change.
Changes from v5:
- Remove dependency on CONFIG_RPMSG_MTK_SCP.
Changes from v4:
- Add detail of more properties.
- Document the usage of mtk,rpmsg-name in subnode from the new design.
Changes from v3:
- No change.
Changes from v2:
- No change. I realized that for this patch series, there's no need to
add anything under the mt8183-scp node (neither the mt8183-rpmsg or
the cros-ec-rpmsg) for them to work, since mt8183-rpmsg is added
directly as a rproc_subdev by code, and cros-ec-rpmsg is dynamically
created by SCP name service.
Changes from v1:
- No change.
---
.../bindings/remoteproc/mtk,scp.txt | 36 +++++++++++++++++++
1 file changed, 36 insertions(+)
create mode 100644 Documentation/devicetree/bindings/remoteproc/mtk,scp.txt
diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.txt b/Documentation/devicetree/bindings/remoteproc/mtk,scp.txt
new file mode 100644
index 000000000000..3ba668bab14b
--- /dev/null
+++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.txt
@@ -0,0 +1,36 @@
+Mediatek SCP Bindings
+----------------------------------------
+
+This binding provides support for ARM Cortex M4 Co-processor found on some
+Mediatek SoCs.
+
+Required properties:
+- compatible Should be "mediatek,mt8183-scp"
+- reg Should contain the address ranges for the two memory
+ regions, SRAM and CFG.
+- reg-names Contains the corresponding names for the two memory
+ regions. These should be named "sram" & "cfg".
+- clocks Clock for co-processor (See: ../clock/clock-bindings.txt)
+- clock-names Contains the corresponding name for the clock. This
+ should be named "main".
+
+Subnodes
+--------
+
+Subnodes of the SCP represent rpmsg devices. The names of the devices are not
+important. The properties of these nodes are defined by the individual bindings
+for the rpmsg devices - but must contain the following property:
+
+- mtk,rpmsg-name Contains the name for the rpmsg device. Used to match
+ the subnode to rpmsg device announced by SCP.
+
+Example:
+
+ scp: scp@10500000 {
+ compatible = "mediatek,mt8183-scp";
+ reg = <0 0x10500000 0 0x80000>,
+ <0 0x105c0000 0 0x5000>;
+ reg-names = "sram", "cfg";
+ clocks = <&infracfg CLK_INFRA_SCPSYS>;
+ clock-names = "main";
+ };
--
2.24.0.rc1.363.gb1bccd3e3d-goog
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v21 4/4] arm64: dts: mt8183: add scp node
2019-11-12 11:03 [PATCH v21 0/4] Add support for mt8183 SCP Pi-Hsun Shih
2019-11-12 11:03 ` [PATCH v21 1/4] dt-bindings: Add a binding for Mediatek SCP Pi-Hsun Shih
@ 2019-11-12 11:03 ` Pi-Hsun Shih
2020-08-27 10:14 ` Matthias Brugger
2020-09-10 10:51 ` Matthias Brugger
1 sibling, 2 replies; 10+ messages in thread
From: Pi-Hsun Shih @ 2019-11-12 11:03 UTC (permalink / raw)
Cc: Pi-Hsun Shih, Eddie Huang, Erin Lo, Rob Herring, Mark Rutland,
Matthias Brugger,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support, open list
From: Eddie Huang <eddie.huang@mediatek.com>
Add scp node to mt8183 and mt8183-evb
Signed-off-by: Erin Lo <erin.lo@mediatek.com>
Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
Signed-off-by: Eddie Huang <eddie.huang@mediatek.com>
---
Changes from v20 ... v14:
- No change.
Changes from v13:
- Change the size of the cfg register region.
Changes from v12 ... v10:
- No change.
Changes from v9:
- Remove extra reserve-memory-vpu_share node.
Changes from v8:
- New patch.
---
arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 11 +++++++++++
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 12 ++++++++++++
2 files changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
index 1fb195c683c3..ddb7a7ac9655 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
@@ -24,6 +24,17 @@ memory@40000000 {
chosen {
stdout-path = "serial0:921600n8";
};
+
+ reserved-memory {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+ scp_mem_reserved: scp_mem_region {
+ compatible = "shared-dma-pool";
+ reg = <0 0x50000000 0 0x2900000>;
+ no-map;
+ };
+ };
};
&auxadc {
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 10b32471bc7b..e582f5e6691d 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -269,6 +269,18 @@ pwrap: pwrap@1000d000 {
clock-names = "spi", "wrap";
};
+ scp: scp@10500000 {
+ compatible = "mediatek,mt8183-scp";
+ reg = <0 0x10500000 0 0x80000>,
+ <0 0x105c0000 0 0x19080>;
+ reg-names = "sram", "cfg";
+ interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&infracfg CLK_INFRA_SCPSYS>;
+ clock-names = "main";
+ memory-region = <&scp_mem_reserved>;
+ status = "disabled";
+ };
+
systimer: timer@10017000 {
compatible = "mediatek,mt8183-timer",
"mediatek,mt6765-timer";
--
2.24.0.rc1.363.gb1bccd3e3d-goog
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v21 4/4] arm64: dts: mt8183: add scp node
2019-11-12 11:03 ` [PATCH v21 4/4] arm64: dts: mt8183: add scp node Pi-Hsun Shih
@ 2020-08-27 10:14 ` Matthias Brugger
2020-09-02 14:40 ` Naresh Kamboju
2020-09-10 10:51 ` Matthias Brugger
1 sibling, 1 reply; 10+ messages in thread
From: Matthias Brugger @ 2020-08-27 10:14 UTC (permalink / raw)
To: Pi-Hsun Shih
Cc: Eddie Huang, Erin Lo, Rob Herring, Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support, open list,
Alexandre Courbot, Bjorn Andersson
On 12/11/2019 12:03, Pi-Hsun Shih wrote:
> From: Eddie Huang <eddie.huang@mediatek.com>
>
> Add scp node to mt8183 and mt8183-evb
>
> Signed-off-by: Erin Lo <erin.lo@mediatek.com>
> Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
> Signed-off-by: Eddie Huang <eddie.huang@mediatek.com>
Sorry I somehow oversaw this. Next time please don't doubt to ping me.
Bjorn, do I understand correctly that you don't send emails to the list
informing of the inclusion of a patch/series in your tree?
Anyway applied now to v5.9-next/dts64 :)
Thanks!
> ---
> Changes from v20 ... v14:
> - No change.
>
> Changes from v13:
> - Change the size of the cfg register region.
>
> Changes from v12 ... v10:
> - No change.
>
> Changes from v9:
> - Remove extra reserve-memory-vpu_share node.
>
> Changes from v8:
> - New patch.
> ---
> arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 11 +++++++++++
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 12 ++++++++++++
> 2 files changed, 23 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> index 1fb195c683c3..ddb7a7ac9655 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> @@ -24,6 +24,17 @@ memory@40000000 {
> chosen {
> stdout-path = "serial0:921600n8";
> };
> +
> + reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> + scp_mem_reserved: scp_mem_region {
> + compatible = "shared-dma-pool";
> + reg = <0 0x50000000 0 0x2900000>;
> + no-map;
> + };
> + };
> };
>
> &auxadc {
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 10b32471bc7b..e582f5e6691d 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -269,6 +269,18 @@ pwrap: pwrap@1000d000 {
> clock-names = "spi", "wrap";
> };
>
> + scp: scp@10500000 {
> + compatible = "mediatek,mt8183-scp";
> + reg = <0 0x10500000 0 0x80000>,
> + <0 0x105c0000 0 0x19080>;
> + reg-names = "sram", "cfg";
> + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&infracfg CLK_INFRA_SCPSYS>;
> + clock-names = "main";
> + memory-region = <&scp_mem_reserved>;
> + status = "disabled";
> + };
> +
> systimer: timer@10017000 {
> compatible = "mediatek,mt8183-timer",
> "mediatek,mt6765-timer";
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v21 4/4] arm64: dts: mt8183: add scp node
2020-08-27 10:14 ` Matthias Brugger
@ 2020-09-02 14:40 ` Naresh Kamboju
2020-09-02 16:23 ` Krzysztof Kozlowski
0 siblings, 1 reply; 10+ messages in thread
From: Naresh Kamboju @ 2020-09-02 14:40 UTC (permalink / raw)
To: Matthias Brugger, Eddie Huang, Linux-Next Mailing List
Cc: Pi-Hsun Shih, Erin Lo, Rob Herring, Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support, open list,
Alexandre Courbot, Bjorn Andersson, Anders Roxell, lkft-triage,
Stephen Rothwell
On Thu, 27 Aug 2020 at 15:44, Matthias Brugger <matthias.bgg@gmail.com> wrote:
>
>
>
> On 12/11/2019 12:03, Pi-Hsun Shih wrote:
> > From: Eddie Huang <eddie.huang@mediatek.com>
> >
> > Add scp node to mt8183 and mt8183-evb
> >
> > Signed-off-by: Erin Lo <erin.lo@mediatek.com>
> > Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
> > Signed-off-by: Eddie Huang <eddie.huang@mediatek.com>
>
> Sorry I somehow oversaw this. Next time please don't doubt to ping me.
>
> Bjorn, do I understand correctly that you don't send emails to the list
> informing of the inclusion of a patch/series in your tree?
>
> Anyway applied now to v5.9-next/dts64 :)
arm64 build dtbs failed on linux next 20200902.
mt8183.dtsi:342.21-352.5: ERROR (phandle_references):
/soc/scp@10500000: Reference to non-existent node or label
"scp_mem_reserved"
build log,
make -sk KBUILD_BUILD_USER=TuxBuild -C/linux ARCH=arm64
CROSS_COMPILE=aarch64-linux-gnu- HOSTCC=gcc CC="sccache
aarch64-linux-gnu-gcc" O=build dtbs
#
../arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi:7.3-14:
Warning (dma_ranges_format): /usb:dma-ranges: empty "dma-ranges"
property but its #address-cells (1) differs from / (2)
../arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi:7.3-14:
Warning (dma_ranges_format): /usb:dma-ranges: empty "dma-ranges"
property but its #size-cells (1) differs from / (2)
../arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi:7.3-14:
Warning (dma_ranges_format): /usb:dma-ranges: empty "dma-ranges"
property but its #address-cells (1) differs from / (2)
../arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi:7.3-14:
Warning (dma_ranges_format): /usb:dma-ranges: empty "dma-ranges"
property but its #size-cells (1) differs from / (2)
../arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi:7.3-14:
Warning (dma_ranges_format): /usb:dma-ranges: empty "dma-ranges"
property but its #address-cells (1) differs from / (2)
../arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi:7.3-14:
Warning (dma_ranges_format): /usb:dma-ranges: empty "dma-ranges"
property but its #size-cells (1) differs from / (2)
../arch/arm64/boot/dts/mediatek/mt8183.dtsi:342.21-352.5: ERROR
(phandle_references): /soc/scp@10500000: Reference to non-existent
node or label "scp_mem_reserved"
>
> Thanks!
>
> > ---
> > Changes from v20 ... v14:
> > - No change.
> >
> > Changes from v13:
> > - Change the size of the cfg register region.
> >
> > Changes from v12 ... v10:
> > - No change.
> >
> > Changes from v9:
> > - Remove extra reserve-memory-vpu_share node.
> >
> > Changes from v8:
> > - New patch.
> > ---
> > arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 11 +++++++++++
> > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 12 ++++++++++++
> > 2 files changed, 23 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> > index 1fb195c683c3..ddb7a7ac9655 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> > @@ -24,6 +24,17 @@ memory@40000000 {
> > chosen {
> > stdout-path = "serial0:921600n8";
> > };
> > +
> > + reserved-memory {
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > + ranges;
> > + scp_mem_reserved: scp_mem_region {
> > + compatible = "shared-dma-pool";
> > + reg = <0 0x50000000 0 0x2900000>;
> > + no-map;
> > + };
> > + };
> > };
> >
> > &auxadc {
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > index 10b32471bc7b..e582f5e6691d 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > @@ -269,6 +269,18 @@ pwrap: pwrap@1000d000 {
> > clock-names = "spi", "wrap";
> > };
> >
> > + scp: scp@10500000 {
> > + compatible = "mediatek,mt8183-scp";
> > + reg = <0 0x10500000 0 0x80000>,
> > + <0 0x105c0000 0 0x19080>;
> > + reg-names = "sram", "cfg";
> > + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&infracfg CLK_INFRA_SCPSYS>;
> > + clock-names = "main";
> > + memory-region = <&scp_mem_reserved>;
> > + status = "disabled";
> > + };
> > +
> > systimer: timer@10017000 {
> > compatible = "mediatek,mt8183-timer",
> > "mediatek,mt6765-timer";
> >
full build log,
https://builds.tuxbuild.com/_IfeLhOWMWxIkRkmAtAwOQ/build.log
--
Linaro LKFT
https://lkft.linaro.org
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v21 4/4] arm64: dts: mt8183: add scp node
2020-09-02 14:40 ` Naresh Kamboju
@ 2020-09-02 16:23 ` Krzysztof Kozlowski
2020-09-09 7:37 ` Jon Hunter
2020-09-09 8:26 ` Matthias Brugger
0 siblings, 2 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 16:23 UTC (permalink / raw)
To: Naresh Kamboju
Cc: Matthias Brugger, Eddie Huang, Linux-Next Mailing List,
Pi-Hsun Shih, Erin Lo, Rob Herring, Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support, open list,
Alexandre Courbot, Bjorn Andersson, Anders Roxell, lkft-triage,
Stephen Rothwell
On Wed, 2 Sep 2020 at 16:45, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>
> On Thu, 27 Aug 2020 at 15:44, Matthias Brugger <matthias.bgg@gmail.com> wrote:
> >
> >
> >
> > On 12/11/2019 12:03, Pi-Hsun Shih wrote:
> > > From: Eddie Huang <eddie.huang@mediatek.com>
> > >
> > > Add scp node to mt8183 and mt8183-evb
> > >
> > > Signed-off-by: Erin Lo <erin.lo@mediatek.com>
> > > Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
> > > Signed-off-by: Eddie Huang <eddie.huang@mediatek.com>
> >
> > Sorry I somehow oversaw this. Next time please don't doubt to ping me.
> >
> > Bjorn, do I understand correctly that you don't send emails to the list
> > informing of the inclusion of a patch/series in your tree?
> >
> > Anyway applied now to v5.9-next/dts64 :)
>
> arm64 build dtbs failed on linux next 20200902.
I just hit it as well... I wish the kernel was built after applying
patches... it would make the next a better place.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v21 4/4] arm64: dts: mt8183: add scp node
2020-09-02 16:23 ` Krzysztof Kozlowski
@ 2020-09-09 7:37 ` Jon Hunter
2020-09-09 8:18 ` Pi-Hsun Shih
2020-09-09 8:26 ` Matthias Brugger
1 sibling, 1 reply; 10+ messages in thread
From: Jon Hunter @ 2020-09-09 7:37 UTC (permalink / raw)
To: Krzysztof Kozlowski, Naresh Kamboju, Matthias Brugger,
Eddie Huang
Cc: Linux-Next Mailing List, Pi-Hsun Shih, Erin Lo, Rob Herring,
Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support, open list,
Alexandre Courbot, Bjorn Andersson, Anders Roxell, lkft-triage,
Stephen Rothwell, linux-tegra
On 02/09/2020 17:23, Krzysztof Kozlowski wrote:
> On Wed, 2 Sep 2020 at 16:45, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>>
>> On Thu, 27 Aug 2020 at 15:44, Matthias Brugger <matthias.bgg@gmail.com> wrote:
>>>
>>>
>>>
>>> On 12/11/2019 12:03, Pi-Hsun Shih wrote:
>>>> From: Eddie Huang <eddie.huang@mediatek.com>
>>>>
>>>> Add scp node to mt8183 and mt8183-evb
>>>>
>>>> Signed-off-by: Erin Lo <erin.lo@mediatek.com>
>>>> Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
>>>> Signed-off-by: Eddie Huang <eddie.huang@mediatek.com>
>>>
>>> Sorry I somehow oversaw this. Next time please don't doubt to ping me.
>>>
>>> Bjorn, do I understand correctly that you don't send emails to the list
>>> informing of the inclusion of a patch/series in your tree?
>>>
>>> Anyway applied now to v5.9-next/dts64 :)
>>
>> arm64 build dtbs failed on linux next 20200902.
>
> I just hit it as well... I wish the kernel was built after applying
> patches... it would make the next a better place.
Any update on this? It is still broken as of next-20200908.
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v21 4/4] arm64: dts: mt8183: add scp node
2020-09-09 7:37 ` Jon Hunter
@ 2020-09-09 8:18 ` Pi-Hsun Shih
0 siblings, 0 replies; 10+ messages in thread
From: Pi-Hsun Shih @ 2020-09-09 8:18 UTC (permalink / raw)
To: Jon Hunter
Cc: Krzysztof Kozlowski, Naresh Kamboju, Matthias Brugger,
Eddie Huang, Linux-Next Mailing List, Erin Lo, Rob Herring,
Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support, open list,
Alexandre Courbot, Bjorn Andersson, Anders Roxell, lkft-triage,
Stephen Rothwell, linux-tegra
On Wed, Sep 9, 2020 at 3:37 PM Jon Hunter <jonathanh@nvidia.com> wrote:
>
>
> On 02/09/2020 17:23, Krzysztof Kozlowski wrote:
> > On Wed, 2 Sep 2020 at 16:45, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> >>
> >> On Thu, 27 Aug 2020 at 15:44, Matthias Brugger <matthias.bgg@gmail.com> wrote:
> >>>
> >>>
> >>>
> >>> On 12/11/2019 12:03, Pi-Hsun Shih wrote:
> >>>> From: Eddie Huang <eddie.huang@mediatek.com>
> >>>>
> >>>> Add scp node to mt8183 and mt8183-evb
> >>>>
> >>>> Signed-off-by: Erin Lo <erin.lo@mediatek.com>
> >>>> Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
> >>>> Signed-off-by: Eddie Huang <eddie.huang@mediatek.com>
> >>>
> >>> Sorry I somehow oversaw this. Next time please don't doubt to ping me.
> >>>
> >>> Bjorn, do I understand correctly that you don't send emails to the list
> >>> informing of the inclusion of a patch/series in your tree?
> >>>
> >>> Anyway applied now to v5.9-next/dts64 :)
> >>
> >> arm64 build dtbs failed on linux next 20200902.
> >
> > I just hit it as well... I wish the kernel was built after applying
> > patches... it would make the next a better place.
>
>
> Any update on this? It is still broken as of next-20200908.
>
> Jon
>
I just sent https://lore.kernel.org/patchwork/patch/1303034/ which
should fix this.
The build failure is because another patch for the mt8183-kukui.dtsi
(cd894e274b74 "arm64: dts: mt8183: Add krane-sku176 board") that was
merged after this patch is submitted to list is missing the
scp_mem_reserved field. Sorry for that.
> --
> nvpublic
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v21 4/4] arm64: dts: mt8183: add scp node
2020-09-02 16:23 ` Krzysztof Kozlowski
2020-09-09 7:37 ` Jon Hunter
@ 2020-09-09 8:26 ` Matthias Brugger
1 sibling, 0 replies; 10+ messages in thread
From: Matthias Brugger @ 2020-09-09 8:26 UTC (permalink / raw)
To: Krzysztof Kozlowski, Naresh Kamboju
Cc: Eddie Huang, Linux-Next Mailing List, Pi-Hsun Shih, Erin Lo,
Rob Herring, Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support, open list,
Alexandre Courbot, Bjorn Andersson, Anders Roxell, lkft-triage,
Stephen Rothwell
On 02/09/2020 18:23, Krzysztof Kozlowski wrote:
> On Wed, 2 Sep 2020 at 16:45, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>>
>> On Thu, 27 Aug 2020 at 15:44, Matthias Brugger <matthias.bgg@gmail.com> wrote:
>>>
>>>
>>>
>>> On 12/11/2019 12:03, Pi-Hsun Shih wrote:
>>>> From: Eddie Huang <eddie.huang@mediatek.com>
>>>>
>>>> Add scp node to mt8183 and mt8183-evb
>>>>
>>>> Signed-off-by: Erin Lo <erin.lo@mediatek.com>
>>>> Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
>>>> Signed-off-by: Eddie Huang <eddie.huang@mediatek.com>
>>>
>>> Sorry I somehow oversaw this. Next time please don't doubt to ping me.
>>>
>>> Bjorn, do I understand correctly that you don't send emails to the list
>>> informing of the inclusion of a patch/series in your tree?
>>>
>>> Anyway applied now to v5.9-next/dts64 :)
>>
>> arm64 build dtbs failed on linux next 20200902.
>
Sorry I was on vacation.
> I just hit it as well... I wish the kernel was built after applying
> patches... it would make the next a better place.
>
Right...
I'll remove the patch now until this is fixed. Once again sorry for the trouble.
Regards,
Matthias
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v21 4/4] arm64: dts: mt8183: add scp node
2019-11-12 11:03 ` [PATCH v21 4/4] arm64: dts: mt8183: add scp node Pi-Hsun Shih
2020-08-27 10:14 ` Matthias Brugger
@ 2020-09-10 10:51 ` Matthias Brugger
1 sibling, 0 replies; 10+ messages in thread
From: Matthias Brugger @ 2020-09-10 10:51 UTC (permalink / raw)
To: Pi-Hsun Shih
Cc: Eddie Huang, Erin Lo, Rob Herring, Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support, open list
On 12/11/2019 12:03, Pi-Hsun Shih wrote:
> From: Eddie Huang <eddie.huang@mediatek.com>
>
> Add scp node to mt8183 and mt8183-evb
>
> Signed-off-by: Erin Lo <erin.lo@mediatek.com>
> Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
> Signed-off-by: Eddie Huang <eddie.huang@mediatek.com>
Applied again to v5.9-next/dts64
Thanks!
> ---
> Changes from v20 ... v14:
> - No change.
>
> Changes from v13:
> - Change the size of the cfg register region.
>
> Changes from v12 ... v10:
> - No change.
>
> Changes from v9:
> - Remove extra reserve-memory-vpu_share node.
>
> Changes from v8:
> - New patch.
> ---
> arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 11 +++++++++++
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 12 ++++++++++++
> 2 files changed, 23 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> index 1fb195c683c3..ddb7a7ac9655 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> @@ -24,6 +24,17 @@ memory@40000000 {
> chosen {
> stdout-path = "serial0:921600n8";
> };
> +
> + reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> + scp_mem_reserved: scp_mem_region {
> + compatible = "shared-dma-pool";
> + reg = <0 0x50000000 0 0x2900000>;
> + no-map;
> + };
> + };
> };
>
> &auxadc {
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 10b32471bc7b..e582f5e6691d 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -269,6 +269,18 @@ pwrap: pwrap@1000d000 {
> clock-names = "spi", "wrap";
> };
>
> + scp: scp@10500000 {
> + compatible = "mediatek,mt8183-scp";
> + reg = <0 0x10500000 0 0x80000>,
> + <0 0x105c0000 0 0x19080>;
> + reg-names = "sram", "cfg";
> + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&infracfg CLK_INFRA_SCPSYS>;
> + clock-names = "main";
> + memory-region = <&scp_mem_reserved>;
> + status = "disabled";
> + };
> +
> systimer: timer@10017000 {
> compatible = "mediatek,mt8183-timer",
> "mediatek,mt6765-timer";
>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-09-10 10:54 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-12 11:03 [PATCH v21 0/4] Add support for mt8183 SCP Pi-Hsun Shih
2019-11-12 11:03 ` [PATCH v21 1/4] dt-bindings: Add a binding for Mediatek SCP Pi-Hsun Shih
2019-11-12 11:03 ` [PATCH v21 4/4] arm64: dts: mt8183: add scp node Pi-Hsun Shih
2020-08-27 10:14 ` Matthias Brugger
2020-09-02 14:40 ` Naresh Kamboju
2020-09-02 16:23 ` Krzysztof Kozlowski
2020-09-09 7:37 ` Jon Hunter
2020-09-09 8:18 ` Pi-Hsun Shih
2020-09-09 8:26 ` Matthias Brugger
2020-09-10 10:51 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).