From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Marc Zyngier <maz@kernel.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Shawn Guo <shawnguo@kernel.org>, Li Yang <leoyang.li@nxp.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 2/2] ARM: dts: ls1021a-tsn: Use interrupts for the SGMII PHYs
Date: Tue, 12 Nov 2019 15:01:09 +0100 [thread overview]
Message-ID: <20191112140109.GK5090@lunn.ch> (raw)
In-Reply-To: <CA+h21hpE-Nu_Sh1fRizUoEs082ev=9nzuumSXDrk-QTXdnEbzg@mail.gmail.com>
> > >> + /* SGMII2_PHY_INT_B: connected to IRQ2, active low
> > >> */
> > >> + interrupts-extended = <&extirq 2
> > >> IRQ_TYPE_EDGE_FALLING>;
> The interrupt specifier certainly works. So that points to an issue
> with the description. What do you mean, exactly? Does "active low"
> mean "level-triggered"? How would you have described this?
I would expect IRQ_TYPE_ACTIVE_LOW, or whatever it is called. Since
this is a shared interrupt, going on the edge i think opens up a race
condition and interrupts can be missed.
Andrew
next prev parent reply other threads:[~2019-11-12 14:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 13:20 [PATCH 0/2] ARM: dts: ls1021a: define and use external interrupt lines Rasmus Villemoes
2019-11-12 13:20 ` [PATCH 1/2] ARM: dts: ls1021a: add node describing " Rasmus Villemoes
2019-11-12 13:20 ` [PATCH 2/2] ARM: dts: ls1021a-tsn: Use interrupts for the SGMII PHYs Rasmus Villemoes
2019-11-12 13:44 ` Vladimir Oltean
2019-11-12 13:49 ` Marc Zyngier
2019-11-12 13:53 ` Vladimir Oltean
2019-11-12 14:01 ` Andrew Lunn [this message]
2019-11-12 14:04 ` Marc Zyngier
2019-11-12 14:12 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112140109.GK5090@lunn.ch \
--to=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).