From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marian Mihailescu <mihailescu2m@gmail.com>
Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, kgene@kernel.org
Subject: Re: [PATCH v5] ARM: dts: exynos5420: add mali dt node and enable mali on Odroid XU3/4
Date: Thu, 14 Nov 2019 14:06:43 +0100 [thread overview]
Message-ID: <20191114130643.GB3084@kozik-lap> (raw)
In-Reply-To: <20191114000900.26962-1-mihailescu2m@gmail.com>
On Thu, Nov 14, 2019 at 10:39:00AM +1030, Marian Mihailescu wrote:
> Add device tree node for Mali GPU for Exynos 542x SoC.
> GPU is disabled by default, and is enabled for each board after the
> regulator is defined. Tested on Odroid-XU4.
>
> Signed-off-by: Marian Mihailescu <mihailescu2m@gmail.com>
> ---
>
> Changes since v4:
> - fixed so it applies for latest 5.4-rc7
>
> Changes since v3:
> - fixed compatible to match bindings
>
> Changes since v2:
> - separate patch for bindings
> - fixed bindings typo
>
> Changes since v1:
> - used generic node and label for GPU
> - added bindings for compatible
> - fixed irq indentation
> - fixed interrupt-names to match bindings
> - added cooling cells for future TMU connection
> - used generic node and label for GPU opp table
> - removed always-on from SoC GPU regulator
>
> ---
> arch/arm/boot/dts/exynos5420.dtsi | 50 +++++++++++++++++++++++++++
> arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 6 +++-
> 2 files changed, 55 insertions(+), 1 deletion(-)
Again tried to apply... but it causes new DTS warnings:
arch/arm/boot/dts/exynos5420.dtsi:692.19-695.7: Warning (unit_address_vs_reg): /soc/gpu@11800000/opp-table/opp@177000000: node has a unit name, but no reg property
Send the patches passing checkpatch and not introducing warnings (make
dtbs W=1).
Best regards,
Krzysztof
next prev parent reply other threads:[~2019-11-14 13:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 0:09 [PATCH v5] ARM: dts: exynos5420: add mali dt node and enable mali on Odroid XU3/4 Marian Mihailescu
2019-11-14 13:06 ` Krzysztof Kozlowski [this message]
2019-11-14 23:43 ` Marian Mihailescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114130643.GB3084@kozik-lap \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mihailescu2m@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).