From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6B89C432C3 for ; Thu, 14 Nov 2019 22:31:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9BC25206D6 for ; Thu, 14 Nov 2019 22:31:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573770702; bh=HxBQ9mc5wckd8K8v9pUL0G8SUtIpuD6J7MEoHvOFh5A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=WFJnKUrEvbX122tQCdVhvVY7+Q/t0pSEtAKDCGC1DeWXDETwK60ohDwUl9cwUaLTZ OH5La8nzuSuXJsYXffo/29fDwKUAjfxmOxkiegrEXHcM/OOTan7NLUw75dY6NF9i3f h9IAqAhlObWNHE+EM/hbAoNAR/10t4EWARy+H3Wo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726992AbfKNWbm (ORCPT ); Thu, 14 Nov 2019 17:31:42 -0500 Received: from mail-oi1-f195.google.com ([209.85.167.195]:39451 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726319AbfKNWbl (ORCPT ); Thu, 14 Nov 2019 17:31:41 -0500 Received: by mail-oi1-f195.google.com with SMTP id v138so6844338oif.6; Thu, 14 Nov 2019 14:31:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3aEDSd//CUr7obM8pnwgRvPfaqbSjrz8RXYZcOBaO5o=; b=OxckcMJdG1GQkCy3qGHoCHlusLXfEu2sVxtm6AHt4cFb6Ed9tF4RNEiXkXncnmX5Vf /FgUoMhXCm1tNwDzWGDwJyeiX4KJ+6C70cAaTYWR2SkM18CrsxWSohkehCk0KtKM5eUN PQQWLV/cVrIqtcBjMwxHI9FmgbuglWGDBmKCV04YZhX8Pe9L0P8Ifxf0ytYmw7UVXlym r/iJRvpZxuKKM0ke8AlM9uGa9wbnV4rYwcLuxVVi5xiuaWtvL25BxDlHmUeeSaNJhouz mK4cAi67mA/VxGeFbpyTIKHn9GSDEKVz0k0cDTbfTb0FCjVOoZZ922hFlzJtBc5+d12p DfGA== X-Gm-Message-State: APjAAAVMbwyRgNJXxY7qyQkfGjU5KLxXEmSfYCxn++CqJBeL+1BO0QbV siOgsxHky01HFf8obEXO1YWdaYw= X-Google-Smtp-Source: APXvYqzmC0S3EemtVMsdOmnrb9ciGoy0JBKuBOZVKmRqGidvzvwwtfy146j39IXLhjQXTTFWSqO/Dw== X-Received: by 2002:aca:4a84:: with SMTP id x126mr5293793oia.47.1573770700636; Thu, 14 Nov 2019 14:31:40 -0800 (PST) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id f93sm2246396otb.64.2019.11.14.14.31.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Nov 2019 14:31:39 -0800 (PST) Date: Thu, 14 Nov 2019 16:31:39 -0600 From: Rob Herring To: Matti Vaittinen Cc: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com, Frank Rowand , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] of: property: Fix documentation for out values Message-ID: <20191114223139.GA4161@bogus> References: <20191113064338.GA13274@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191113064338.GA13274@localhost.localdomain> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 13 Nov 2019 08:43:38 +0200, Matti Vaittinen wrote: > Property fetching functions which return number of successfully fetched > properties should not state that out-values are only modified if 0 is > returned. Fix this. Also, "pointer to return value" is slightly suboptimal > phrase as "return value" commonly refers to value function returns (not via > arguments). Rather use "pointer to found values". > > Signed-off-by: Matti Vaittinen > --- > > Changes from v1. Removed statement about modifying arg ptr only upon > successful execution (as requested by Frank). Also changed "pointer to > return value" with "pointer to found values" > > drivers/of/property.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Applied, thanks. Rob