From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Michael Grzeschik <m.grzeschik@pengutronix.de>
Cc: shawnguo@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
kernel@pengutronix.de, festevam@gmail.com,
devicetree@vger.kernel.org, linux-imx@nxp.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ARM: dts: imx25: fix usbhost1 node
Date: Fri, 15 Nov 2019 21:14:09 +0100 [thread overview]
Message-ID: <20191115201409.5ztt7vrhf2btpoed@pengutronix.de> (raw)
In-Reply-To: <20191115083415.28976-1-m.grzeschik@pengutronix.de>
Hello Michael,
On Fri, Nov 15, 2019 at 09:34:15AM +0100, Michael Grzeschik wrote:
> The usb port represented by &usbhost1 uses an USB phy internal to the
> SoC. We add the phy_type to the base dtsi so the board dts only have to
> overwrite it if they use a different configuration. While at it we also
> pin the usbhost port to host mode and limit the speed of the phy to
> full-speed only, which it is only capable of.
The subject line suggests this is a fix but the commit log and the
actual change don't support this. Maybe better:
ARM: dts: imx25: consolidate properties of usbhost1 in dtsi file
?
> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> index 9a097ef014af5..40b95a290bd6b 100644
> --- a/arch/arm/boot/dts/imx25.dtsi
> +++ b/arch/arm/boot/dts/imx25.dtsi
> @@ -570,6 +570,9 @@
> clock-names = "ipg", "ahb", "per";
> fsl,usbmisc = <&usbmisc 1>;
> fsl,usbphy = <&usbphy1>;
> + maximum-speed = "full-speed";
> + phy_type = "serial";
> + dr_mode = "host";
Would it make sense to split this patch in two? One that moves phy_type
and dr_mode from the dts files using imx25.dtsi (which has no effects on
the resulting dtb files). And another that adds maximum-speed.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
next prev parent reply other threads:[~2019-11-15 20:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 11:46 [PATCH] ARM: dts: imx25: fix usbhost1 node Michael Grzeschik
2019-11-14 21:17 ` Uwe Kleine-König
2019-11-15 8:28 ` Michael Grzeschik
2019-11-15 8:34 ` [PATCH v2] " Michael Grzeschik
2019-11-15 20:14 ` Uwe Kleine-König [this message]
2019-11-20 8:29 ` Michael Grzeschik
2019-11-20 21:13 ` [PATCH v3 0/2] ARM: dts: imx25: usbhost port1 improvemts Michael Grzeschik
2019-11-20 21:13 ` [PATCH v3 1/2] ARM: dts: imx25: consolidate properties of usbhost1 in dtsi file Michael Grzeschik
2019-11-20 21:27 ` Fabio Estevam
2019-11-20 21:13 ` [PATCH v3 2/2] ARM: dts: imx25: describe maximum speed of internal usbhost port1 phy Michael Grzeschik
2019-11-20 21:28 ` Fabio Estevam
2019-12-04 12:22 ` [PATCH v3 0/2] ARM: dts: imx25: usbhost port1 improvemts Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115201409.5ztt7vrhf2btpoed@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).