From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DF9CC432C3 for ; Fri, 15 Nov 2019 20:14:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A48C206D9 for ; Fri, 15 Nov 2019 20:14:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726869AbfKOUOP (ORCPT ); Fri, 15 Nov 2019 15:14:15 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:45337 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726786AbfKOUOP (ORCPT ); Fri, 15 Nov 2019 15:14:15 -0500 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iVhys-0000VS-Rp; Fri, 15 Nov 2019 21:14:10 +0100 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1iVhyr-0000NS-RY; Fri, 15 Nov 2019 21:14:09 +0100 Date: Fri, 15 Nov 2019 21:14:09 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Michael Grzeschik Cc: shawnguo@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, kernel@pengutronix.de, festevam@gmail.com, devicetree@vger.kernel.org, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ARM: dts: imx25: fix usbhost1 node Message-ID: <20191115201409.5ztt7vrhf2btpoed@pengutronix.de> References: <20191111114655.9583-1-m.grzeschik@pengutronix.de> <20191115083415.28976-1-m.grzeschik@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191115083415.28976-1-m.grzeschik@pengutronix.de> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello Michael, On Fri, Nov 15, 2019 at 09:34:15AM +0100, Michael Grzeschik wrote: > The usb port represented by &usbhost1 uses an USB phy internal to the > SoC. We add the phy_type to the base dtsi so the board dts only have to > overwrite it if they use a different configuration. While at it we also > pin the usbhost port to host mode and limit the speed of the phy to > full-speed only, which it is only capable of. The subject line suggests this is a fix but the commit log and the actual change don't support this. Maybe better: ARM: dts: imx25: consolidate properties of usbhost1 in dtsi file ? > diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi > index 9a097ef014af5..40b95a290bd6b 100644 > --- a/arch/arm/boot/dts/imx25.dtsi > +++ b/arch/arm/boot/dts/imx25.dtsi > @@ -570,6 +570,9 @@ > clock-names = "ipg", "ahb", "per"; > fsl,usbmisc = <&usbmisc 1>; > fsl,usbphy = <&usbphy1>; > + maximum-speed = "full-speed"; > + phy_type = "serial"; > + dr_mode = "host"; Would it make sense to split this patch in two? One that moves phy_type and dr_mode from the dts files using imx25.dtsi (which has no effects on the resulting dtb files). And another that adds maximum-speed. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |