From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58232C432C3 for ; Mon, 18 Nov 2019 09:38:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2EE9B20740 for ; Mon, 18 Nov 2019 09:38:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pDq8S9eB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726708AbfKRJhq (ORCPT ); Mon, 18 Nov 2019 04:37:46 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:46119 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726579AbfKRJhq (ORCPT ); Mon, 18 Nov 2019 04:37:46 -0500 Received: by mail-wr1-f65.google.com with SMTP id b3so18548277wrs.13; Mon, 18 Nov 2019 01:37:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nFDrmtiB5h/Zr80zbuCGUX75SrtWuuQxETq8orGACdo=; b=pDq8S9eBLG5YpdtCLceYlK8zJHKySSMJ4gNa4obO5RzmF65RlwU73LgN2+V4Akd/r8 9nt+gRe5Lyaf5Zd85j/GTuEWkunkx8qc/Ppg40CeYy0cLTS9YNVDCBEPuzJ7XuyEGrCJ R3hNBjDFh+Npn16HM/wTRfCR+MctwUgZOeLT+OWYuxlKivqnO5CHZvnqjna3UEL3Mg2V 01+51+jKT2PN8x4dsQfCMCTqQBMFJuD6xT/7qUiK64KxeMGeyUuPaXD3IvQnPhXMxLQM pZ9lOuez7rvmJiubMR/HPxaZSo7Os6ftlqaOZ9vsV6FtgOpNQqTGKGPywa4EQev/u/6s q6Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nFDrmtiB5h/Zr80zbuCGUX75SrtWuuQxETq8orGACdo=; b=GxQAE9c5e5BEanB7dy7vUvoGWmPXtj1nCu95Fvh/Iwhbe2rRQm6csDGLw3XmxH1L3i T+2Jp918ha58FXyDE65YId2WOmLCgRBHjeGrOtttV8qxeAO3Hvo5YT2/euShIhShV/fr GjhIFWAp7RDxlJIUMTJ5NV3zWOpQ+7+3NEoZqE3qIfd6vleHg8CxeZ/Vqp4YkbTJeCeo i6gpJjusC1RK0DXOppiEHbXSNZe04RxRsPcSetW8I4SYAHC/TPlk2iWYB1bwnLb58bbu WFiv+bDqB5a+kI7VGaxXVQHF5Mnj6kodVuUumxmowPtyhwDfuBTHlWKyfOP85Vn+yoai yPOw== X-Gm-Message-State: APjAAAU7k8drbMjrJvjvJQ9hLRFM2/ndSMtlJJSRxShZPxzSsYrWtYW0 FQTxOAyTSziK+pgOmBIZPtg= X-Google-Smtp-Source: APXvYqxrEmLi5UBnckJcDzEtZ/GOtx6jGsQIN4D2M+GIJGDkkHT82C2NdqHccLyS9r8AyPBugiVUwg== X-Received: by 2002:a5d:6585:: with SMTP id q5mr25423114wru.158.1574069863961; Mon, 18 Nov 2019 01:37:43 -0800 (PST) Received: from clement-Latitude-7490.outsight.local (lputeaux-656-1-11-33.w82-127.abo.wanadoo.fr. [82.127.142.33]) by smtp.gmail.com with ESMTPSA id w10sm19006687wmd.26.2019.11.18.01.37.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2019 01:37:43 -0800 (PST) From: =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= To: Thierry Reding , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai , Philipp Zabel Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Jernej Skrabec , =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= Subject: [PATCH v5 2/8] pwm: sun4i: Add an optional probe for reset line Date: Mon, 18 Nov 2019 10:37:21 +0100 Message-Id: <20191118093727.21899-3-peron.clem@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191118093727.21899-1-peron.clem@gmail.com> References: <20191118093727.21899-1-peron.clem@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org From: Jernej Skrabec H6 PWM core needs deasserted reset line in order to work. Add an optional probe for it. Signed-off-by: Jernej Skrabec Reviewed-by: Uwe Kleine-König Signed-off-by: Clément Péron --- drivers/pwm/pwm-sun4i.c | 33 +++++++++++++++++++++++++++++++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c index 581d23287333..c17935805690 100644 --- a/drivers/pwm/pwm-sun4i.c +++ b/drivers/pwm/pwm-sun4i.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include #include @@ -78,6 +79,7 @@ struct sun4i_pwm_data { struct sun4i_pwm_chip { struct pwm_chip chip; struct clk *clk; + struct reset_control *rst; void __iomem *base; spinlock_t ctrl_lock; const struct sun4i_pwm_data *data; @@ -364,6 +366,21 @@ static int sun4i_pwm_probe(struct platform_device *pdev) if (IS_ERR(pwm->clk)) return PTR_ERR(pwm->clk); + pwm->rst = devm_reset_control_get_optional_shared(&pdev->dev, NULL); + if (IS_ERR(pwm->rst)) { + if (PTR_ERR(pwm->rst) != -EPROBE_DEFER) + dev_err(&pdev->dev, "get reset failed %pe\n", + pwm->rst); + return PTR_ERR(pwm->rst); + } + + /* Deassert reset */ + ret = reset_control_deassert(pwm->rst); + if (ret) { + dev_err(&pdev->dev, "Cannot deassert reset control\n"); + return ret; + } + pwm->chip.dev = &pdev->dev; pwm->chip.ops = &sun4i_pwm_ops; pwm->chip.base = -1; @@ -376,19 +393,31 @@ static int sun4i_pwm_probe(struct platform_device *pdev) ret = pwmchip_add(&pwm->chip); if (ret < 0) { dev_err(&pdev->dev, "failed to add PWM chip: %d\n", ret); - return ret; + goto err_pwm_add; } platform_set_drvdata(pdev, pwm); return 0; + +err_pwm_add: + reset_control_assert(pwm->rst); + + return ret; } static int sun4i_pwm_remove(struct platform_device *pdev) { struct sun4i_pwm_chip *pwm = platform_get_drvdata(pdev); + int ret; + + ret = pwmchip_remove(&pwm->chip); + if (ret) + return ret; + + reset_control_assert(pwm->rst); - return pwmchip_remove(&pwm->chip); + return 0; } static struct platform_driver sun4i_pwm_driver = { -- 2.20.1