Re: [PATCH 1/2] bindings: sound: pcm3168a: Document optional RST gpio

Rob Herring
2019-11-18T21:33:00Z

On Wed, Nov 13, 2019 at 02:47:33PM +0200, Peter Ujfalusi wrote:
> On boards where the RST line is not pulled up, but it is connected to a
> GPIO line this property must present in order to be able to enable the
> codec.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> Documentation/devicetree/bindings/sound/ti,pcm3168a.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/ti,pcm3168a.txt b/Documentation/devicetree/bindings/sound/ti,pcm3168a.txt
> index 5d9cb84c661d..f30aebc7603a 100644
> --- a/Documentation/devicetree/bindings/sound/ti,pcm3168a.txt
> +++ b/Documentation/devicetree/bindings/sound/ti,pcm3168a.txt
> @@ -25,6 +25,12 @@ Required properties:
>
> For required properties on SPI/I2C, consult SPI/I2C device tree documentation
>
> +Optional properties:
> +
> + - rst-gpios : Optional RST gpio line for the codec
> + RST = low: device power-down
> + RST = high: device is enabled

'reset-gpios' is the standard naming for reset lines.

> +
> Examples:
>
> i2c0: i2c0@0 {
> @@ -34,6 +40,7 @@ i2c0: i2c0@0 {
> pcm3168a: audio-codec@44 {
> compatible = "ti,pcm3168a";
> reg = <0x44>;
> + rst-gpios = <&gpio0 4 GPIO_ACTIVE_HIGH>;
> clocks = <&clk_core CLK_AUDIO>;
> clock-names = "scki";
> VDD1-supply = <&supply3v3>;
> --
> Peter
>
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>