From: Rob Herring <robh@kernel.org>
To: Rajan Vaja <rajan.vaja@xilinx.com>
Cc: sre@kernel.org, mark.rutland@arm.com, michal.simek@xilinx.com,
jollys@xilinx.com, tejas.patel@xilinx.com,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: power: reset: xilinx: Add bindings for ipi mailbox
Date: Mon, 18 Nov 2019 11:35:20 -0600 [thread overview]
Message-ID: <20191118173520.GA23767@bogus> (raw)
In-Reply-To: <1573564851-9275-2-git-send-email-rajan.vaja@xilinx.com>
On Tue, Nov 12, 2019 at 05:20:50AM -0800, Rajan Vaja wrote:
> Add IPI mailbox property and its example in xilinx zynqmp-power
> documentation.
>
> Signed-off-by: Rajan Vaja <rajan.vaja@xilinx.com>
> ---
> .../bindings/power/reset/xlnx,zynqmp-power.txt | 41 ++++++++++++++++++++--
> 1 file changed, 38 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/power/reset/xlnx,zynqmp-power.txt b/Documentation/devicetree/bindings/power/reset/xlnx,zynqmp-power.txt
> index d366f1e..450f3a4 100644
> --- a/Documentation/devicetree/bindings/power/reset/xlnx,zynqmp-power.txt
> +++ b/Documentation/devicetree/bindings/power/reset/xlnx,zynqmp-power.txt
> @@ -8,9 +8,27 @@ Required properties:
> - compatible: Must contain: "xlnx,zynqmp-power"
> - interrupts: Interrupt specifier
>
> --------
> -Example
> --------
> +Optional properties:
> + - mbox-names : Name given to channels seen in the 'mboxes' property.
> + "rx" - Mailbox corresponding to receive path
> + "tx" - Mailbox corresponding to transmit path
The order here doesn't match the example. The order should be defined.
> + - mboxes : Standard property to specify a Mailbox. Each value of
> + the mboxes property should contain a phandle to the
> + mailbox controller device node and an args specifier
> + that will be the phandle to the intended sub-mailbox
> + child node to be used for communication. See
> + Documentation/devicetree/bindings/mailbox/mailbox.txt
> + for more details about the generic mailbox controller
> + and client driver bindings. Also see
> + Documentation/devicetree/bindings/mailbox/ \
> + xlnx,zynqmp-ipi-mailbox.txt for typical controller that
> + is used to communicate with this System controllers.
> +
> +--------
> +Examples
> +--------
> +
> +Example with interrupt method:
>
> firmware {
> zynqmp_firmware: zynqmp-firmware {
> @@ -23,3 +41,20 @@ firmware {
> };
> };
> };
> +
> +Example with IPI mailbox method:
> +
> +firmware {
> +
> + zynqmp_firmware: zynqmp-firmware {
> + compatible = "xlnx,zynqmp-firmware";
> + method = "smc";
> +
> + zynqmp_power: zynqmp-power {
> + compatible = "xlnx,zynqmp-power";
> + mboxes = <&ipi_mailbox_pmu0 0>,
> + <&ipi_mailbox_pmu0 1>;
> + mbox-names = "tx", "rx";
interrupts is required.
> + };
> + };
> +};
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-11-18 17:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 13:20 [PATCH 0/2] drivers: soc: xilinx: Add support for init suspend Rajan Vaja
2019-11-12 13:20 ` [PATCH 1/2] dt-bindings: power: reset: xilinx: Add bindings for ipi mailbox Rajan Vaja
2019-11-18 17:35 ` Rob Herring [this message]
2019-11-12 13:20 ` [PATCH 2/2] drivers: soc: xilinx: Use mailbox IPI callback Rajan Vaja
2019-11-22 8:44 ` [PATCH v2 0/2] drivers: soc: xilinx: Add support for init suspend Rajan Vaja
2019-11-22 8:44 ` [PATCH v2 1/2] dt-bindings: power: reset: xilinx: Add bindings for ipi mailbox Rajan Vaja
2019-11-22 8:44 ` [PATCH v2 2/2] drivers: soc: xilinx: Use mailbox IPI callback Rajan Vaja
2019-12-02 10:38 ` [PATCH v3 0/2] drivers: soc: xilinx: Add support for init suspend Rajan Vaja
2019-12-02 10:38 ` [PATCH v3 1/2] dt-bindings: power: reset: xilinx: Add bindings for ipi mailbox Rajan Vaja
2019-12-13 22:29 ` Rob Herring
2019-12-02 10:38 ` [PATCH v3 2/2] drivers: soc: xilinx: Use mailbox IPI callback Rajan Vaja
2019-12-17 13:40 ` [PATCH v3 0/2] drivers: soc: xilinx: Add support for init suspend Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118173520.GA23767@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jollys@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=rajan.vaja@xilinx.com \
--cc=sre@kernel.org \
--cc=tejas.patel@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).