From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CF41C43215 for ; Mon, 25 Nov 2019 01:33:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D0D89207DD for ; Mon, 25 Nov 2019 01:33:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574645593; bh=aHpsAgdjSsrOg3rfp8+01pOTc2dY01+7ldqLq4i00CE=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=TO+cRdF2wpq9y0pW196wIuOoJviaMNIGgugmIsBlpv0FWqxPWSn15j/O/Yh18px7L qyjEL3ubKItQy/NHGd0k6OQQxFQuXRtuSkPswmOG9k7rbOQLLdV01ZqwEz7qf+2pMi HwKu6lYZc7br/Rti70yWXdlXqXeI2Pr7e7ZRg0JI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727110AbfKYBdN (ORCPT ); Sun, 24 Nov 2019 20:33:13 -0500 Received: from mail.kernel.org ([198.145.29.99]:55986 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727072AbfKYBdN (ORCPT ); Sun, 24 Nov 2019 20:33:13 -0500 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ACC2E2071A; Mon, 25 Nov 2019 01:33:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574645592; bh=aHpsAgdjSsrOg3rfp8+01pOTc2dY01+7ldqLq4i00CE=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=D8PBOxbCRzzQhyZbLmVoTvPRZ7rw8j+3TLcwyseOPwsesl4rL6dOwuJT+FAdTYbqe jwMiElG4yu5Dho9tcm01+RCWozxPy45if3LATu3fdRZR6Z9F7andgjD750MThY+Fy8 IDmVsaMVkzBLzbSjyaJbQQ1qV+LaiDgkY63NqcYs= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20191025111338.27324-1-chunyan.zhang@unisoc.com> <20191025111338.27324-6-chunyan.zhang@unisoc.com> <20191113221952.AD925206E3@mail.kernel.org> Subject: Re: [PATCH 5/5] clk: sprd: add clocks support for SC9863A From: Stephen Boyd Cc: Chunyan Zhang , Mark Rutland , Michael Turquette , Rob Herring , linux-clk , DTML , Linux Kernel Mailing List , Orson Zhai , Baolin Wang To: Chunyan Zhang User-Agent: alot/0.8.1 Date: Sun, 24 Nov 2019 17:33:11 -0800 Message-Id: <20191125013312.ACC2E2071A@mail.kernel.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Quoting Chunyan Zhang (2019-11-17 03:27:15) >=20 > Not sure if I understand correctly - do you mean that switch to use a > reference to clk_parent_data.hw in the driver instead? > like: > https://elixir.bootlin.com/linux/v5.4-rc7/source/drivers/clk/qcom/gcc-sm8= 150.c#L136 >=20 Yes something like that. > Since if I have to define many clk_parent_data.fw_name strings > instead, it seems not able to reduce the code size, right? Ideally there are some internal only clks that can be linked to their parent with a single clk_hw pointer. That will hopefully keep the size down somewhat. And if there are any external clks, they can be described in DT and then only the .fw_name field can be used and the fallback field .name can be left assigned to NULL.