From: Christoph Hellwig <hch@infradead.org>
To: Haren Myneni <haren@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org,
mpe@ellerman.id.au, npiggin@gmail.com, mikey@neuling.org,
herbert@gondor.apana.org.au, sukadev@linux.vnet.ibm.com
Subject: Re: [PATCH 03/14] powerpc/vas: Define nx_fault_stamp in coprocessor_request_block
Date: Wed, 27 Nov 2019 00:30:55 -0800 [thread overview]
Message-ID: <20191127083055.GB17097@infradead.org> (raw)
In-Reply-To: <1574816676.13250.8.camel@hbabu-laptop>
> +#define crb_csb_addr(c) __be64_to_cpu(c->csb_addr)
> +#define crb_nx_fault_addr(c) __be64_to_cpu(c->stamp.nx.fault_storage_addr)
> +#define crb_nx_flags(c) c->stamp.nx.flags
> +#define crb_nx_fault_status(c) c->stamp.nx.fault_status
Except for crb_nx_fault_addr all these macros are unused, and
crb_nx_fault_addr probably makes more sense open coded in the only
caller.
Also please don't use the __ prefixed byte swap helpers in any driver
or arch code.
> +
> +static inline uint32_t crb_nx_pswid(struct coprocessor_request_block *crb)
> +{
> + return __be32_to_cpu(crb->stamp.nx.pswid);
> +}
Same here. Also not sure what the point of the helper is except for
obsfucating the code.
prev parent reply other threads:[~2019-11-27 8:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 1:04 [PATCH 03/14] powerpc/vas: Define nx_fault_stamp in coprocessor_request_block Haren Myneni
2019-11-27 8:30 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127083055.GB17097@infradead.org \
--to=hch@infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=haren@linux.vnet.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).