From: Christoph Hellwig <hch@infradead.org>
To: Haren Myneni <haren@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org,
mpe@ellerman.id.au, npiggin@gmail.com, mikey@neuling.org,
herbert@gondor.apana.org.au, sukadev@linux.vnet.ibm.com
Subject: Re: [PATCH 04/14] powerpc/vas: Setup IRQ mapping and register port for each window
Date: Wed, 27 Nov 2019 00:33:19 -0800 [thread overview]
Message-ID: <20191127083319.GC17097@infradead.org> (raw)
In-Reply-To: <1574816731.13250.9.camel@hbabu-laptop>
> +static irqreturn_t vas_irq_handler(int virq, void *data)
> +{
> + struct vas_instance *vinst = data;
> +
> + pr_devel("VAS %d: virq %d\n", vinst->vas_id, virq);
> +
> + return IRQ_HANDLED;
> +}
An empty interrupt handler is rather pointless. It later grows code,
but adding it without that is a bad idea. Please squash the patches
into sesible chunks.
next prev parent reply other threads:[~2019-11-27 8:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 1:05 [PATCH 04/14] powerpc/vas: Setup IRQ mapping and register port for each window Haren Myneni
2019-11-27 8:33 ` Christoph Hellwig [this message]
2019-12-18 7:18 ` Oliver O'Halloran
2019-12-18 23:13 ` Haren Myneni
2019-12-19 22:31 ` Haren Myneni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127083319.GC17097@infradead.org \
--to=hch@infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=haren@linux.vnet.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).