From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E16EBC432C0 for ; Tue, 3 Dec 2019 10:11:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2534206DF for ; Tue, 3 Dec 2019 10:11:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725954AbfLCKL5 (ORCPT ); Tue, 3 Dec 2019 05:11:57 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:54374 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725773AbfLCKL5 (ORCPT ); Tue, 3 Dec 2019 05:11:57 -0500 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 8E33F28D3AF; Tue, 3 Dec 2019 10:11:54 +0000 (GMT) Date: Tue, 3 Dec 2019 11:11:51 +0100 From: Boris Brezillon To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Lucas Stach , Chris Healy , Andrey Smirnov , Nikita Yushchenko , kernel@collabora.com, Daniel Vetter , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Thierry Reding , Sam Ravnborg , Philipp Zabel , Rob Clark , Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Rob Herring , Mark Rutland , devicetree@vger.kernel.org Subject: Re: [PATCH v3 12/21] drm/bridge: Add an ->atomic_check() hook Message-ID: <20191203111151.28d86f53@collabora.com> In-Reply-To: <20191202170336.GP4929@pendragon.ideasonboard.com> References: <20191023154512.9762-1-boris.brezillon@collabora.com> <20191023154512.9762-13-boris.brezillon@collabora.com> <20191202170336.GP4929@pendragon.ideasonboard.com> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 2 Dec 2019 19:03:36 +0200 Laurent Pinchart wrote: > > + /** > > + * @atomic_check: > > + * > > + * This method is responsible for checking bridge state correctness. > > + * It can also check the state of the surrounding components in chain > > + * to make sure the whole pipeline can work properly. > > As explained in the review of the RFC, I think it's a mistake not to > define the semantics of this operation precisely, and in particular not > to define explictly what parameters bridge drivers are allowed to modify > here. I however don't want to make this a prerequisite for your series, > so > > Reviewed-by: Laurent Pinchart > > but I'm sure we'll regret this later when different bridges will have > slightly incompatible implementations. Nothing prevents us from working on this clarification after the patch series has been merged. I just said I couldn't come up with a good set of rules on my own, as I don't really know what bridge->mode_fixup() allows us to modify in the first place.