From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93B28C43603 for ; Wed, 4 Dec 2019 17:36:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6FCF920674 for ; Wed, 4 Dec 2019 17:36:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727828AbfLDRgv convert rfc822-to-8bit (ORCPT ); Wed, 4 Dec 2019 12:36:51 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:45531 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727033AbfLDRgv (ORCPT ); Wed, 4 Dec 2019 12:36:51 -0500 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id A618F240002; Wed, 4 Dec 2019 17:36:47 +0000 (UTC) Date: Wed, 4 Dec 2019 18:36:46 +0100 From: Miquel Raynal To: Heiko =?UTF-8?B?U3TDvGJuZXI=?= Cc: linux-rockchip@lists.infradead.org, Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: dts: rockchip: Move xin32k fixed-clock out of PX30 DTSI Message-ID: <20191204183646.2f7f6e7f@xps13> In-Reply-To: <2665233.YyXs6BPQ7y@diego> References: <20191204171537.14163-1-miquel.raynal@bootlin.com> <2665233.YyXs6BPQ7y@diego> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Heiko, Heiko Stübner wrote on Wed, 04 Dec 2019 18:31:46 +0100: > Hi Miquel, > > Am Mittwoch, 4. Dezember 2019, 18:15:37 CET schrieb Miquel Raynal: > > This clock has nothing to do in the PX30 DTSI as it is supposed to be > > an input of the SoC. Moving it to the EVB DTS (only board file using > > this DTSI) makes more sense. Also, when this clock is not a fixed > > clock and comes from eg. a PMIC the situation can be described cleanly > > in the device tree (avoids having to delete the fixed-clock node > > first). > > > > This clock is not mandatory to boot so it should not break existing > > users. > > > > Signed-off-by: Miquel Raynal > > Sorry foo being the bearer of bad news again, but that issue got already > fixed by: He he, no problem :) I was not actually looking at the right branch (v5.5-armsoc/dts64). > arm64: dts: rockchip: remove static xin32k from px30 > https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v5.5-armsoc/dts64&id=00519137f7d4fc19ff27f3d3f4fc45b5b222ae82 > > arm64: dts: rockchip: fix the px30-evb power tree > https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v5.5-armsoc/dts64&id=915b6a8b54a6d436885a458867e59fb20fc6356d > > > On most/all Rockchip the xin32k clock is actually provided by the boards > pmic - the rk809 in this case. Thanks for the confirmation! Miquèl