From: Shawn Guo <shawnguo@kernel.org>
To: Michael Walle <michael@walle.cc>, Alison Wang <alison.wang@nxp.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Li Yang <leoyang.li@nxp.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH] arm64: dts: ls1028a: put SAIs into async mode
Date: Mon, 9 Dec 2019 17:08:42 +0800 [thread overview]
Message-ID: <20191209090840.GL3365@dragon> (raw)
In-Reply-To: <20191129210937.26808-1-michael@walle.cc>
+ Alison Wang
On Fri, Nov 29, 2019 at 10:09:37PM +0100, Michael Walle wrote:
> The LS1028A SoC has only unidirectional SAIs. Therefore, it doesn't make
> sense to have the RX and TX part synchronous. Even worse, the RX part
> wont work out of the box because by default it is configured as
> synchronous to the TX part. And as said before, the pinmux of the SoC
> can only be configured to route either the RX or the TX signals to the
> SAI but never both at the same time. Thus configure the asynchronous
> mode by default.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
Alison, Leo,
Looks good to you?
Shawn
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 379913756e90..9be33426e5ce 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -637,6 +637,7 @@
> dma-names = "tx", "rx";
> dmas = <&edma0 1 4>,
> <&edma0 1 3>;
> + fsl,sai-asynchronous;
> status = "disabled";
> };
>
> @@ -651,6 +652,7 @@
> dma-names = "tx", "rx";
> dmas = <&edma0 1 6>,
> <&edma0 1 5>;
> + fsl,sai-asynchronous;
> status = "disabled";
> };
>
> @@ -665,6 +667,7 @@
> dma-names = "tx", "rx";
> dmas = <&edma0 1 8>,
> <&edma0 1 7>;
> + fsl,sai-asynchronous;
> status = "disabled";
> };
>
> @@ -679,6 +682,7 @@
> dma-names = "tx", "rx";
> dmas = <&edma0 1 10>,
> <&edma0 1 9>;
> + fsl,sai-asynchronous;
> status = "disabled";
> };
>
> @@ -693,6 +697,7 @@
> dma-names = "tx", "rx";
> dmas = <&edma0 1 12>,
> <&edma0 1 11>;
> + fsl,sai-asynchronous;
> status = "disabled";
> };
>
> @@ -707,6 +712,7 @@
> dma-names = "tx", "rx";
> dmas = <&edma0 1 14>,
> <&edma0 1 13>;
> + fsl,sai-asynchronous;
> status = "disabled";
> };
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-12-09 9:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 21:09 [PATCH] arm64: dts: ls1028a: put SAIs into async mode Michael Walle
2019-12-09 9:08 ` Shawn Guo [this message]
2019-12-10 5:35 ` [EXT] " Alison Wang
2019-12-10 8:46 ` Michael Walle
2019-12-10 9:13 ` Alison Wang
2019-12-11 9:20 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209090840.GL3365@dragon \
--to=shawnguo@kernel.org \
--cc=alison.wang@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michael@walle.cc \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).