From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8E1FC2D0BF for ; Tue, 10 Dec 2019 18:55:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 80FBA214AF for ; Tue, 10 Dec 2019 18:55:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N6OcGoP2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727647AbfLJSze (ORCPT ); Tue, 10 Dec 2019 13:55:34 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:37356 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727777AbfLJSzb (ORCPT ); Tue, 10 Dec 2019 13:55:31 -0500 Received: by mail-wm1-f67.google.com with SMTP id f129so4413501wmf.2; Tue, 10 Dec 2019 10:55:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RMN6HasSUrZjdtLofZk55AQ4vWrDosUhaoGmITPUruw=; b=N6OcGoP2//bOSKN/C0LkpKHYEx2GCJWt/G7nnQxkK5nBgqLkCPfGnYoc8x0wN5EF72 AIamhHDO9meWhDiSzAVBn2LrVkJTRLaOGzggXQAnEuRNlUzqoCFC0TNmWZl08vnQCoas wObGE4wqtbw1mj69aeB8Sa9cLDX6k1LfX+4aXdQAMYVUFRTPdAGld2Msx0pbr4orQ8Fq 4l27QWvtciXYq7rbFWOUfG3orjyIbycWidiIZEYzG6JWLPJcDTCfzDtvEcV6y4mjdYR4 ySodLRRV1D9rleVYfzlsYxGwU8FTevKfnKQWYf/v+L2iWNuR4Sj83ewPsN9PaSgo6Ul+ 9Vbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RMN6HasSUrZjdtLofZk55AQ4vWrDosUhaoGmITPUruw=; b=Ik3w5CHsLVtGqp04TSkVvgaFB/xanl+9w5QZzrqJixZOeYznevfoh/OgxoPWhJklY9 Y6454R6wnBs9czSGJhB/GiJD6FtlSszfHDarPdI9WBfrRYyJZLabk5nZqoDTtlE/V9pM VEvzXaEdJ2buYN24UhcoKCI5T3ddgbosbKvFmynZS48o+3FVI54hgMlhQbY6pjo21g0b ZleKflNh/R8EpM1cstq5rRkcjgdl3A8b7sULdZxizNorwyxtLV2yFB33tfA2uBvoQ0bR ogwPoXZaVs8dmk3m2XIFcKD1P/LTFmiFylfaUk8eOgnPfJTHJxfPH+A6y4UXOl5Mq24g ylJA== X-Gm-Message-State: APjAAAWcCuIBT6IJkJyHvR6IQDDUzKLNJrxxIhTKPBELiRQUOfe7rS1p khNlJpfU5rfp9EmmW0k2aVdMT065 X-Google-Smtp-Source: APXvYqwvZzO8JHumxzd0awYSiQe8a+UtB87swX6SrfJGACOtIOliudtPwPNlG5qFoIdU2iNZotugcA== X-Received: by 2002:a7b:c947:: with SMTP id i7mr7027735wml.71.1576004128685; Tue, 10 Dec 2019 10:55:28 -0800 (PST) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id e6sm4213536wru.44.2019.12.10.10.55.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2019 10:55:28 -0800 (PST) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: bcm-kernel-feedback-list@broadcom.com, Florian Fainelli , Jens Axboe , Rob Herring , Mark Rutland , Hans de Goede , Philipp Zabel , Tejun Heo , Jaedon Shin , linux-ide@vger.kernel.org (open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Subject: [PATCH 6/8] ata: ahci_brcm: Add a shutdown callback Date: Tue, 10 Dec 2019 10:53:49 -0800 Message-Id: <20191210185351.14825-7-f.fainelli@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191210185351.14825-1-f.fainelli@gmail.com> References: <20191210185351.14825-1-f.fainelli@gmail.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Make sure that we quiesce the controller and shut down the clocks in a shutdown callback. Signed-off-by: Florian Fainelli --- drivers/ata/ahci_brcm.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/ata/ahci_brcm.c b/drivers/ata/ahci_brcm.c index 76612577a59a..58e1a6e5478d 100644 --- a/drivers/ata/ahci_brcm.c +++ b/drivers/ata/ahci_brcm.c @@ -532,11 +532,26 @@ static int brcm_ahci_remove(struct platform_device *pdev) return 0; } +static void brcm_ahci_shutdown(struct platform_device *pdev) +{ + int ret; + + /* All resources releasing happens via devres, but our device, unlike a + * proper remove is not disappearing, therefore using + * brcm_ahci_suspend() here which does explicit power management is + * appropriate. + */ + ret = brcm_ahci_suspend(&pdev->dev); + if (ret) + dev_err(&pdev->dev, "failed to shutdown\n"); +} + static SIMPLE_DEV_PM_OPS(ahci_brcm_pm_ops, brcm_ahci_suspend, brcm_ahci_resume); static struct platform_driver brcm_ahci_driver = { .probe = brcm_ahci_probe, .remove = brcm_ahci_remove, + .shutdown = brcm_ahci_shutdown, .driver = { .name = DRV_NAME, .of_match_table = ahci_of_match, -- 2.17.1