* [PATCH 1/2] arm64: dts: sc7180: Fix indentation/ordering of qspi nodes in sc7180-idp
@ 2019-12-11 0:35 Douglas Anderson
2019-12-11 0:35 ` [PATCH 2/2] arm64: dts: sc7180: Add a comment to i2c7 about external pullup Douglas Anderson
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Douglas Anderson @ 2019-12-11 0:35 UTC (permalink / raw)
To: Bjorn Andersson, Andy Gross
Cc: mka, Roja Rani Yarubandi, Rajendra Nayak, Stephen Boyd,
Douglas Anderson, linux-arm-msm, linux-kernel, devicetree,
Rob Herring, Mark Rutland
The qspi pinctrl nodes had the wrong intentation and sort ordering and
the main qspi node was placed down in the pinctrl section. Fix.
Fixes: ba3fc6496366 ("arm64: dts: sc7180: Add qupv3_0 and qupv3_1")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
arch/arm64/boot/dts/qcom/sc7180-idp.dts | 73 +++++++++++++------------
1 file changed, 37 insertions(+), 36 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
index 189254f5ae95..5eab3a282eba 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
@@ -232,6 +232,20 @@ vreg_bob: bob {
};
};
+&qspi {
+ status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <&qspi_clk &qspi_cs0 &qspi_data01>;
+
+ flash@0 {
+ compatible = "jedec,spi-nor";
+ reg = <0>;
+ spi-max-frequency = <25000000>;
+ spi-tx-bus-width = <2>;
+ spi-rx-bus-width = <2>;
+ };
+};
+
&qupv3_id_0 {
status = "okay";
};
@@ -250,6 +264,29 @@ &uart8 {
/* PINCTRL - additions to nodes defined in sc7180.dtsi */
+&qspi_clk {
+ pinconf {
+ pins = "gpio63";
+ bias-disable;
+ };
+};
+
+&qspi_cs0 {
+ pinconf {
+ pins = "gpio68";
+ bias-disable;
+ };
+};
+
+&qspi_data01 {
+ pinconf {
+ pins = "gpio64", "gpio65";
+
+ /* High-Z when no transfers; nice to park the lines */
+ bias-pull-up;
+ };
+};
+
&qup_i2c2_default {
pinconf {
pins = "gpio15", "gpio16";
@@ -364,39 +401,3 @@ pinconf {
};
};
-&qspi {
- status = "okay";
- pinctrl-names = "default";
- pinctrl-0 = <&qspi_clk &qspi_cs0 &qspi_data01>;
-
- flash@0 {
- compatible = "jedec,spi-nor";
- reg = <0>;
- spi-max-frequency = <25000000>;
- spi-tx-bus-width = <2>;
- spi-rx-bus-width = <2>;
- };
-};
-
-&qspi_cs0 {
- pinconf {
- pins = "gpio68";
- bias-disable;
- };
-};
-
-&qspi_clk {
- pinconf {
- pins = "gpio63";
- bias-disable;
- };
-};
-
-&qspi_data01 {
- pinconf {
- pins = "gpio64", "gpio65";
-
- /* High-Z when no transfers; nice to park the lines */
- bias-pull-up;
- };
-};
--
2.24.0.525.g8f36a354ae-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] arm64: dts: sc7180: Add a comment to i2c7 about external pullup
2019-12-11 0:35 [PATCH 1/2] arm64: dts: sc7180: Fix indentation/ordering of qspi nodes in sc7180-idp Douglas Anderson
@ 2019-12-11 0:35 ` Douglas Anderson
2019-12-11 4:37 ` Rajendra Nayak
2019-12-11 4:37 ` [PATCH 1/2] arm64: dts: sc7180: Fix indentation/ordering of qspi nodes in sc7180-idp Rajendra Nayak
2019-12-11 6:42 ` Bjorn Andersson
2 siblings, 1 reply; 5+ messages in thread
From: Douglas Anderson @ 2019-12-11 0:35 UTC (permalink / raw)
To: Bjorn Andersson, Andy Gross
Cc: mka, Roja Rani Yarubandi, Rajendra Nayak, Stephen Boyd,
Douglas Anderson, linux-arm-msm, linux-kernel, devicetree,
Rob Herring, Mark Rutland
Make i2c7 symmetric with the other i2c busses and comment that we have
no internal pull because there is an external one.
Fixes: ba3fc6496366 ("arm64: dts: sc7180: Add qupv3_0 and qupv3_1")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
arch/arm64/boot/dts/qcom/sc7180-idp.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
index 5eab3a282eba..05d30a56eca9 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
@@ -311,6 +311,8 @@ &qup_i2c7_default {
pinconf {
pins = "gpio6", "gpio7";
drive-strength = <2>;
+
+ /* Has external pullup */
bias-disable;
};
};
--
2.24.0.525.g8f36a354ae-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] arm64: dts: sc7180: Add a comment to i2c7 about external pullup
2019-12-11 0:35 ` [PATCH 2/2] arm64: dts: sc7180: Add a comment to i2c7 about external pullup Douglas Anderson
@ 2019-12-11 4:37 ` Rajendra Nayak
0 siblings, 0 replies; 5+ messages in thread
From: Rajendra Nayak @ 2019-12-11 4:37 UTC (permalink / raw)
To: Douglas Anderson, Bjorn Andersson, Andy Gross
Cc: mka, Roja Rani Yarubandi, Stephen Boyd, linux-arm-msm,
linux-kernel, devicetree, Rob Herring, Mark Rutland
On 12/11/2019 6:05 AM, Douglas Anderson wrote:
> Make i2c7 symmetric with the other i2c busses and comment that we have
> no internal pull because there is an external one.
>
> Fixes: ba3fc6496366 ("arm64: dts: sc7180: Add qupv3_0 and qupv3_1")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
Reviewed-by: Rajendra Nayak <rnayak@codeaurora.org>
>
> arch/arm64/boot/dts/qcom/sc7180-idp.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> index 5eab3a282eba..05d30a56eca9 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> @@ -311,6 +311,8 @@ &qup_i2c7_default {
> pinconf {
> pins = "gpio6", "gpio7";
> drive-strength = <2>;
> +
> + /* Has external pullup */
> bias-disable;
> };
> };
>
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] arm64: dts: sc7180: Fix indentation/ordering of qspi nodes in sc7180-idp
2019-12-11 0:35 [PATCH 1/2] arm64: dts: sc7180: Fix indentation/ordering of qspi nodes in sc7180-idp Douglas Anderson
2019-12-11 0:35 ` [PATCH 2/2] arm64: dts: sc7180: Add a comment to i2c7 about external pullup Douglas Anderson
@ 2019-12-11 4:37 ` Rajendra Nayak
2019-12-11 6:42 ` Bjorn Andersson
2 siblings, 0 replies; 5+ messages in thread
From: Rajendra Nayak @ 2019-12-11 4:37 UTC (permalink / raw)
To: Douglas Anderson, Bjorn Andersson, Andy Gross
Cc: mka, Roja Rani Yarubandi, Stephen Boyd, linux-arm-msm,
linux-kernel, devicetree, Rob Herring, Mark Rutland
On 12/11/2019 6:05 AM, Douglas Anderson wrote:
> The qspi pinctrl nodes had the wrong intentation and sort ordering and
s/intentation/indentation
> the main qspi node was placed down in the pinctrl section. Fix.
>
> Fixes: ba3fc6496366 ("arm64: dts: sc7180: Add qupv3_0 and qupv3_1")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
Reviewed-by: Rajendra Nayak <rnayak@codeaurora.org>
>
> arch/arm64/boot/dts/qcom/sc7180-idp.dts | 73 +++++++++++++------------
> 1 file changed, 37 insertions(+), 36 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> index 189254f5ae95..5eab3a282eba 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> @@ -232,6 +232,20 @@ vreg_bob: bob {
> };
> };
>
> +&qspi {
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&qspi_clk &qspi_cs0 &qspi_data01>;
> +
> + flash@0 {
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <25000000>;
> + spi-tx-bus-width = <2>;
> + spi-rx-bus-width = <2>;
> + };
> +};
> +
> &qupv3_id_0 {
> status = "okay";
> };
> @@ -250,6 +264,29 @@ &uart8 {
>
> /* PINCTRL - additions to nodes defined in sc7180.dtsi */
>
> +&qspi_clk {
> + pinconf {
> + pins = "gpio63";
> + bias-disable;
> + };
> +};
> +
> +&qspi_cs0 {
> + pinconf {
> + pins = "gpio68";
> + bias-disable;
> + };
> +};
> +
> +&qspi_data01 {
> + pinconf {
> + pins = "gpio64", "gpio65";
> +
> + /* High-Z when no transfers; nice to park the lines */
> + bias-pull-up;
> + };
> +};
> +
> &qup_i2c2_default {
> pinconf {
> pins = "gpio15", "gpio16";
> @@ -364,39 +401,3 @@ pinconf {
> };
> };
>
> -&qspi {
> - status = "okay";
> - pinctrl-names = "default";
> - pinctrl-0 = <&qspi_clk &qspi_cs0 &qspi_data01>;
> -
> - flash@0 {
> - compatible = "jedec,spi-nor";
> - reg = <0>;
> - spi-max-frequency = <25000000>;
> - spi-tx-bus-width = <2>;
> - spi-rx-bus-width = <2>;
> - };
> -};
> -
> -&qspi_cs0 {
> - pinconf {
> - pins = "gpio68";
> - bias-disable;
> - };
> -};
> -
> -&qspi_clk {
> - pinconf {
> - pins = "gpio63";
> - bias-disable;
> - };
> -};
> -
> -&qspi_data01 {
> - pinconf {
> - pins = "gpio64", "gpio65";
> -
> - /* High-Z when no transfers; nice to park the lines */
> - bias-pull-up;
> - };
> -};
>
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] arm64: dts: sc7180: Fix indentation/ordering of qspi nodes in sc7180-idp
2019-12-11 0:35 [PATCH 1/2] arm64: dts: sc7180: Fix indentation/ordering of qspi nodes in sc7180-idp Douglas Anderson
2019-12-11 0:35 ` [PATCH 2/2] arm64: dts: sc7180: Add a comment to i2c7 about external pullup Douglas Anderson
2019-12-11 4:37 ` [PATCH 1/2] arm64: dts: sc7180: Fix indentation/ordering of qspi nodes in sc7180-idp Rajendra Nayak
@ 2019-12-11 6:42 ` Bjorn Andersson
2 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2019-12-11 6:42 UTC (permalink / raw)
To: Douglas Anderson
Cc: Andy Gross, mka, Roja Rani Yarubandi, Rajendra Nayak,
Stephen Boyd, linux-arm-msm, linux-kernel, devicetree,
Rob Herring, Mark Rutland
On Tue 10 Dec 16:35 PST 2019, Douglas Anderson wrote:
> The qspi pinctrl nodes had the wrong intentation and sort ordering and
> the main qspi node was placed down in the pinctrl section. Fix.
>
> Fixes: ba3fc6496366 ("arm64: dts: sc7180: Add qupv3_0 and qupv3_1")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Both patches merged, with improved spelling and r-b from Rajendra.
Thanks,
Bjorn
> ---
>
> arch/arm64/boot/dts/qcom/sc7180-idp.dts | 73 +++++++++++++------------
> 1 file changed, 37 insertions(+), 36 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> index 189254f5ae95..5eab3a282eba 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> @@ -232,6 +232,20 @@ vreg_bob: bob {
> };
> };
>
> +&qspi {
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&qspi_clk &qspi_cs0 &qspi_data01>;
> +
> + flash@0 {
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <25000000>;
> + spi-tx-bus-width = <2>;
> + spi-rx-bus-width = <2>;
> + };
> +};
> +
> &qupv3_id_0 {
> status = "okay";
> };
> @@ -250,6 +264,29 @@ &uart8 {
>
> /* PINCTRL - additions to nodes defined in sc7180.dtsi */
>
> +&qspi_clk {
> + pinconf {
> + pins = "gpio63";
> + bias-disable;
> + };
> +};
> +
> +&qspi_cs0 {
> + pinconf {
> + pins = "gpio68";
> + bias-disable;
> + };
> +};
> +
> +&qspi_data01 {
> + pinconf {
> + pins = "gpio64", "gpio65";
> +
> + /* High-Z when no transfers; nice to park the lines */
> + bias-pull-up;
> + };
> +};
> +
> &qup_i2c2_default {
> pinconf {
> pins = "gpio15", "gpio16";
> @@ -364,39 +401,3 @@ pinconf {
> };
> };
>
> -&qspi {
> - status = "okay";
> - pinctrl-names = "default";
> - pinctrl-0 = <&qspi_clk &qspi_cs0 &qspi_data01>;
> -
> - flash@0 {
> - compatible = "jedec,spi-nor";
> - reg = <0>;
> - spi-max-frequency = <25000000>;
> - spi-tx-bus-width = <2>;
> - spi-rx-bus-width = <2>;
> - };
> -};
> -
> -&qspi_cs0 {
> - pinconf {
> - pins = "gpio68";
> - bias-disable;
> - };
> -};
> -
> -&qspi_clk {
> - pinconf {
> - pins = "gpio63";
> - bias-disable;
> - };
> -};
> -
> -&qspi_data01 {
> - pinconf {
> - pins = "gpio64", "gpio65";
> -
> - /* High-Z when no transfers; nice to park the lines */
> - bias-pull-up;
> - };
> -};
> --
> 2.24.0.525.g8f36a354ae-goog
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-11 6:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-11 0:35 [PATCH 1/2] arm64: dts: sc7180: Fix indentation/ordering of qspi nodes in sc7180-idp Douglas Anderson
2019-12-11 0:35 ` [PATCH 2/2] arm64: dts: sc7180: Add a comment to i2c7 about external pullup Douglas Anderson
2019-12-11 4:37 ` Rajendra Nayak
2019-12-11 4:37 ` [PATCH 1/2] arm64: dts: sc7180: Fix indentation/ordering of qspi nodes in sc7180-idp Rajendra Nayak
2019-12-11 6:42 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).