From: Benoit Parrot <bparrot@ti.com>
To: Tony Lindgren <tony@atomide.com>, Tero Kristo <t-kristo@ti.com>,
<linux-omap@vger.kernel.org>, <linux-clk@vger.kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Benoit Parrot <bparrot@ti.com>
Subject: [Patch v4 03/10] ARM: OMAP: DRA7xx: Make CAM clock domain SWSUP only
Date: Wed, 11 Dec 2019 08:05:51 -0600 [thread overview]
Message-ID: <20191211140558.10407-4-bparrot@ti.com> (raw)
In-Reply-To: <20191211140558.10407-1-bparrot@ti.com>
Both CAL and VIP rely on this clock domain. But CAL DPHY require
LVDSRX_96M_GFCLK to be active. When this domain is set to HWSUP the
LVDSRX_96M_GFCLK is on;y active when VIP1 clock is also active. If only
CAL on DRA72x (which uses the VIP2 clkctrl) probes the CAM domain is
enabled but the LVDSRX_96M_GFCLK is left gated. Since LVDSRX_96M_GFCLK
is sourcing the input clock to the DPHY then actual frame capture cannot
start as the phy are inactive.
So we either have to also enabled VIP1 even if we don't intend on using
it or we need to set the CAM domain to use SWSUP only.
This patch implements the latter.
Signed-off-by: Benoit Parrot <bparrot@ti.com>
Acked-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/mach-omap2/clockdomains7xx_data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/clockdomains7xx_data.c b/arch/arm/mach-omap2/clockdomains7xx_data.c
index 3068802824b7..27835c4d1aa9 100644
--- a/arch/arm/mach-omap2/clockdomains7xx_data.c
+++ b/arch/arm/mach-omap2/clockdomains7xx_data.c
@@ -606,7 +606,7 @@ static struct clockdomain cam_7xx_clkdm = {
.dep_bit = DRA7XX_CAM_STATDEP_SHIFT,
.wkdep_srcs = cam_wkup_sleep_deps,
.sleepdep_srcs = cam_wkup_sleep_deps,
- .flags = CLKDM_CAN_HWSUP_SWSUP,
+ .flags = CLKDM_CAN_SWSUP,
};
static struct clockdomain l4per_7xx_clkdm = {
--
2.17.1
next prev parent reply other threads:[~2019-12-11 14:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 14:05 [Patch v4 00/10] ARM: dts: dra7: add cal nodes Benoit Parrot
2019-12-11 14:05 ` [Patch v4 01/10] clk: ti: dra7: add cam clkctrl data Benoit Parrot
2019-12-30 19:58 ` Stephen Boyd
2020-01-21 7:32 ` Tero Kristo
2019-12-11 14:05 ` [Patch v4 02/10] ARM: dts: dra7: add cam clkctrl node Benoit Parrot
2019-12-11 14:05 ` Benoit Parrot [this message]
2019-12-11 14:05 ` [Patch v4 04/10] ARM: dts: dra7-l4: Add ti-sysc node for CAM Benoit Parrot
2019-12-11 14:05 ` [Patch v4 05/10] ARM: dts: DRA72: Add CAL dtsi node Benoit Parrot
2019-12-11 14:05 ` [Patch v4 06/10] arm: dts: dra72-evm-common: Add entries for the CSI2 cameras Benoit Parrot
2019-12-11 14:05 ` [Patch v4 07/10] arm: dtsi: dra76x: Add CAL dtsi node Benoit Parrot
2019-12-11 14:05 ` [Patch v4 08/10] arm: dts: dra76-evm: Add CAL and OV5640 nodes Benoit Parrot
2019-12-11 14:05 ` [Patch v4 09/10] arm64: dts: k3-am65-main Add CAL node Benoit Parrot
2020-01-24 11:32 ` Tero Kristo
2019-12-11 14:05 ` [Patch v4 10/10] arm64: dts: k3-am654-base-board: Add CSI2 OV5640 camera Benoit Parrot
2020-01-23 17:17 ` [Patch v4 00/10] ARM: dts: dra7: add cal nodes Tony Lindgren
2020-01-23 17:26 ` Tony Lindgren
2020-01-24 7:21 ` Tero Kristo
2020-01-24 7:25 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211140558.10407-4-bparrot@ti.com \
--to=bparrot@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).