From: Olof Johansson <olof@lixom.net>
To: Andrew Murray <andrew.murray@arm.com>
Cc: soc@kernel.org, Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [GIT PULL] PCI: dt: Remove magic numbers for legacy PCI IRQ interrupts
Date: Wed, 11 Dec 2019 08:58:55 -0800 [thread overview]
Message-ID: <20191211165855.kfoz2x63kw3gnlmm@localhost> (raw)
In-Reply-To: <20191211161808.7566-1-andrew.murray@arm.com>
On Wed, Dec 11, 2019 at 04:18:08PM +0000, Andrew Murray wrote:
> Hi Arnd,
>
> Please consider this pull request.
>
> The following changes since commit e42617b825f8073569da76dc4510bfa019b1c35a:
>
> Linux 5.5-rc1 (2019-12-08 14:57:55 -0800)
>
> are available in the Git repository at:
>
> git://linux-arm.org/linux-am.git tags/pci-dt-intx-defines-5.5-rc1
>
> for you to fetch changes up to d50e85b9ad3d4287ab3c5108b7b36ad4fd50e5b4:
>
> dt-bindings: PCI: Use IRQ flags for legacy PCI IRQ interrupts (2019-12-11 16:05:55 +0000)
>
> ----------------------------------------------------------------
> PCI: dt: Remove magic numbers for legacy PCI IRQ interrupts
>
> PCI devices can trigger interrupts via 4 physical/virtual lines known
> as INTA, INTB, INTC or INTD. Due to interrupt swizzling it is often
> required to describe the interrupt mapping in the device tree. Let's
> avoid the existing magic numbers and replace them with a #define to
> improve clarity.
>
> This is based on v5.5-rc1. As this series covers multiple architectures
> and updates include/dt-bindings it was felt that it may be more
> convenient to merge in one go.
That's a pretty high-effort way of doing this, with potential for messy
conflicts.
The standard way of making sweeping changes across the tree is usually to
get the new interface/definition added in one release, and then moving
usage over through the various maintainers in the release after since
the define is then in the base tree for everybody. Would you mind using
the same approach here, please? Especially since this is mostly a cleanup.
Thanks,
-Olof
next prev parent reply other threads:[~2019-12-11 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 16:18 [GIT PULL] PCI: dt: Remove magic numbers for legacy PCI IRQ interrupts Andrew Murray
2019-12-11 16:58 ` Olof Johansson [this message]
2019-12-11 19:33 ` Rob Herring
2019-12-12 20:41 ` Andrew Murray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211165855.kfoz2x63kw3gnlmm@localhost \
--to=olof@lixom.net \
--cc=andrew.murray@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=robh@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox