From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF234C2D0C8 for ; Thu, 12 Dec 2019 08:48:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 907E52465B for ; Thu, 12 Dec 2019 08:48:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728301AbfLLIsN (ORCPT ); Thu, 12 Dec 2019 03:48:13 -0500 Received: from mga06.intel.com ([134.134.136.31]:13439 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728220AbfLLIsM (ORCPT ); Thu, 12 Dec 2019 03:48:12 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Dec 2019 00:48:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,305,1571727600"; d="scan'208";a="238866800" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga004.fm.intel.com with ESMTP; 12 Dec 2019 00:47:59 -0800 Received: from andy by smile with local (Exim 4.93-RC7) (envelope-from ) id 1ifK8c-0007tI-Bw; Thu, 12 Dec 2019 10:47:58 +0200 Date: Thu, 12 Dec 2019 10:47:58 +0200 From: Andy Shevchenko To: Jae Hyun Yoo Cc: Rob Herring , Greg Kroah-Hartman , Lee Jones , Jean Delvare , Guenter Roeck , Mark Rutland , Joel Stanley , Andrew Jeffery , Jonathan Corbet , Gustavo Pimentel , Kishon Vijay Abraham I , Lorenzo Pieralisi , "Darrick J . Wong" , Eric Sandeen , Arnd Bergmann , Wu Hao , Tomohiro Kusumi , "Bryant G . Ly" , Frederic Barrat , "David S . Miller" , Mauro Carvalho Chehab , Andrew Morton , Randy Dunlap , Philippe Ombredanne , Vinod Koul , Stephen Boyd , David Kershner , Uwe Kleine-Konig , Sagar Dharia , Johan Hovold , Thomas Gleixner , Juergen Gross , Cyrille Pitchen , Tomer Maimon , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, openbmc@lists.ozlabs.org, Robin Murphy , Ryan Chen Subject: Re: [PATCH v11 06/14] peci: Add Aspeed PECI adapter driver Message-ID: <20191212084758.GE32742@smile.fi.intel.com> References: <20191211194624.2872-1-jae.hyun.yoo@linux.intel.com> <20191211194624.2872-7-jae.hyun.yoo@linux.intel.com> <20191211202818.GD32742@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Dec 11, 2019 at 04:50:04PM -0800, Jae Hyun Yoo wrote: > On 12/11/2019 12:28 PM, Andy Shevchenko wrote: > > On Wed, Dec 11, 2019 at 11:46:16AM -0800, Jae Hyun Yoo wrote: > > Like in the previous patch... (1) > I see. I'll simplify this function like below: > > #include > > static inline int aspeed_peci_check_idle(struct aspeed_peci *priv) > { > u32 cmd_sts; > > return readl_poll_timeout(priv->base + ASPEED_PECI_CMD, > cmd_sts, > !(cmd_sts & ASPEED_PECI_CMD_IDLE_MASK), > ASPEED_PECI_IDLE_CHECK_INTERVAL_USEC, > ASPEED_PECI_IDLE_CHECK_TIMEOUT_USEC); > } Good for *this* case, but please fix all the rest accordingly. -- With Best Regards, Andy Shevchenko