From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A30AC43603 for ; Mon, 16 Dec 2019 08:54:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E8AB120725 for ; Mon, 16 Dec 2019 08:54:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726989AbfLPIyY (ORCPT ); Mon, 16 Dec 2019 03:54:24 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:55904 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726818AbfLPIyY (ORCPT ); Mon, 16 Dec 2019 03:54:24 -0500 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 08BAE28A017; Mon, 16 Dec 2019 08:54:22 +0000 (GMT) Date: Mon, 16 Dec 2019 09:54:19 +0100 From: Boris Brezillon To: Hugh Cole-Baker Cc: Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Sakari Ailus , linux-media@vger.kernel.org, Mark Rutland , devicetree@vger.kernel.org, Tomasz Figa , Heiko Stuebner , Jonas Karlman , Nicolas Dufresne , Paul Kocialkowski , linux-rockchip@lists.infradead.org, Rob Herring , kernel@collabora.com, Ezequiel Garcia Subject: Re: [PATCH v3 4/7] media: hantro: h264: Use the generic H264 reflist builder Message-ID: <20191216095419.4dfb8501@collabora.com> In-Reply-To: <24EFC68C-CF34-4D6E-8927-1CFA0CE81F45@gmail.com> References: <20191213125414.90725-1-boris.brezillon@collabora.com> <20191213125414.90725-5-boris.brezillon@collabora.com> <24EFC68C-CF34-4D6E-8927-1CFA0CE81F45@gmail.com> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, 14 Dec 2019 15:46:35 +0000 Hugh Cole-Baker wrote: > Hi Boris, > > > On 13 Dec 2019, at 12:54, Boris Brezillon wrote: > > > > Now that the core provides generic reflist builders, we can use them > > instead of implementing our own. > > > > Signed-off-by: Boris Brezillon > > --- > > Changes in v3: > > * New patch > > --- > > drivers/staging/media/hantro/hantro_h264.c | 237 +-------------------- > > 1 file changed, 8 insertions(+), 229 deletions(-) > > > > diff --git a/drivers/staging/media/hantro/hantro_h264.c b/drivers/staging/media/hantro/hantro_h264.c > > index 568640eab3a6..d998272d20e6 100644 > > --- a/drivers/staging/media/hantro/hantro_h264.c > > +++ b/drivers/staging/media/hantro/hantro_h264.c > > @@ -11,7 +11,7 @@ > > */ > > > > #include > > -#include > > +#include > > With this patch, CONFIG_VIDEO_HANTRO needs to depend on CONFIG_V4L2_H264, > without that it can encounter linking errors due to missing symbols for > v4l2_h264_init_reflist_builder, etc. Oops, you're right (I didn't notice it since I had it selected by CONFIG_VIDEO_ROCKCHIP_VDEC). I'll fix that in v4. Thanks, Boris