From: Matthias Kaehlcke <mka@chromium.org>
To: Dikshita Agarwal <dikshita@codeaurora.org>
Cc: andy.gross@linaro.org, david.brown@linaro.org,
robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, vgarodia@codeaurora.org
Subject: Re: [PATCH] arm64: dts: sc7180: Enable video node
Date: Tue, 17 Dec 2019 10:21:54 -0800 [thread overview]
Message-ID: <20191217182154.GU228856@google.com> (raw)
In-Reply-To: <1576569218-24817-1-git-send-email-dikshita@codeaurora.org>
Hi
On Tue, Dec 17, 2019 at 01:23:38PM +0530, Dikshita Agarwal wrote:
> This is a preparation gerrit to enable video node for sc7180.
gerrit is a code review tool, please change to something like
"Add venus video codec node for sc7180"
> This change depends on patch series Venus new features.
Notes like this should not be part of the commit message, but put
below '---'. It would also be good to include a link to the series,
I suppose it's
https://patchwork.kernel.org/project/linux-arm-msm/list/?series=213439
> Signed-off-by: Dikshita Agarwal <dikshita@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 52a5861..ccf9ef5 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -1297,6 +1297,34 @@
>
> #freq-domain-cells = <1>;
> };
> +
> + venus: video-codec@aa00000 {
> + compatible = "qcom,sc7180-venus";
This compatible string is not listed in the bindings
(Documentation/devicetree/bindings/media/qcom,venus.txt), nor
in the driver.
next prev parent reply other threads:[~2019-12-17 18:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 7:53 [PATCH] arm64: dts: sc7180: Enable video node Dikshita Agarwal
2019-12-17 18:21 ` Matthias Kaehlcke [this message]
2019-12-17 19:28 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217182154.GU228856@google.com \
--to=mka@chromium.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dikshita@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=vgarodia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).