From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02C6FC43603 for ; Thu, 19 Dec 2019 07:20:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C81C124676 for ; Thu, 19 Dec 2019 07:20:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wUlqPM9O" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726536AbfLSHUg (ORCPT ); Thu, 19 Dec 2019 02:20:36 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:35713 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726393AbfLSHUf (ORCPT ); Thu, 19 Dec 2019 02:20:35 -0500 Received: by mail-pl1-f193.google.com with SMTP id g6so2147623plt.2 for ; Wed, 18 Dec 2019 23:20:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kscgx3K8f9rm17CyfQ9LRYgvhZGZDTucQRqu6s3cXY8=; b=wUlqPM9OwvDSBUIguTphIAJetJoP7jzTbb4OIqI84eMHS3lsLy9/5tzHTOqCO7QIBw pJrS4iyWynSx5Lp6ccLVem+BqrD+MswvsMg3CoCWPsAo3Yu1MYcq4AOiYJmSYjzndq27 EG+ib26O/X9xpIikIHi8G8mpEGH4B/tgc8M5+/u+wlWdqZZDwPgd/fVxwmw5G/1Rz5lh G4rXxgcmbAF4OVt44n+PpRTdze8k8ywufIRjdT5XJwifVPC1Zsp4Z2ZmBQsbaf0kIFj/ nCJDLd5WCeDxqpRrB0ZlG/AJsmk+VA2atptI2W8+sXubVQiLg7pK2rQHCDq/P/TR6TMK nP6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kscgx3K8f9rm17CyfQ9LRYgvhZGZDTucQRqu6s3cXY8=; b=q6xZ0Ioirv8GhvypMPOjsbxs5Mpb9IaU4rIEac962Hit1Be30l2uRNbuILvBGDyXiY ASoGgfNeEHzappcFMmDBvLjQudanAZuNK1BIQM71ttjsWFq1orJPE8JTtRvRKYP4fJYk hH1S20e9GjCR/ra8ZyZs/Cb8VGso/VF9FzaWCId3uGgxDDDgjB5QCfquxSA0isbTC+ih A1ONamwuFrJJN0SWSMLLiy8LUrI/eu3tqYRRixxLtcbV2qsdnV1sBPOwot6kV6D6SJMT TnoTFfASILqstSPx/yVbWrgQzL9N/Vo5bs/YQy/44nlFV4MG8AddS4AoQi5/SaYEVC2Q 1hAg== X-Gm-Message-State: APjAAAWqsEvZCjKEgPSWDOMwoK05Ai7cFF3tz1OtraphBDJforHjQTjt uZmekJ0yMuhjJAPVzF45y1+29A== X-Google-Smtp-Source: APXvYqwZDaVVbLJc92e8Bk8x6mCLD0JaErRln4COlsW6/zlSXZ0qymPWOOzXN9QDcgGQYfvmGi86Nw== X-Received: by 2002:a17:902:7d84:: with SMTP id a4mr7303034plm.97.1576740034787; Wed, 18 Dec 2019 23:20:34 -0800 (PST) Received: from yoga (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id q6sm6515119pfh.127.2019.12.18.23.20.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2019 23:20:34 -0800 (PST) Date: Wed, 18 Dec 2019 23:20:31 -0800 From: Bjorn Andersson To: pillair@codeaurora.org Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node Message-ID: <20191219072031.GH448416@yoga> References: <0101016ed018cde9-da3dc3e0-de6e-4b18-9add-bc6f88511ab2-000000@us-west-2.amazonses.com> <20191211072053.GH3143381@builder> <000b01d5b631$30ae26f0$920a74d0$@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000b01d5b631$30ae26f0$920a74d0$@codeaurora.org> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed 18 Dec 21:57 PST 2019, pillair@codeaurora.org wrote: > I will raise the next patchset with the comments addressed. > > > -----Original Message----- > > From: Bjorn Andersson > > Sent: Wednesday, December 11, 2019 12:51 PM > > To: Rakesh Pillai > > Cc: devicetree@vger.kernel.org; linux-arm-msm@vger.kernel.org; linux- > > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org > > Subject: Re: [PATCH] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module > > device node > > > > On Wed 04 Dec 00:48 PST 2019, Rakesh Pillai wrote: > > > > > Add device node for the ath10k SNOC platform driver probe > > > and add resources required for WCN3990 on sc7180 soc. > > > > > > Signed-off-by: Rakesh Pillai > > > --- > > > This change is dependent on the below set of changes > > > arm64: dts: sc7180: Add qupv3_0 and qupv3_1 > > (https://lore.kernel.org/patchwork/patch/1150367/) > > > > Why? > > The mentioned series of patchset brings the DTSI for sc7180. > Hence the addition of wifi node is dependent on this series > https://lore.kernel.org/patchwork/patch/1150367/ > I see, this should all be settled now. Looking forward to v2. Thanks, Bjorn > > > > > > --- > > > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 4 ++++ > > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 27 > > +++++++++++++++++++++++++++ > > > 2 files changed, 31 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > > index 189254f..8a6a760 100644 > > > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > > @@ -248,6 +248,10 @@ > > > status = "okay"; > > > }; > > > > > > +&wifi { > > > + status = "okay"; > > > > Please conclude on the representation of the "skip-hyp-mem-assign" and > > add it here, rather than in a subsequent patch - which implies that this > > patch doesn't work on its own. > > > Sure, I will update the next patchset. > > > > > > > +}; > > > + > > > /* PINCTRL - additions to nodes defined in sc7180.dtsi */ > > > > > > &qup_i2c2_default { > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi > > b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > > index 666e9b9..40c9971 100644 > > > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > > > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > > @@ -42,6 +42,12 @@ > > > compatible = "qcom,cmd-db"; > > > no-map; > > > }; > > > + > > > + wlan_fw_mem: wlan_fw_region@93900000 { > > > > wlan_fw_mem: memory@93900000 { > > > > > + compatible = "removed-dma-pool"; > > > + no-map; > > > + reg = <0 0x93900000 0 0x200000>; > > > + }; > > > }; > > > > > > cpus { > > > @@ -1119,6 +1125,27 @@ > > > #clock-cells = <1>; > > > }; > > > }; > > > + > > > + wifi: wifi@18800000 { > > > + status = "disabled"; > > > + compatible = "qcom,wcn3990-wifi"; > > > + reg = <0 0x18800000 0 0x800000>; > > > + reg-names = "membase"; > > > + interrupts = > > > + > */ >, > > > + > */ >, > > > + > */ >, > > > + > */ >, > > > + > */ >, > > > + > */ >, > > > + > */ >, > > > + > */ >, > > > + > */ >, > > > + > */ >, > > > + > */>, > > > + > */>; > > > + memory-region = <&wlan_fw_mem>; > > > > No iommus in sc7180? > > > > Regards, > > Bjorn > > > > > + }; > > > }; > > > > > > timer { > > > -- > > > 2.7.4 > > > > > > > > > _______________________________________________ > > > linux-arm-kernel mailing list > > > linux-arm-kernel@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel