From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F9D4C43603 for ; Thu, 19 Dec 2019 17:47:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7261C222C2 for ; Thu, 19 Dec 2019 17:47:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="LnwL81uJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726905AbfLSRr7 (ORCPT ); Thu, 19 Dec 2019 12:47:59 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:37305 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726884AbfLSRr6 (ORCPT ); Thu, 19 Dec 2019 12:47:58 -0500 Received: by mail-pl1-f195.google.com with SMTP id c23so2886208plz.4 for ; Thu, 19 Dec 2019 09:47:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=T1xXSYuN/agEP+xV7gR2YsC5IQk2uBuXdMCptm0m2YY=; b=LnwL81uJzzHpQGW58xTLid7cnT2djPHkv4Ix1kkA+y3mk249gC8TuTISQnyzyotyvR GyrXXz8pSMkQCGZKN87K77JEeY6MIF+M9UKKVsbZTWFw2RWST60PkhbUouCoWzY5eggA /JVtw0QINwXh9GTwNFh+9uWyDM5/are+lQXj4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=T1xXSYuN/agEP+xV7gR2YsC5IQk2uBuXdMCptm0m2YY=; b=WEo7ujJ3DH1bZpYM2FWSkvK62o3kSFBkXZzFMAvjg6uIx0HIA6TUrdGx7NajG5soBn Q2e9gnbS6Ld1muThOftX07FoZhgOTb6GHp4X5QmP0s/cl5kjFdvbcMCjyJeUcAXjmhc6 aDYLYu3hMnZh+oa5XPbhIHhblA2tWHIu8Tacce1rL8WL1xC9rb32VLtbOQzeS0C6tOyJ yI9W7LHgV1hpdGojqZ3nUmHlTNhyk7UYOOdExRhsrtSMY8R88h9/WxcmwsOce32mrCLw yI8FqP47bYS1+H/Vu6iOdjYuXGxKCaabxJVcroRh4TxbRgmTqYnuwxFSjEjbjx4r3/qa /Ffg== X-Gm-Message-State: APjAAAVAnLW7Ljgkt8MKgvgaTavBC8goDtiX+mgvU9zMXnFhglyahskf 9tEeglZZtzuVaH+oTrsCbPMfog== X-Google-Smtp-Source: APXvYqxSvas1HYsFv66zRl2Qk5NQy60MqFsqe7M1+Z+WlhN/myDxxhPJLJMBff2b/jwrzeoQaazX4A== X-Received: by 2002:a17:90a:cb96:: with SMTP id a22mr10875633pju.96.1576777677975; Thu, 19 Dec 2019 09:47:57 -0800 (PST) Received: from localhost ([2620:15c:202:1:4fff:7a6b:a335:8fde]) by smtp.gmail.com with ESMTPSA id g11sm7967658pgd.26.2019.12.19.09.47.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Dec 2019 09:47:57 -0800 (PST) Date: Thu, 19 Dec 2019 09:47:55 -0800 From: Matthias Kaehlcke To: Rakesh Pillai Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node Message-ID: <20191219174755.GY228856@google.com> References: <1576741521-30102-1-git-send-email-pillair@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1576741521-30102-1-git-send-email-pillair@codeaurora.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Dec 19, 2019 at 01:15:21PM +0530, Rakesh Pillai wrote: > Add device node for the ath10k SNOC platform driver probe > and add resources required for WCN3990 on sc7180 soc. > > Signed-off-by: Rakesh Pillai > --- This does not apply cleanly against the current qcom/arm64-for-5.6 or for-next branch, looks like you need to rebase. > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 5 +++++ > arch/arm64/boot/dts/qcom/sc7180.dtsi | 28 ++++++++++++++++++++++++++++ > 2 files changed, 33 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > index 189254f..b2ca143f 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > @@ -248,6 +248,11 @@ > status = "okay"; > }; > > +&wifi { > + status = "okay"; > + qcom,msa_fixed_perm; What is the status of the patch adding this flag? > +}; > + > /* PINCTRL - additions to nodes defined in sc7180.dtsi */ > > &qup_i2c2_default { > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 666e9b9..ce2d2a5 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -42,6 +42,12 @@ > compatible = "qcom,cmd-db"; > no-map; > }; > + > + wlan_fw_mem: memory@93900000 { > + compatible = "removed-dma-pool"; > + no-map; > + reg = <0 0x93900000 0 0x200000>; > + }; > }; > > cpus { > @@ -1119,6 +1125,28 @@ > #clock-cells = <1>; > }; > }; > + > + wifi: wifi@18800000 { > + status = "disabled"; nit: the convention seems to be to add this at the end of the node, which IMO makes sense since most other fields provide more 'interesting' information.